0007573: add link elements to head of each page

--- core/html_api.php Thu Jan 15 06:14:12 1970 +++ core/html_api.php Thu Jan 15 06:14:12 1970 @@ -159,8 +159,8 @@ * @param string $p_redirect_url url to redirect to if necessary * @return null */ -function html_page_top( $p_page_title = null, $p_redirect_url = null ) { - html_page_top1( $p_page_title ); +function html_page_top( $p_page_title = null, $p_redirect_url = null, $p_extra_headers = null ) { + html_page_top1( $p_page_title, $p_extra_headers ); if ( $p_redirect_url !== null ) { html_meta_redirect( $p_redirect_url ); } @@ -172,7 +172,7 @@ * @param string $p_page_title page title * @return null */ -function html_page_top1( $p_page_title = null ) { +function html_page_top1( $p_page_title = null, $p_extra_headers = null ) { html_begin(); html_head_begin(); html_css(); @@ -183,7 +183,11 @@ if ( !is_blank( $g_robots_meta ) ) { echo "\t", '<meta name="robots" content="', $g_robots_meta, '" />', "\n"; } - + if ( $p_extra_headers !== null ) { + foreach ( $p_extra_headers as $t_header ) { + echo "\t", $t_header, "\n"; + } + } html_rss_link(); $t_favicon_image = config_get( 'favicon_image' ); --- bug_view_inc.php Thu Jan 15 06:14:12 1970 +++ bug_view_inc.php Thu Jan 15 06:14:12 1970 @@ -61,14 +61,30 @@ compress_enable(); + # prev/next <head> <link> + $t_bugslist = gpc_get_cookie( config_get( 'bug_list_cookie' ), false ); + if ( $t_bugslist ) { + $t_bugslist = explode( ',', $t_bugslist ); + $t_index = array_search( $f_bug_id, $t_bugslist ); + if ( false !== $t_index ) { + if ( isset( $t_bugslist[$t_index-1] ) ) { + $t_prev_link = 'bug_view_page.php?bug_id='.$t_bugslist[$t_index-1]; + $t_head_link_arr[] = '<link rel="Prev" href="'.$t_prev_link.'" />'; + } + if ( isset( $t_bugslist[$t_index+1] ) ) { + $t_next_link = 'bug_view_page.php?bug_id='.$t_bugslist[$t_index+1]; + $t_head_link_arr[] = '<link rel="Next" href="'.$t_next_link.'" />'; + } + } + } + if ( $tpl_show_page_header ) { - html_page_top( bug_format_summary( $f_bug_id, SUMMARY_CAPTION ) ); + html_page_top( bug_format_summary( $f_bug_id, SUMMARY_CAPTION ), null, $t_head_link_arr ); print_recently_visited(); } $t_action_button_position = config_get( 'action_button_position' ); - $t_bugslist = gpc_get_cookie( config_get( 'bug_list_cookie' ), false ); $tpl_show_versions = version_should_show_product_version( $tpl_bug->project_id ); $tpl_show_product_version = $tpl_show_versions && in_array( 'product_version', $t_fields ); @@ -241,16 +257,12 @@ # prev/next links if ( $t_bugslist ) { echo '<td class="center"><span class="small">'; - - $t_bugslist = explode( ',', $t_bugslist ); - $t_index = array_search( $f_bug_id, $t_bugslist ); - if ( false !== $t_index ) { - if ( isset( $t_bugslist[$t_index-1] ) ) { - print_bracket_link( 'bug_view_page.php?bug_id='.$t_bugslist[$t_index-1], '<<' ); + if ( isset( $t_prev_link ) || isset( $t_next_link ) ) { + if ( isset( $t_prev_link ) ) { + print_bracket_link( $t_prev_link, '<<' ); } - - if ( isset( $t_bugslist[$t_index+1] ) ) { - print_bracket_link( 'bug_view_page.php?bug_id='.$t_bugslist[$t_index+1], '>>' ); + if ( isset( $t_next_link ) ) { + print_bracket_link( $t_next_link, '>>' ); } } echo '</span></td>';

Notes
(0013690) rickb (reporter) 2006-11-07 08:40	In Firefox, the <link> elements are not visible out of the box. The Link Widgets addon is needed to access them. See https://addons.mozilla.org/firefox/2933/ [^]

(0013695) ryandesign (reporter) 2006-11-07 20:58	I don't know that linking to the next or previous issue, numerically, is useful at all. Perhaps linking to the next and previous issues in the current list of issues would be useful. But if we add <link> tags for those, I would also want <a href> tags added somewhere in the page. There's no point only making <link> tags, since I don't know of any mainstream browser that makes use of those. Adding <link> tags for issues related to the current one could be interesting.

(0013698) rickb (reporter) 2006-11-08 05:21	I quite agree there's not much point having numerical chaining of issues that differs from what the << >> buttons do. Because we already have << and >> links for the chain of issues in the current view, these are the links I had in mind in making my suggestion. The page layout is slightly different from one page to the next. Therefore, the << >> buttons move slightly, so clicking quickly through them takes a bit more attention - so being a bit more distracting. Having <link> equivalents for these two buttons gains the benefit for users of having buttons in one place on the UI as they step through their list of issues.

(0013703) ryandesign (reporter) 2006-11-08 13:21	I forgot we already have << and >> links on the page. In light of that, adding correspending <link> elements makes sense.

(0027519) Sergiodf (reporter) 2010-11-30 15:58	I have attached a patch for Mantis 1.2.3. Tested in Mantis 1.2.1 using Seamonkey 2.0.10 and Firefox 3.6.12 + Site navigation bar 2.0.3.

(0027520) dhx (developer) 2010-11-30 20:20	Great idea. Thanks for the patch too. I've queued this up for 1.3.x.

(0036709) atrol (developer) 2013-04-27 18:41	Removed assignment. dhx will not contribute to this issue in near future.

Issue History
Date Modified	Username	Field	Change
2006-11-07 08:38	rickb	New Issue
2006-11-07 08:40	rickb	Note Added: 0013690
2006-11-07 20:58	ryandesign	Note Added: 0013695
2006-11-08 05:21	rickb	Note Added: 0013698
2006-11-08 13:21	ryandesign	Note Added: 0013703
2010-11-30 15:53	Sergiodf	File Added: 7573.diff
2010-11-30 15:53	Sergiodf	Tag Attached: patch
2010-11-30 15:58	Sergiodf	Note Added: 0027519
2010-11-30 20:19	dhx	Assigned To	=> dhx
2010-11-30 20:19	dhx	Status	new => assigned
2010-11-30 20:20	dhx	Note Added: 0027520
2010-11-30 20:20	dhx	Target Version	=> 1.3.x
2013-04-27 18:41	atrol	Note Added: 0036709
2013-04-27 18:41	atrol	Assigned To	dhx =>
2013-04-27 18:41	atrol	Status	assigned => acknowledged
2013-04-27 18:41	atrol	Target Version	1.3.x =>

Relationships