Mantis Bug Tracker
 

View Issue Details Jump to Notes ] Wiki ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007143mantisbtotherpublic2006-05-28 07:042007-05-08 03:44
Reportervboctor 
Assigned Tovboctor 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0.2 
Target VersionFixed in Version1.0.4 
Summary0007143: Port: checkin.php needs array_unique()
Descriptionif the log message contains e.g.

"bug #408 fixed, blabla,bla bug #408 blaba, bla..."

the log message will be added twice (or as often as #408 appears in the text (including the diff)).

Adding

***************
*** 66,71 ****
--- 66,75 ----
                exit( 1 );
        }
  
+ # add note to each bug only once
+ $t_issues = array_unique( $t_issues );
+ $t_fixed_issues = array_unique( $t_fixed_issues );
+
        # history parameters are reserved for future use.
        $t_history_old_value = '';
        $t_history_new_value = '';

to checkin.php prevents this.
Additional InformationMy system: winxp, php 5.1.4.

if you are interested in my post_commit.cmd, here it is:

REM Post-commit hook for MantisBT integration
SET REPOS=%1
SET REV=%2
SET DETAILS_FILE=c:\tmp\svnfile_%REV%
SET LOG_FILE=c:\tmp\svnfile_%REV%_log
SET AUTH_FILE=c:\tmp\svnfile_%REV%_auth
SET SVN_FILE=c:\tmp\svnfile_%REV%_svn
  
svnlook author -r %REV% %REPOS% > %AUTH_FILE%

echo ^<hr^>^<center^>^<h3^>Source Code Changes^</h3^>^</center^>^<hr^>^<b^>SVN 
Repository:^</b^> %REPOS% > %DETAILS_FILE%
echo ^<b^>SVN Revision:^</b^> %REV% >> %DETAILS_FILE%
FOR /F %%A IN (%AUTH_FILE%) DO echo ^<b^>SVN Author:^</b^> %%A >> %DETAILS_FILE%
echo ^<b^>SVN Log:^</b^> >> %DETAILS_FILE%

rem 
rem extrem komische Sachen mit iconv, sobald es über Eingabeumleitung läuft
rem anders tut es wirklich nicht!
rem 
svnlook log -r %REV% %REPOS% > %SVN_FILE%
iconv -f 850 -t iso-8859-1 %SVN_FILE% >> %DETAILS_FILE%

echo ^<hr^>^<b^>SVN Changed:^</b^> >> %DETAILS_FILE%
svnlook changed -r %REV% %REPOS% >> %DETAILS_FILE%
echo ^<hr^> >> %DETAILS_FILE%

svnlook diff --no-diff-deleted --no-diff-added -r %REV% %REPOS%   >> %DETAILS_FILE%

php.exe d:\b\php-mod\mantis\core\checkin.php < %DETAILS_FILE% >> %LOG_FILE%
DEL %DETAILS_FILE%
DEL %LOG_FILE%
DEL %AUTH_FILE%
TagsNo tags attached.
Attached Files

- Relationships
child of 0007076closedvboctor checkin.php needs array_unique() 
child of 0007052closedvboctor Mantis 1.0.4 Release 

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2006-05-28 07:04 vboctor New Issue
2006-05-28 07:04 vboctor Assigned To => vboctor
2006-05-28 07:04 vboctor Issue generated from 0007076
2006-05-28 07:04 vboctor Relationship added child of 0007076
2006-05-28 10:26 vboctor Relationship added child of 0007052
2006-05-28 10:27 vboctor Status new => resolved
2006-05-28 10:27 vboctor Fixed in Version => 1.0.4
2006-05-28 10:27 vboctor Resolution open => fixed
2007-05-08 03:44 vboctor Status resolved => closed


MantisBT 1.2.2 git master-1.2.x[^]
Copyright © 2000 - 2010 MantisBT Group
Time: 0.2080 seconds.
memory usage: 1,942 KB
Powered by Mantis Bugtracker