View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006772 | mantisbt | other | public | 2006-03-02 07:16 | 2007-12-21 23:16 |
| Reporter | ryandesign | Assigned To | giallu | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0.1 | ||||
| Target Version | 1.1.0 | Fixed in Version | 1.1.0a4 | ||
| Summary | 0006772: Bugnote ids are numeric, which is not valid HTML | ||||
| Description | According to the specs, and easily verifiable if you run a Mantis bug page through an HTML validator, ids must begin with a letter, but Mantis bugnote ids are entirely numeric. | ||||
| Tags | No tags attached. | ||||
| Attached Files | bug6772.patch (1,395 bytes)
Index: bugnote_view_inc.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bugnote_view_inc.php,v
retrieving revision 1.39
diff -u -r1.39 bugnote_view_inc.php
--- bugnote_view_inc.php 3 Jul 2007 12:36:09 -0000 1.39
+++ bugnote_view_inc.php 6 Jul 2007 10:41:05 -0000
@@ -122,7 +122,7 @@
$t_bugnote_note_css = 'bugnote-note-public';
}
?>
-<tr class="bugnote" name="<?php echo $v3_id ?>" id="<?php echo $v3_id ?>">
+<tr class="bugnote" name="c<?php echo $v3_id ?>" id="c<?php echo $v3_id ?>">
<td class="<?php echo $t_bugnote_css ?>">
<span class="small">(<?php echo $t_bugnote_id_formatted ?>)</span><br />
<?php
Index: core/string_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/string_api.php,v
retrieving revision 1.88
diff -u -r1.88 string_api.php
--- core/string_api.php 9 May 2007 20:07:16 -0000 1.88
+++ core/string_api.php 6 Jul 2007 10:41:06 -0000
@@ -564,7 +573,7 @@
# return the name and GET parameters of a bug VIEW page for the given bug
# account for the user preference and site override
function string_get_bugnote_view_url( $p_bug_id, $p_bugnote_id, $p_user_id = null ) {
- return 'view.php?id=' . $p_bug_id . '#'. $p_bugnote_id;
+ return 'view.php?id=' . $p_bug_id . '#c'. $p_bugnote_id;
}
# --------------------
| ||||
|
The attached patch fixes the issue by prefixing a "c" to ids. |
|
|
Thanks. Could you commit it? |
|
|
sure. reassigning to me |
|
|
MantisBT: master 509aedd9 2007-07-06 17:15 Details Diff |
Fix 6772: Bugnote ids are numeric, which is not valid HTML. Also removed invalid "name" attribute git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@4409 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0006772 |
|
| mod - bugnote_view_inc.php | Diff File | ||
| mod - core/string_api.php | Diff File | ||