View Issue Details

IDProjectCategoryView StatusLast Update
0006432mantisbtbugtrackerpublic2006-02-04 05:48
Reportersalmira Assigned Tojlatour  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit trunk 
Fixed in Version1.0.0rc4 
Summary0006432: error processing does not work!
Description

error processing stopped working for all tipes of errors and messages: no errors handling, no required fields handling!...

Additional Information

Caused by uploading the update for file error_api.php [v 1.48 2005/10/29 09:05:41 prichards]

To fix the bug, the file error_api.php:
line 41: if ( 0 == error_reporting() || $p_type = 2048)

should be changed at least to:
line 41: if ( 0 == error_reporting() || $p_type == 2048)

TagsNo tags attached.

Relationships

child of 0005460 closedvboctor Critical Issues to Fix for Mantis 1.0.0 Release 

Activities

salmira

salmira

2005-11-23 11:49

reporter   ~0011648

problem experiences with latest update on 1.0.0rc3.
Severity should be MAJOR.
Soultion included in Additional information.

ryandesign

ryandesign

2005-11-26 18:49

reporter   ~0011654

"$p_type == 2048" is contrary to Mantis coding standards. It should have been written "2048 == $p_type" which would have also caught the error before it was committed.

Fixing in trunk a.k.a. 1.1.0

core/error_api.php -> 1.49

Will someone please merge that to the 1.0.0 branch...

vboctor

vboctor

2005-11-26 21:15

manager   ~0011660

I had a look at 1.0.0rc3 and this ($p_type = 2048) check doesn't exist. Are you sure this issue is applicable to 1.0.0rc3?

salmira

salmira

2005-11-28 02:19

reporter   ~0011661

Excuse me fo not clear description: "latest update on" means the file was updated after rc3.
The described issue appeared after 1.0.0rc3, was found at CVS as Branch:MAIN

http://cvs.sourceforge.net/viewcvs.py/mantisbt/mantisbt/core/error_api.php?rev=1.48&sortby=date&view=markup

line was:
if ( 0 == error_reporting() || $p_type = 2048) {

Now it is Branch:MAIN:

http://cvs.sourceforge.net/viewcvs.py/mantisbt/mantisbt/core/error_api.php?rev=1.48&sortby=date&view=markup

the line is correct correct already (fix posted by ryandesign):
if ( 0 == error_reporting() || 2048 == $p_type ) {

The issue looks to be fixed. Works correctly with my code.

ryandesign

ryandesign

2005-11-28 04:29

reporter   ~0011664

Sorry, I had just looked at HEAD. So does anything need to be done to any tags / branches to make sure the problem doesn't make its way into 1.0.0rc4 or is this issue resolved? (Sorry, I still need to read that CVS tag / branching manual.)

salmira

salmira

2005-11-28 05:11

reporter   ~0011667

Last edited: 2005-12-02 02:40

I do not know the procedure of releaseing for this project exactly, but I guess it looks like nothing more have to be changed, if for generating version 1.0.0rc4, Branch=MAIN and CVS Tag=HEAD will be used. The issue already fixed in mentioned branch\tag, and no more available branches/tags for this priject in CVS after 1.0.0rc3.
So, current issue state can be turned to RESOLVED (FIXED)