0006092: CVS link gets mangled if filename is followed by a newline - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0006092	mantisbt	bugtracker	public	2005-08-07 03:58	2005-09-11 08:12

Reporter	mdelmarter	Assigned To	ryandesign
Priority	normal	Severity	block	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.0.0rc1
Fixed in Version	1.0.0rc2

Summary	0006092: CVS link gets mangled if filename is followed by a newline
Description	I have got Mantis working succefully with CVS on all counts - except this one problem. Basically whenever I create a link like so: cvs:filename.php and it has a new line after the link it will incorrectly format the link. This does not seem to happen if there is nothing after ".php" (including new lines or spaces). I traced it back to the string_nl2br() function - but had to stop there as the regular expression was pushing my limits :) The link thus becomes invalid.
Tags	No tags attached.

mdelmarter 2005-08-07 04:01 reporter ~0011089	I was hoping the problem would display itself on here as well - and it did! Have a look at the link in the Bug Description and you will see the problem in action...

mdelmarter 2005-08-07 04:10 reporter ~0011090	The link was created by using cvs: (then the filename immediately after the colon). I thought I should mention this specifically as it cannot be seen from the description. Also the error is being caused by the function string_nl2br() in the core/strings_api.php file. The function is being called from bug_view_inc.php on line 105.

ryandesign 2005-08-07 10:17 reporter ~0011096	Issue confirmed in CVS HEAD. The regular expression in string_process_cvs_link() in string_api.php is the problem...

ryandesign 2005-08-07 10:45 reporter ~0011098	This issue had been previously reported along with some others in 0005796 but I'll keep the issue in this ticket because I want to deal with it separately.

ryandesign 2005-08-07 11:34 reporter ~0011099	string_api.php -> 1.75