0005228: Attaching multiple files in one go.

(0011467)
Narcissus (developer)
2005-10-05 10:39

For what it's worth guys, I saw this this morning:
http://the-stickman.com/web-development/javascript/upload-multiple-files-with-a-single-file-element/ [^]

For the interface side of things, I thought it was perfect for the job at hand. I will try and integrate it and see where I end up with it...

(0012622)
Daz01 (reporter)
2006-04-19 08:06
edited on: 2006-07-20 11:41

Did anyone resolve this in the end?

(0013430)
stuartjsmith (reporter)
2006-09-22 02:59

Would it be possible to just let the browse dialog that comes up be multiple select capable, and then either just put all the files that are needed to be uploaded in the textbox seperated by a semi-colon (which can then be used as a delimiter to loop around) or to dynamically create as many text boxes that are needed? We would also find this feature very useful.

(0013998)
illes (reporter)
2007-02-02 05:32

This would be a useful feature indeed.

(0015924)
seiji (reporter)
2007-10-21 00:04
edited on: 2007-10-21 19:52

I've attached multiple_files.zip.
It contains multifile.js and patch.txt (for CVS MAIN BRANCH).

(0015995)
phoenixcreation (reporter)
2007-10-26 13:24

I tried the multiple_files.zip above, but with no success. It still does not allow multiple files. I'm going back through to make sure that all the changes were made properly. No crashes upon implementing, just not additional functionality.

(0016459)
phoenixcreation (reporter)
2007-12-17 15:49

OK, finally came back to this one and reran through all the code entries by hand. Appears to work properly in FF, but in IE6 it does not activate the new functionality. No breakage, just doesn't run.

Page comes up with the following errors in IE6:

Error: 'MultiSelector' is undefined

(0016460)
phoenixcreation (reporter)
2007-12-17 20:44

Clarification to the above: Tested it at home, and it does not work in IE7 either. Same error comes up ("Page loads but with errors").

(0016461)
seiji (reporter)
2007-12-17 22:24

Hi phoenixcreation.
I found minor mistake in multifile.js.
Replace multifile.js with attached one.

(0016464)
stefang (reporter)
2007-12-19 04:23
edited on: 2007-12-19 04:26

Hi seji,

I've applied your patches to the latest MANTIS release 1.1.0rc3 and it works fine.

One minor flaw I see: Two "upload file" buttons that have the same functionality. Was this done deliberately?
Screenshot attached (german version: "upload file" = "Datei übertragen").

regards,
Stefan

(0016465)
stefang (reporter)
2007-12-19 04:36

Hi seji,

me again.
The problem with the duplicate button was my bad implementing the patches.
So all your patches work fine with MANTIS 1.1.0rc3.

Thanks for distributing them,
Stefan

(0016467)
phoenixcreation (reporter)
2007-12-19 10:53

Confirmed. Works on IE6 here at work and on IE7 at home. Very nice. :)

Appreciate the work!

(0018357)
monotek (reporter)
2008-07-10 04:02

Will this patch find it way in on of the next releases?

(0020125)
tmatijas (reporter)
2008-11-29 10:13

Applied this patch manually to 1.1.4 and double checked my work. DOES NOT WORK.. When click browse to select, no list comes up.. Then when hit upload, you get

APPLICATION ERROR #1100
Ticket 0 not found.

What am I doing wrong?

(0020130)
stefang (reporter)
2008-11-29 12:08

Works fine here with all Mantis releases since early 1.1.0 RCs.
For every file to be uploaded you have to hit "browse" and select the file. It will be added to a list that can be transferred all in one go with hitting "Upload files".

(0021070)
prabhurangan (reporter)
2009-03-17 13:05

Dear All,

I tried to implement this Feature, in my application. I am able to add multiple files, but while im trying to click 'Upload File' button, it is throwing an error as
'File cannot be uploaded, Mantis cannot see the file. Please check the project settings."

Please share your thoughts;

Regards,
Prabhu.

(0021071)
prabhurangan (reporter)
2009-03-17 13:09

FYI: Im using mantis 1.2.0a3

Regards,
Prabhu

(0021074)
prabhurangan (reporter)
2009-03-18 05:06

@stefand

As this functionality works fine for you, please let me know what would be wrong in myself. I have added all the changes that have been mentioned in patch.txt; however when im using browse button files get add to the list and while i am trying to hit 'Upload File' button i am facing this issue.

Please share your thoughts in this.

REgards,
Prabhu.

(0021075)
stefang (reporter)
2009-03-18 05:17

@ Prabhu

So far I've only implemented this in the Mantis 1.1.x branches which works fine, I don't have any clue about this in Mantis 1.2.x. I'm sorry.

Cheers,
Stefan

(0021076)
prabhurangan (reporter)
2009-03-18 05:33

Hi Stefan,

Thanks for your early reply;

However, any guess on this error message, why this happens.
ERROR:
"File upload failed. File is not readable by Mantis. Please check the project settings."

Is there any format for the files to be uploaded, do we have to perform any settings in our manage projects, to upload files.

Please i don't thing this may be version compatible, as it works fine in 1.1, it should any way work in 1.2;

Or can you please post me your 'Patch.txt' file which you have used.

Regards,
Prabhu

(0021078)
stefang (reporter)
2009-03-18 05:58

The error is thrown in the file_api.php script when the file is not readable (!is_readable).
Can you upload/save files in the release version of the files, i.e. before you implemented the patch? Where do you save the files, in the db or on the disk?

(0021079)
prabhurangan (reporter)
2009-03-18 06:08

Yes i could upload files before applying the patch. I would save in DATABASE.

(0021080)
prabhurangan (reporter)
2009-03-18 06:11

Also i could see the attached file in my mantis_bug_file_table.

Why it could not read this file after applying the patch. But the same file i could upload before applying the patch.

(0021081)
stefang (reporter)
2009-03-18 06:15

I also save my attachements in the database, so this could not be the problem then.

Have you implemented the patch manually, i.e. migrate the patches which were written for an old Mantis 1.1.x release into new sources of mantis 1.2.x, or did you use a tool that automatically merged the patch into the sources?
If you use a tool, then this definitely would go wrong, as the original sources differ.

But this is all just guessing now...

(0021082)
prabhurangan (reporter)
2009-03-18 06:23

No stefand; I manually applied the changes to 1.2 release.

(0021083)
prabhurangan (reporter)
2009-03-18 06:27

In this patch, they have added some lines 'error_parameters($p_filename)' in file_api.php, what this means?

(0021089)
stefang (reporter)
2009-03-18 07:35
edited on: 2009-03-18 07:41

To hunt the issue down:

When does this error happen?
1) Create a new bug and immediately attach files
2) Attach files to an existing bug

This is handled in two different files:
1) bug_report.php
2) bug_file_add.php

Could you pls try both methods and let us know what happens.

(0021090)
prabhurangan (reporter)
2009-03-18 08:03

I tried to create a new bug and uploaded a file to the bug and clicked 'Submit' in Report issue page, but the file is not uploaded.

Also later once the bug is created, i tried to upload the same file, but it is throwing the error message.

Also i tried to upload a file to already existing file, it throws the same error.

(0021091)
prabhurangan (reporter)
2009-03-18 08:24

I have an clarification, in the above patch.txt file, some changes are asked to do in core/html_api.php file; Where to add those script, 'function html_multiupload_script()'.

I think i am doing something wrong in this changes.

(0021092)
prabhurangan (reporter)
2009-03-18 08:25

@stefang

Can you please attach your core/html_api.php file, for reference

(0021093)
prabhurangan (reporter)
2009-03-18 08:27

I could not even create a new bug from report issue page, if i upload any file. It is throwing the same error message.

(0021095)
stefang (reporter)
2009-03-18 09:37
edited on: 2009-03-18 09:38

Attached is an archive including all changed files against Mantis release 1.1.6.
Did you use the updated multifile.js given above?

(0021096)
prabhurangan (reporter)
2009-03-18 09:43

Yes. I used the updated multifile.js. Ok let me check with your files and let you know the status. Thanks a lot Stefang.

(0021115)
cas (reporter)
2009-03-20 04:08

Or simply use:
http://www.mantisbt.org/bugs/view.php?id=10223 [^]

(0021117)
prabhurangan (reporter)
2009-03-20 04:40

@stefang

Please go through the line mentioned in bug_file_upload_inc.php

'<input id="file" name="file[]" type="file" size="40" />' in this the 'id' and 'name' attribute should be same.

(0021121)
stefang (reporter)
2009-03-20 06:21
edited on: 2009-03-20 06:25

@prabhu

What do you mean by "should be the same"? Is my implementation wrong or what? At least it is exactly what the patch.txt has and for ME it is working and for you not...

Did you succeed with your implementation of my changes?

(0021124)
prabhurangan (reporter)
2009-03-20 06:34

@stefang

I am still facing the same issue.

However, the HTML standard is 'id' and 'name' attribute value should be same, as Firefox will access by 'id' and Internet Explorer will access by 'name' attribute.
This is an information i need to pass you.

But i am not saying because of this it is not working for me, But i do not know the exact reason.

Can you get me.

Please be patient, if i am wrong in any means.

(0021125)
prabhurangan (reporter)
2009-03-20 06:34

@stefang

However I need your help in this.

(0025963)
phoenixcreation (reporter)
2010-06-23 08:22

I am having the same issue of having the work against my new 1.2.1 deployment. The JS works (able to "attach" on the screen, but when we go to submit a new issue, or update an existing one, it is unable to find the files for upload.

We are using the alternative version provided above that lists one browse line per file allowed, but that is a little kludgy (no offense) compared to JS version. We had to decrease our max files from 10 to 5 because it added too much to the screen.

Any ideas on how to get this working against a 1.2.1 implementation? Thanks!

(0027401)
istvanb (reporter)
2010-11-17 07:20
edited on: 2011-03-14 05:01

I have uploaded the MANTIS1.2.3_UPLOAD_MULTIPLE ZIP file which has 4 PHP files. Unzip them and copy all the 4 to your main Mantis folder (so next to your config_inc.php). 3 files (out of the 4) in the ZIP will overwrite files on your server so however the solution is tested I recommend to create a backup of those files.

Then go to your config_inc.php and add the following variable:

$g_max_file_num = 2;

where the number equals the maximum number of files you want to upload at the same time. (2-3 is recommended)

This ends up in a change in the issue reporting and the issue viewing page where now you are able to add more files at the same time.

The solution is tested under Mantis 1.2.3 and it affects only 3 + 1 files so it is a pretty straightforward operation.

The "View issue" page mod comes from Cas (see issue the related issue 0010223), the "Report issue" page mod comes from me (see related issue 0012526)

(0031498)
dregad (developer)
2012-03-20 06:50

@rombert - I had started messing around with this towards end of 2011, but never had the time to finish things... You may want to have a look at the work-in-progress (see the upload-* branches on my github fork), maybe there's something you can reuse.

(0031499)
rombert (developer)
2012-03-20 12:29

(In reply to comment 0005228:0031498)
> @rombert - I had started messing around with this towards end of 2011, but never
> had the time to finish things... You may want to have a look at the
> work-in-progress (see the upload-* branches on my github fork), maybe there's
> something you can reuse.

I'll do that, thanks!

(0031505)
rombert (developer)
2012-03-21 18:01

(In reply to comment 0005228:0031498)
> @rombert - I had started messing around with this towards end of 2011, but never
> had the time to finish things... You may want to have a look at the
> work-in-progress (see the upload-* branches on my github fork), maybe there's
> something you can reuse.

Damien, I've taken a look at your upload-multi branch and as far as I can tell this is feature complete. I've added to the docbook documentation but that's about it.

Did you plan on doing anything else?

(0031506)
dregad (developer)
2012-03-21 20:50

To be honest that's a long time ago so you're asking much from my poor Swiss-cheese brain ;-)

As far as I can remember, I had most of the code down, and had started on testing but never finished. I vaguely recall facing issues with error handling, hence the 2 experimental sub-branches, but that might also have been an attempt at fixing the duplicate bug creation issue 0003759.

Note also the missing bug ID in comment for commit 492df564 - I guess I meant to open a new issue for that on the tracker and then forgot to do it. I think the comment should be amended.

I was also thinking about improving the interface using jQuery to dynamically display additional download fields only when they are needed instead of needlessly cluttering the UI with unnecessary fields and buttons.

(0031509)
atrol (developer)
2012-03-22 07:14

0005228:0031506
> I was also thinking about improving the interface using jQuery ...

Keep in mind that
a) MantisBT should also run with JavaScript disabled in Browser or configuration use_javascript = OFF.
b) jQuery is bundled in master but not master-1.2.x (but available as plugin)

ATM phpBB tries to get similar things done in "Google Summer of Code" [1]
They mentioned integration of Plupload [2]

[1] http://wiki.phpbb.com/GSoC/2012/Ideas#Attachment_Improvements [^]
[2] http://www.plupload.com [^]

(0031510)
dregad (developer)
2012-03-22 14:08

@atrol
jQuery was just an idea that I had, indeed targeted at 1.3.x.

I did have a look at a couple of implementations for multi-upload using either js or jQuery, but never went further than that.

Thanks for the references anyway. Might be useful in avoiding reinventing the wheel.

(0031525)
rombert (developer)
2012-03-25 19:40

This is now fixed in both master and master-1.2.x. Damien, thanks for your work, I merely documented and pushed the changes.

(0031526)
jmichae3 (reporter)
2012-03-26 01:28

the HTML5 multi-upload for sf.net is an open source project and it seems to work fairly well and handles fairly large files. it's slick.
I could find out what project it is.

the html5 upload I saw automatically added file browse buttons as needed, you could select multiple files in your upload for one browse button. so essentially, you can go wild with it. it even I think gives a progress bar while you upload.

(0031531)
rombert (developer)
2012-03-26 04:16

(In reply to comment 0005228:0031526)
> the HTML5 multi-upload for sf.net is an open source project and it seems to work
> fairly well and handles fairly large files. it's slick.
> I could find out what project it is.
>

That would be of interest to me. The only note is that, as atrol has noted, we need to work without javascript and we can't rely on jQuery in the 1.2 branch. We can implement it in the 1.3 branch however.

(0031536)
jmichae3 (reporter)
2012-03-26 16:24

http://pypi.python.org/pypi/gp.fileupload/1.1 [^]
it is python WSGI package.
to get the fancy multi-file-browse uploads, apparently you have to use jquery. there may be workarounds(?).
the linux disros I know of all come with firefox, and JS enabled.

(0031540)
dregad (developer)
2012-03-27 05:09

@rombert

I just re-checked, and indeed as I mentioned in 0005228:0031506, the error handling for simultaneous upload of several files is not satisfactory in my opinion. That is why I did not commit my code back then and started experimenting with alternate error handling solutions (branches upload-err-hndl and upload-err-conv.

Test case:

### config_inc.php
$g_file_upload_max_num = 3;
$g_max_file_size = 1000;

a. attach several documents: file1, size < 1000; file2, size > 1000; file3, size < 1000
b. click upload - you get Error 500 (File upload failed) as expected
c. click back button
d. refresh page
e. file1 was uploaded successfully, file2 and file3 were not

This is is confusing to users, and furthermore if you do the same when reporting a new issue and then resubmit, you get duplicate issues (see 0003759)

(0031541)
rombert (developer)
2012-03-27 05:20

@dregad : how would you see this work? Skipping the failed upload and continuing? Reverting all uploaded files?

(0031552)
dregad (developer)
2012-03-27 17:26

I think a failed upload should trigger a warning and let the operation continue. Ideally the confirmation page should display the status of overall operation, listing any file upload failures. I believe such a solution would also resolve 0003759.

(0031553)
jmichae3 (reporter)
2012-03-27 22:24

is error 500 caused by file permissions?

(0031579)
dregad (developer)
2012-03-30 17:58

Marking as resolved in preparation for 1.2.10 release, as discussed with vboctor on the mailing list today. I'll open a separate issue to track the problem with error handling on failed uploads.

(0036281)
grangeway (developer)
2013-04-05 17:57

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets
MantisBT: master 5c7dab02 Timestamp: 2011-11-21 04:46:45 Author: dregad [ Details ] [ Diff ]	Add multiple file upload functionality Adds a new option in config_defaults_inc.php (file_upload_max_num) to determine how many files can be simultaneously uploaded. Modifies the code in issue reporting and view details pages, to enable the new functionality. Fixes 0005228 Conflicts: bug_file_add.php config_defaults_inc.php
	mod - bug_file_add.php	[ Diff ] [ File ]
	mod - bug_file_upload_inc.php	[ Diff ] [ File ]
	mod - config_defaults_inc.php	[ Diff ] [ File ]

MantisBT: master-1.2.x 4599c5ba Timestamp: 2011-11-21 04:46:45 Author: dregad [ Details ] [ Diff ]	Add multiple file upload functionality Adds a new option in config_defaults_inc.php (file_upload_max_num) to determine how many files can be simultaneously uploaded. Modifies the code in issue reporting and view details pages, to enable the new functionality. Fixes 0005228
	mod - bug_file_add.php	[ Diff ] [ File ]
	mod - bug_file_upload_inc.php	[ Diff ] [ File ]
	mod - config_defaults_inc.php	[ Diff ] [ File ]

MantisBT: master 0d5182eb Timestamp: 2011-11-21 05:39:38 Author: dregad [ Details ] [ Diff ]	Add multi-file upload to bug reporting page Fixes 0005228 Conflicts: bug_report.php bug_report_page.php
	mod - bug_report.php	[ Diff ] [ File ]
	mod - bug_report_page.php	[ Diff ] [ File ]

MantisBT: master-1.2.x 2648708b Timestamp: 2011-11-21 05:39:38 Author: dregad [ Details ] [ Diff ]	Add multi-file upload to bug reporting page Fixes 0005228
	mod - bug_report.php	[ Diff ] [ File ]
	mod - bug_report_page.php	[ Diff ] [ File ]

MantisBT: master 6f5b3dfe Timestamp: 2011-11-21 05:53:45 Author: dregad [ Details ] [ Diff ]	I18l support for multi-file upload Adds new strings to handle the plurals when uploading multiple files (e.g. "Upload File" / "Upload Files") and conditionally display the appropriate one depending on value of file_upload_max_num Fixes 0005228 Conflicts: bug_file_upload_inc.php bug_report_page.php lang/strings_english.txt
	mod - bug_file_upload_inc.php	[ Diff ] [ File ]
	mod - bug_report_page.php	[ Diff ] [ File ]
	mod - lang/strings_english.txt	[ Diff ] [ File ]

MantisBT: master-1.2.x b33cacb9 Timestamp: 2011-11-21 05:53:45 Author: dregad [ Details ] [ Diff ]	I18l support for multi-file upload Adds new strings to handle the plurals when uploading multiple files (e.g. "Upload File" / "Upload Files") and conditionally display the appropriate one depending on value of file_upload_max_num Fixes 0005228
	mod - bug_file_upload_inc.php	[ Diff ] [ File ]
	mod - bug_report_page.php	[ Diff ] [ File ]
	mod - lang/strings_english.txt	[ Diff ] [ File ]

MantisBT: master 9b43e690 Timestamp: 2011-11-21 09:39:45 Author: dregad [ Details ] [ Diff ]	Remove duplicate error code and message There were two separate error constants defined, ERROR_DUPLICATE_FILE and ERROR_FILE_DUPLICATE, corresponding to an error message string with identical text. This commit removes the redundant constant ERROR_DUPLICATE_FILE and the corresponding error message. Fixes 0005228 Conflicts: lang/strings_english.txt
	mod - core/constant_inc.php	[ Diff ] [ File ]
	mod - core/file_api.php	[ Diff ] [ File ]
	mod - lang/strings_english.txt	[ Diff ] [ File ]

MantisBT: master-1.2.x 08a3d4fc Timestamp: 2011-11-21 09:39:45 Author: dregad [ Details ] [ Diff ]	Remove duplicate error code and message There were two separate error constants defined, ERROR_DUPLICATE_FILE and ERROR_FILE_DUPLICATE, corresponding to an error message string with identical text. This commit removes the redundant constant ERROR_DUPLICATE_FILE and the corresponding error message. Fixes 0005228
	mod - core/constant_inc.php	[ Diff ] [ File ]
	mod - core/file_api.php	[ Diff ] [ File ]
	mod - lang/strings_english.txt	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2005-02-09 09:23	Daz01	New Issue
2005-02-13 07:29	vboctor	Status	new => acknowledged
2005-08-02 09:37	thraxisp	Relationship added	has duplicate 0005619
2005-10-05 10:39	Narcissus	Note Added: 0011467
2006-02-01 13:35	ryandesign	Relationship added	has duplicate 0006657
2006-04-19 08:06	Daz01	Note Added: 0012622
2006-06-22 14:15	ryandesign	Relationship added	has duplicate 0007221
2006-07-20 11:41	Daz01	Note Edited: 0012622
2006-09-22 02:59	stuartjsmith	Note Added: 0013430
2007-02-02 05:32	illes	Note Added: 0013998
2007-10-21 00:01	seiji	File Added: multiple_files.zip
2007-10-21 00:04	seiji	Note Added: 0015924
2007-10-21 19:52	seiji	Note Edited: 0015924
2007-10-22 06:07	seiji	Tag Attached: patch
2007-10-26 13:24	phoenixcreation	Note Added: 0015995
2007-12-17 15:49	phoenixcreation	Note Added: 0016459
2007-12-17 20:44	phoenixcreation	Note Added: 0016460
2007-12-17 22:16	seiji	File Added: multifile.js
2007-12-17 22:24	seiji	Note Added: 0016461
2007-12-19 04:23	stefang	Note Added: 0016464
2007-12-19 04:25	stefang	File Added: 2xUploadFile-Buttons.jpg
2007-12-19 04:26	stefang	Note Edited: 0016464
2007-12-19 04:36	stefang	Note Added: 0016465
2007-12-19 10:53	phoenixcreation	Note Added: 0016467
2008-07-02 11:03	giallu	Relationship added	has duplicate 0009329
2008-07-10 04:02	monotek	Note Added: 0018357
2008-11-29 10:13	tmatijas	Note Added: 0020125
2008-11-29 12:08	stefang	Note Added: 0020130
2008-12-03 05:43	giallu	Relationship added	has duplicate 0009907
2009-02-19 16:00	giallu	Relationship added	has duplicate 0010147
2009-03-17 13:05	prabhurangan	Note Added: 0021070
2009-03-17 13:09	prabhurangan	Note Added: 0021071
2009-03-18 05:06	prabhurangan	Note Added: 0021074
2009-03-18 05:17	stefang	Note Added: 0021075
2009-03-18 05:33	prabhurangan	Note Added: 0021076
2009-03-18 05:58	stefang	Note Added: 0021078
2009-03-18 06:08	prabhurangan	Note Added: 0021079
2009-03-18 06:11	prabhurangan	Note Added: 0021080
2009-03-18 06:15	stefang	Note Added: 0021081
2009-03-18 06:23	prabhurangan	Note Added: 0021082
2009-03-18 06:27	prabhurangan	Note Added: 0021083
2009-03-18 07:35	stefang	Note Added: 0021089
2009-03-18 07:41	stefang	Note Edited: 0021089
2009-03-18 08:03	prabhurangan	Note Added: 0021090
2009-03-18 08:24	prabhurangan	Note Added: 0021091
2009-03-18 08:25	prabhurangan	Note Added: 0021092
2009-03-18 08:27	prabhurangan	Note Added: 0021093
2009-03-18 09:36	stefang	File Added: Implemented against 1.1.6.zip
2009-03-18 09:37	stefang	Note Added: 0021095
2009-03-18 09:38	stefang	Note Edited: 0021095
2009-03-18 09:43	prabhurangan	Note Added: 0021096
2009-03-20 04:08	cas	Note Added: 0021115
2009-03-20 04:40	prabhurangan	Note Added: 0021117
2009-03-20 06:21	stefang	Note Added: 0021121
2009-03-20 06:25	stefang	Note Edited: 0021121
2009-03-20 06:34	prabhurangan	Note Added: 0021124
2009-03-20 06:34	prabhurangan	Note Added: 0021125
2010-06-23 08:22	phoenixcreation	Note Added: 0025963
2010-11-11 02:56	atrol	Relationship added	has duplicate 0012526
2010-11-11 02:57	atrol	Category	bugtracker => attachments
2010-11-16 16:45	atrol	Relationship added	has duplicate 0010223
2010-11-17 07:11	istvanb	File Added: MANTIS1.2.3_UPLOAD_MULTIPLE.zip
2010-11-17 07:20	istvanb	Note Added: 0027401
2010-11-17 07:25	istvanb	Note Edited: 0027401	View Revisions
2011-01-19 06:24	aldev	Note Added: 0027999
2011-01-20 04:15	aldev	Note Deleted: 0027999
2011-03-14 05:01	istvanb	Note Edited: 0027401	View Revisions
2011-08-31 04:41	atrol	Relationship added	has duplicate 0013279
2011-09-09 03:48	dregad	Relationship added	has duplicate 0013297
2011-11-23 18:39	belfar	Note Added: 0030308
2011-11-26 14:23	dregad	Relationship added	related to 0003759
2012-03-19 18:24	rombert	Assigned To	=> rombert
2012-03-19 18:24	rombert	Reproducibility	always => N/A
2012-03-19 18:24	rombert	Status	acknowledged => assigned
2012-03-19 18:24	rombert	Target Version	=> 1.2.10
2012-03-20 06:50	dregad	Note Added: 0031498
2012-03-20 12:29	rombert	Note Added: 0031499
2012-03-21 01:02	vboctor	Note Deleted: 0030308
2012-03-21 18:01	rombert	Note Added: 0031505
2012-03-21 20:50	dregad	Note Added: 0031506
2012-03-22 07:14	atrol	Note Added: 0031509
2012-03-22 14:08	dregad	Note Added: 0031510
2012-03-25 19:40	rombert	Note Added: 0031525
2012-03-25 19:40	rombert	Status	assigned => resolved
2012-03-25 19:40	rombert	Resolution	open => fixed
2012-03-25 19:40	rombert	Fixed in Version	=> 1.2.10
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master 9b43e690
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master 6f5b3dfe
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master 0d5182eb
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master 5c7dab02
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master-1.2.x 08a3d4fc
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master-1.2.x b33cacb9
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master-1.2.x 2648708b
2012-03-25 20:00	dregad	Changeset attached	=> MantisBT master-1.2.x 4599c5ba
2012-03-26 01:28	jmichae3	Note Added: 0031526
2012-03-26 04:16	rombert	Note Added: 0031531
2012-03-26 16:24	jmichae3	Note Added: 0031536
2012-03-27 05:09	dregad	Note Added: 0031540
2012-03-27 05:09	dregad	Status	resolved => feedback
2012-03-27 05:09	dregad	Resolution	fixed => reopened
2012-03-27 05:20	rombert	Note Added: 0031541
2012-03-27 05:20	rombert	Assigned To	rombert => thraxisp
2012-03-27 13:06	rombert	Assigned To	thraxisp => rombert
2012-03-27 17:26	dregad	Note Added: 0031552
2012-03-27 22:24	jmichae3	Note Added: 0031553
2012-03-30 17:58	dregad	Note Added: 0031579
2012-03-30 17:58	dregad	Status	feedback => resolved
2012-03-30 17:58	dregad	Resolution	reopened => fixed
2012-03-30 17:58	dregad	Assigned To	rombert => dregad
2012-03-30 18:03	dregad	Issue cloned: 0014113
2012-03-30 18:03	dregad	Relationship added	related to 0014113
2012-04-01 20:11	vboctor	Status	resolved => closed
2012-05-29 15:45	atrol	Relationship added	related to 0014306
2013-04-05 17:57	grangeway	Status	closed => acknowledged
2013-04-05 17:57	grangeway	Note Added: 0036281
2013-04-05 18:31	grangeway	Relationship added	related to 0015721
2013-04-06 03:41	dregad	Status	acknowledged => closed
2013-04-06 07:23	grangeway	Status	closed => acknowledged
2013-04-06 09:22	dregad	Tag Attached: 2.0.x check
2013-04-06 09:23	dregad	Status	acknowledged => closed
2013-04-23 11:22	dregad	Relationship added	related to 0015774

Notes
(0011467) Narcissus (developer) 2005-10-05 10:39	For what it's worth guys, I saw this this morning: http://the-stickman.com/web-development/javascript/upload-multiple-files-with-a-single-file-element/ [^] For the interface side of things, I thought it was perfect for the job at hand. I will try and integrate it and see where I end up with it...

(0012622) Daz01 (reporter) 2006-04-19 08:06 edited on: 2006-07-20 11:41	Did anyone resolve this in the end?

(0013430) stuartjsmith (reporter) 2006-09-22 02:59	Would it be possible to just let the browse dialog that comes up be multiple select capable, and then either just put all the files that are needed to be uploaded in the textbox seperated by a semi-colon (which can then be used as a delimiter to loop around) or to dynamically create as many text boxes that are needed? We would also find this feature very useful.

(0013998) illes (reporter) 2007-02-02 05:32	This would be a useful feature indeed.

(0015924) seiji (reporter) 2007-10-21 00:04 edited on: 2007-10-21 19:52	I've attached multiple_files.zip. It contains multifile.js and patch.txt (for CVS MAIN BRANCH).

(0015995) phoenixcreation (reporter) 2007-10-26 13:24	I tried the multiple_files.zip above, but with no success. It still does not allow multiple files. I'm going back through to make sure that all the changes were made properly. No crashes upon implementing, just not additional functionality.

(0016459) phoenixcreation (reporter) 2007-12-17 15:49	OK, finally came back to this one and reran through all the code entries by hand. Appears to work properly in FF, but in IE6 it does not activate the new functionality. No breakage, just doesn't run. Page comes up with the following errors in IE6: Error: 'MultiSelector' is undefined

(0016460) phoenixcreation (reporter) 2007-12-17 20:44	Clarification to the above: Tested it at home, and it does not work in IE7 either. Same error comes up ("Page loads but with errors").

(0016461) seiji (reporter) 2007-12-17 22:24	Hi phoenixcreation. I found minor mistake in multifile.js. Replace multifile.js with attached one.

(0016464) stefang (reporter) 2007-12-19 04:23 edited on: 2007-12-19 04:26	Hi seji, I've applied your patches to the latest MANTIS release 1.1.0rc3 and it works fine. One minor flaw I see: Two "upload file" buttons that have the same functionality. Was this done deliberately? Screenshot attached (german version: "upload file" = "Datei übertragen"). regards, Stefan

(0016465) stefang (reporter) 2007-12-19 04:36	Hi seji, me again. The problem with the duplicate button was my bad implementing the patches. So all your patches work fine with MANTIS 1.1.0rc3. Thanks for distributing them, Stefan

(0016467) phoenixcreation (reporter) 2007-12-19 10:53	Confirmed. Works on IE6 here at work and on IE7 at home. Very nice. :) Appreciate the work!

(0018357) monotek (reporter) 2008-07-10 04:02	Will this patch find it way in on of the next releases?

(0020125) tmatijas (reporter) 2008-11-29 10:13	Applied this patch manually to 1.1.4 and double checked my work. DOES NOT WORK.. When click browse to select, no list comes up.. Then when hit upload, you get APPLICATION ERROR #1100 Ticket 0 not found. What am I doing wrong?

(0020130) stefang (reporter) 2008-11-29 12:08	Works fine here with all Mantis releases since early 1.1.0 RCs. For every file to be uploaded you have to hit "browse" and select the file. It will be added to a list that can be transferred all in one go with hitting "Upload files".

(0021070) prabhurangan (reporter) 2009-03-17 13:05	Dear All, I tried to implement this Feature, in my application. I am able to add multiple files, but while im trying to click 'Upload File' button, it is throwing an error as 'File cannot be uploaded, Mantis cannot see the file. Please check the project settings." Please share your thoughts; Regards, Prabhu.

(0021071) prabhurangan (reporter) 2009-03-17 13:09	FYI: Im using mantis 1.2.0a3 Regards, Prabhu

(0021074) prabhurangan (reporter) 2009-03-18 05:06	@stefand As this functionality works fine for you, please let me know what would be wrong in myself. I have added all the changes that have been mentioned in patch.txt; however when im using browse button files get add to the list and while i am trying to hit 'Upload File' button i am facing this issue. Please share your thoughts in this. REgards, Prabhu.

(0021075) stefang (reporter) 2009-03-18 05:17	@ Prabhu So far I've only implemented this in the Mantis 1.1.x branches which works fine, I don't have any clue about this in Mantis 1.2.x. I'm sorry. Cheers, Stefan

(0021076) prabhurangan (reporter) 2009-03-18 05:33	Hi Stefan, Thanks for your early reply; However, any guess on this error message, why this happens. ERROR: "File upload failed. File is not readable by Mantis. Please check the project settings." Is there any format for the files to be uploaded, do we have to perform any settings in our manage projects, to upload files. Please i don't thing this may be version compatible, as it works fine in 1.1, it should any way work in 1.2; Or can you please post me your 'Patch.txt' file which you have used. Regards, Prabhu

(0021078) stefang (reporter) 2009-03-18 05:58	The error is thrown in the file_api.php script when the file is not readable (!is_readable). Can you upload/save files in the release version of the files, i.e. before you implemented the patch? Where do you save the files, in the db or on the disk?

(0021079) prabhurangan (reporter) 2009-03-18 06:08	Yes i could upload files before applying the patch. I would save in DATABASE.

(0021080) prabhurangan (reporter) 2009-03-18 06:11	Also i could see the attached file in my mantis_bug_file_table. Why it could not read this file after applying the patch. But the same file i could upload before applying the patch.

(0021081) stefang (reporter) 2009-03-18 06:15	I also save my attachements in the database, so this could not be the problem then. Have you implemented the patch manually, i.e. migrate the patches which were written for an old Mantis 1.1.x release into new sources of mantis 1.2.x, or did you use a tool that automatically merged the patch into the sources? If you use a tool, then this definitely would go wrong, as the original sources differ. But this is all just guessing now...

(0021082) prabhurangan (reporter) 2009-03-18 06:23	No stefand; I manually applied the changes to 1.2 release.

(0021083) prabhurangan (reporter) 2009-03-18 06:27	In this patch, they have added some lines 'error_parameters($p_filename)' in file_api.php, what this means?

(0021089) stefang (reporter) 2009-03-18 07:35 edited on: 2009-03-18 07:41	To hunt the issue down: When does this error happen? 1) Create a new bug and immediately attach files 2) Attach files to an existing bug This is handled in two different files: 1) bug_report.php 2) bug_file_add.php Could you pls try both methods and let us know what happens.

(0021090) prabhurangan (reporter) 2009-03-18 08:03	I tried to create a new bug and uploaded a file to the bug and clicked 'Submit' in Report issue page, but the file is not uploaded. Also later once the bug is created, i tried to upload the same file, but it is throwing the error message. Also i tried to upload a file to already existing file, it throws the same error.

(0021091) prabhurangan (reporter) 2009-03-18 08:24	I have an clarification, in the above patch.txt file, some changes are asked to do in core/html_api.php file; Where to add those script, 'function html_multiupload_script()'. I think i am doing something wrong in this changes.

(0021092) prabhurangan (reporter) 2009-03-18 08:25	@stefang Can you please attach your core/html_api.php file, for reference

(0021093) prabhurangan (reporter) 2009-03-18 08:27	I could not even create a new bug from report issue page, if i upload any file. It is throwing the same error message.

(0021095) stefang (reporter) 2009-03-18 09:37 edited on: 2009-03-18 09:38	Attached is an archive including all changed files against Mantis release 1.1.6. Did you use the updated multifile.js given above?

(0021096) prabhurangan (reporter) 2009-03-18 09:43	Yes. I used the updated multifile.js. Ok let me check with your files and let you know the status. Thanks a lot Stefang.

(0021115) cas (reporter) 2009-03-20 04:08	Or simply use: http://www.mantisbt.org/bugs/view.php?id=10223 [^]

(0021117) prabhurangan (reporter) 2009-03-20 04:40	@stefang Please go through the line mentioned in bug_file_upload_inc.php '<input id="file" name="file[]" type="file" size="40" />' in this the 'id' and 'name' attribute should be same.

(0021121) stefang (reporter) 2009-03-20 06:21 edited on: 2009-03-20 06:25	@prabhu What do you mean by "should be the same"? Is my implementation wrong or what? At least it is exactly what the patch.txt has and for ME it is working and for you not... Did you succeed with your implementation of my changes?

(0021124) prabhurangan (reporter) 2009-03-20 06:34	@stefang I am still facing the same issue. However, the HTML standard is 'id' and 'name' attribute value should be same, as Firefox will access by 'id' and Internet Explorer will access by 'name' attribute. This is an information i need to pass you. But i am not saying because of this it is not working for me, But i do not know the exact reason. Can you get me. Please be patient, if i am wrong in any means.

(0021125) prabhurangan (reporter) 2009-03-20 06:34	@stefang However I need your help in this.

(0025963) phoenixcreation (reporter) 2010-06-23 08:22	I am having the same issue of having the work against my new 1.2.1 deployment. The JS works (able to "attach" on the screen, but when we go to submit a new issue, or update an existing one, it is unable to find the files for upload. We are using the alternative version provided above that lists one browse line per file allowed, but that is a little kludgy (no offense) compared to JS version. We had to decrease our max files from 10 to 5 because it added too much to the screen. Any ideas on how to get this working against a 1.2.1 implementation? Thanks!

(0027401) istvanb (reporter) 2010-11-17 07:20 edited on: 2011-03-14 05:01	I have uploaded the MANTIS1.2.3_UPLOAD_MULTIPLE ZIP file which has 4 PHP files. Unzip them and copy all the 4 to your main Mantis folder (so next to your config_inc.php). 3 files (out of the 4) in the ZIP will overwrite files on your server so however the solution is tested I recommend to create a backup of those files. Then go to your config_inc.php and add the following variable: $g_max_file_num = 2; where the number equals the maximum number of files you want to upload at the same time. (2-3 is recommended) This ends up in a change in the issue reporting and the issue viewing page where now you are able to add more files at the same time. The solution is tested under Mantis 1.2.3 and it affects only 3 + 1 files so it is a pretty straightforward operation. The "View issue" page mod comes from Cas (see issue the related issue 0010223), the "Report issue" page mod comes from me (see related issue 0012526)

(0031498) dregad (developer) 2012-03-20 06:50	@rombert - I had started messing around with this towards end of 2011, but never had the time to finish things... You may want to have a look at the work-in-progress (see the upload-* branches on my github fork), maybe there's something you can reuse.

(0031499) rombert (developer) 2012-03-20 12:29	(In reply to comment 0005228:0031498) > @rombert - I had started messing around with this towards end of 2011, but never > had the time to finish things... You may want to have a look at the > work-in-progress (see the upload-* branches on my github fork), maybe there's > something you can reuse. I'll do that, thanks!

(0031505) rombert (developer) 2012-03-21 18:01	(In reply to comment 0005228:0031498) > @rombert - I had started messing around with this towards end of 2011, but never > had the time to finish things... You may want to have a look at the > work-in-progress (see the upload-* branches on my github fork), maybe there's > something you can reuse. Damien, I've taken a look at your upload-multi branch and as far as I can tell this is feature complete. I've added to the docbook documentation but that's about it. Did you plan on doing anything else?

(0031506) dregad (developer) 2012-03-21 20:50	To be honest that's a long time ago so you're asking much from my poor Swiss-cheese brain ;-) As far as I can remember, I had most of the code down, and had started on testing but never finished. I vaguely recall facing issues with error handling, hence the 2 experimental sub-branches, but that might also have been an attempt at fixing the duplicate bug creation issue 0003759. Note also the missing bug ID in comment for commit 492df564 - I guess I meant to open a new issue for that on the tracker and then forgot to do it. I think the comment should be amended. I was also thinking about improving the interface using jQuery to dynamically display additional download fields only when they are needed instead of needlessly cluttering the UI with unnecessary fields and buttons.

(0031509) atrol (developer) 2012-03-22 07:14	0005228:0031506 > I was also thinking about improving the interface using jQuery ... Keep in mind that a) MantisBT should also run with JavaScript disabled in Browser or configuration use_javascript = OFF. b) jQuery is bundled in master but not master-1.2.x (but available as plugin) ATM phpBB tries to get similar things done in "Google Summer of Code" [1] They mentioned integration of Plupload [2] [1] http://wiki.phpbb.com/GSoC/2012/Ideas#Attachment_Improvements [^] [2] http://www.plupload.com [^]

(0031510) dregad (developer) 2012-03-22 14:08	@atrol jQuery was just an idea that I had, indeed targeted at 1.3.x. I did have a look at a couple of implementations for multi-upload using either js or jQuery, but never went further than that. Thanks for the references anyway. Might be useful in avoiding reinventing the wheel.

(0031525) rombert (developer) 2012-03-25 19:40	This is now fixed in both master and master-1.2.x. Damien, thanks for your work, I merely documented and pushed the changes.

(0031526) jmichae3 (reporter) 2012-03-26 01:28	the HTML5 multi-upload for sf.net is an open source project and it seems to work fairly well and handles fairly large files. it's slick. I could find out what project it is. the html5 upload I saw automatically added file browse buttons as needed, you could select multiple files in your upload for one browse button. so essentially, you can go wild with it. it even I think gives a progress bar while you upload.

(0031531) rombert (developer) 2012-03-26 04:16	(In reply to comment 0005228:0031526) > the HTML5 multi-upload for sf.net is an open source project and it seems to work > fairly well and handles fairly large files. it's slick. > I could find out what project it is. > That would be of interest to me. The only note is that, as atrol has noted, we need to work without javascript and we can't rely on jQuery in the 1.2 branch. We can implement it in the 1.3 branch however.

(0031536) jmichae3 (reporter) 2012-03-26 16:24	http://pypi.python.org/pypi/gp.fileupload/1.1 [^] it is python WSGI package. to get the fancy multi-file-browse uploads, apparently you have to use jquery. there may be workarounds(?). the linux disros I know of all come with firefox, and JS enabled.

(0031540) dregad (developer) 2012-03-27 05:09	@rombert I just re-checked, and indeed as I mentioned in 0005228:0031506, the error handling for simultaneous upload of several files is not satisfactory in my opinion. That is why I did not commit my code back then and started experimenting with alternate error handling solutions (branches upload-err-hndl and upload-err-conv. Test case: ### config_inc.php $g_file_upload_max_num = 3; $g_max_file_size = 1000; a. attach several documents: file1, size < 1000; file2, size > 1000; file3, size < 1000 b. click upload - you get Error 500 (File upload failed) as expected c. click back button d. refresh page e. file1 was uploaded successfully, file2 and file3 were not This is is confusing to users, and furthermore if you do the same when reporting a new issue and then resubmit, you get duplicate issues (see 0003759)

(0031541) rombert (developer) 2012-03-27 05:20	@dregad : how would you see this work? Skipping the failed upload and continuing? Reverting all uploaded files?

(0031552) dregad (developer) 2012-03-27 17:26	I think a failed upload should trigger a warning and let the operation continue. Ideally the confirmation page should display the status of overall operation, listing any file upload failures. I believe such a solution would also resolve 0003759.

(0031553) jmichae3 (reporter) 2012-03-27 22:24	is error 500 caused by file permissions?

(0031579) dregad (developer) 2012-03-30 17:58	Marking as resolved in preparation for 1.2.10 release, as discussed with vboctor on the mailing list today. I'll open a separate issue to track the problem with error handling on failed uploads.

(0036281) grangeway (developer) 2013-04-05 17:57	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch