View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005022 | mantisbt | other | public | 2004-12-20 09:49 | 2010-02-22 14:34 |
Reporter | William Tasso | Assigned To | vboctor | ||
Priority | normal | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | IIS-5 | OS | Windows 2000 | OS Version | Advanced Server |
Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
Summary | 0005022: user-names must not contain dots [.] | ||||
Description | APPLICATION ERROR 0000805 "The username is invalid. Usernames may only contain letters, numbers, spaces, hyphens, and underscores." Is it possible to allow the use of dots (periods) in a user-name? | ||||
Additional Information | This would be useful because we could then advise new users they can use the same login that they use on their (windows) domain - where applicable. | ||||
Tags | No tags attached. | ||||
has duplicate | 0005947 | closed | giallu | allow dots in username |
has duplicate | 0004471 | closed | giallu | Can't add email addresses as usernames from [Manage Accounts][Create New Account] |
has duplicate | 0009616 | closed | giallu | LDAP: Must allow period in user name |
has duplicate | 0009135 | closed | vboctor | LDAP and username like email |
child of | 0004937 | closed | vboctor | Mantis 1.0.0a1 Release |
This can be bypassed by creating a username without the '.', then In this way, I guess, the blocking of usernames containing '.' is |
|
Edit config_defaults_inc.php Now you can create users with . "The username is invalid. Usernames may only contain letters, numbers, spaces, hyphens, underscores and periods." |
|
Reminder sent to: vboctor Do we want to add this by default or can we close? |
|
There are two issues to fix here:
|
|
It would be good to allow dots, in order for corporate users to have consistent usernames for different applications. If IT departments have to "hack" their installation to do this, it prevents them doing simple things like upgrading to the latest version. We have over 600 users on our installation, almost all using dots to match their windows usernames. I would like to see this in the standard distribution so that my company can run standard "un-hacked" Mantis. Otherwise, the company sees it as a support risk. Finally, is there any good technical reason why dots should not be allowed? Presumably not. |
|
See comment 0005022:0015816. By the way, admins just need to update the configuration with a regular expression that they need. So it is a configuration rather than having to hack the code. However, I agree that regular expressions are not everyones cup of tea ;) A good starting point would be to contribute an updated regular expression to this bug. This will make it easier for administrators who want to configure their Mantis installation to accept these letters until it is there out of the box. |
|
I am wondering... what if we move away from the whitelist approach (that is, everything is disallowed unless it matches the regexp) to a blacklist, that is, everything is allowed unless it matches the regexp? Additionally, I agree a regexp is not really user-friendly, so I propose we add a anther option for a plain chars list that we allow (or disallow if we also do the above) then compose the regexp using the char list. I checked and the regexp is used exactly once in the code, so it would be a non invasive change. let me know what you think and I can code a patch straight away |
|
The requests I've seen in the past were mainly relating to supporting email addresses as user login names. Hence, I suggest we start by using a regular expression that allows that and adding to the documentation of the option a couple of useful links relating to regular expression: The regular expression I suggest is: Useful related links are:
I've added the underscore although it is not valid for emails. This is because it is valid for user names. |
|
What do you mean "I've added the underscore although it is not valid for emails."? Underscores are valid in email addresses last I checked? |
|
@SamCPP, I think you are probably right. I've also added space to the regular expression since it was already supported by the previous regular expression. |
|
MantisBT: master a7c34413 2009-10-23 01:19 Details Diff |
Fixes 0005022: user-names must not contain dots [.]. |
Affected Issues 0005022 |
|
mod - lang/strings_english.txt | Diff File | ||
mod - docbook/adminguide/en/configuration.sgml | Diff File | ||
mod - config_defaults_inc.php | Diff File | ||
MantisBT: master-1.2.x a62b19c4 2009-10-23 01:19 Details Diff |
Fixes 0005022: user-names must not contain dots [.]. |
Affected Issues 0005022 |
|
mod - lang/strings_english.txt | Diff File | ||
mod - docbook/adminguide/en/configuration.sgml | Diff File | ||
mod - config_defaults_inc.php | Diff File |