| Anonymous | Login | Signup for a new account | 2013-05-19 04:20 EDT | ![]() |
| Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories |
| View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0004465 | mantisbt | security | public | 2004-09-02 05:16 | 2013-04-06 09:23 | ||||
| Reporter | hugopedersen | ||||||||
| Assigned To | dregad | ||||||||
| Priority | normal | Severity | feature | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | Mantis | OS | Bugtracker | OS Version | 0.19.0rc1 | ||||
| Product Version | |||||||||
| Target Version | 1.2.10 | Fixed in Version | 1.2.10 | ||||||
| Summary | 0004465: Turn off 'save login' feature | ||||||||
| Description | I think it would be nice to be able to configure that the 'save login' feature should be enabled or disabled. I have to edit the login_page.php when there is a new version to remove this option since I have computers where different users with different access levels uses Mantis. But if some one has ticked the 'save login' then all use this name and access level. | ||||||||
| Tags | 2.0.x check, patch | ||||||||
| Attached Files | |||||||||
Relationships |
||||||||||||||||
|
||||||||||||||||
Notes |
|
|
jlatour (reporter) 2004-09-02 14:45 |
I think this problem also exists for installations that are more widely used. Would just adding a warning help? |
|
hugopedersen (reporter) 2004-09-02 23:59 |
I have done some modification on my own setup that allows me to set a config option to disable this option. I have less than no experiance in PHP but I managed to get it working. It may be a solution to warn the user when he/she has selected the option to save the password. |
|
ape (reporter) 2006-12-14 18:24 |
Yup, we could definitely make use of that feature here. We have a large user-base and use the LDAP authentication feature, and we've love to just tighten up the login security just that little bit more. I'll see if I can knock together a patch to make use of a '$g_allow_save_login' config option or something like that. |
|
ape (reporter) 2007-03-27 12:26 |
I've attached the modified version of login_page.php rev 1.52.4.1.6.2 (from Mantis version 1.0.6) and the corresponding patch, which I've been using successfully here for a few months now. Very simple fix; all it needs is something like the following in your config_inc file. # --- save login ---------------- # Setting to disable the 'save login' feature. $g_allow_save_login = OFF; Please give it a try and let me know if it works for you. |
|
dregad (developer) 2012-03-23 10:42 |
Please test attached patch. |
|
atrol (developer) 2012-03-23 11:55 |
@dregad, if you want to introduce this option you should add this also to $g_global_settings in config_defaults_inc.php. |
|
dregad (developer) 2012-03-27 08:54 |
Since it's a global setting relating to security, I guess your remark makes sense. I'll add it. |
|
atrol (developer) 2012-03-27 10:53 |
@dregad, have also a look at function config_is_private in config_api.php This seems to be needed because our access checks for SOAP are not well implemented, see 0012328 |
|
dregad (developer) 2012-03-27 11:28 |
I am not sure. Does it really make sense to deny the SOAP API access to the contents of this new variable? It does not in itself contain any sensitive information, just the fact that users are allowed to use the "permanent" cookie. You can easily obtain the same information just by displaying the login page. |
|
atrol (developer) 2012-03-28 05:13 |
> I am not sure. Does it really make sense to deny the SOAP API access to the contents of this new variable? > You can easily obtain the same information just by displaying the login page. You are right, I am also not sure. Nearly the same can be said for session_validation which is included in function config_is_private. There is no real rule for this decision. Another topic: The patch does not disallow the option to set the permanent cookie. It suppresses just the display of the check box. By manipulation the page in browser you would still be able to save the login. If you really want to be sure that no permanent cookie can be set if $g_allow_permanent_cookie = OFF; you have to add another check in function auth_set_cookies. |
|
dregad (developer) 2012-03-29 07:37 |
> You are right, I am also not sure. I guess we should bounce that off grangeway (as original author of config_is_private function) and rombert. I'll write to the mailing list later as time allows. > Another topic Good catch, thanks ! Fixed in https://github.com/dregad/mantisbt/tree/fix-4465 [^] |
|
dregad (developer) 2012-03-30 17:19 |
Feedback from grangeway on config_is_private: 22:43.33 <Paul24> I think we'd concluded stuff that is a security issue 22:43.35 <Paul24> e.g. passwords 22:43.45 <Paul24> i.e. stuff you shouldn't display in web interface 22:44.33 <Paul24> i'm still not sure I like the fact we got new features going into 1.2, 1.3 and 'next' and my 2.0 branch 22:46.01 <Paul24> so yea private was basically to hide a) paths b) usernames c) passwords d) host/ip's of other servers 22:46.12 <Paul24> so not what your proposing doing Which confirms what I was thinking. So I'll just take the opportunity to better document the function in the code (PHPdoc) and leave it at that unless someone objects. |
|
dregad (developer) 2012-03-30 20:47 |
Changes pushed to github. |
|
grangeway (developer) 2013-04-05 17:57 |
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
Related Changesets |
|||
|
MantisBT: master 766a7d38
Timestamp: 2012-03-23 07:32:54 Author: dregad [ Details ] [ Diff ] |
Fix 0004465: Add config to disable 'save login' feature To increase security, the administrator may want to prevent users from using a 'permanent' cookie, thus forcing them to authenticate each time they start a new session. The new config option 'g_allow_permanent_cookie' enables this. Porting to master branch of the following 1.2.x commits: - 56986173ea3a2da12345acecb11afc7ab374696a - 6a9f3a810dca575cc230808b780a80946acdcb73 - 568ee14305c4c6935b18137032d13de097841286 |
||
| mod - config_defaults_inc.php | [ Diff ] [ File ] | ||
| mod - login.php | [ Diff ] [ File ] | ||
| mod - login_page.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 56986173
Timestamp: 2012-03-23 07:32:54 Author: dregad [ Details ] [ Diff ] |
Fix 0004465: Add config to disable 'save login' feature To increase security, the administrator may want to prevent users from using a 'permanent' cookie, thus forcing them to authenticate each time they start a new session. The new config option 'g_allow_permanent_cookie' enables this. |
||
| mod - config_defaults_inc.php | [ Diff ] [ File ] | ||
| mod - login_page.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 6a9f3a81
Timestamp: 2012-03-27 05:44:35 Author: dregad [ Details ] [ Diff ] |
Add 'allow_permanent_cookie' to g_global_settings Also reflowed the array definition to avoid long lines Fixes 0004465 |
||
| mod - config_defaults_inc.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 568ee143
Timestamp: 2012-03-29 03:24:46 Author: dregad [ Details ] [ Diff ] |
Prevent setting permanent cookie using hand-crafted login.php This commit prevents hand-crafted calls to login.php from setting a permanent cookie when its use is disabled via allow_permanent_cookie setting. Thanks to Roland Becker for catching this. Fixes 0004465 |
||
| mod - login.php | [ Diff ] [ File ] | ||
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2004-09-02 05:16 | hugopedersen | New Issue | |
| 2004-09-02 14:45 | jlatour | Note Added: 0007405 | |
| 2004-09-02 14:45 | jlatour | Status | new => feedback |
| 2004-09-02 23:59 | hugopedersen | Note Added: 0007417 | |
| 2006-12-14 18:24 | ape | Note Added: 0013830 | |
| 2007-03-27 12:16 | ape | File Added: login_page.1.52.4.1.6.2+.php.patch | |
| 2007-03-27 12:22 | ape | File Added: login_page.1.52.4.1.6.2.php | |
| 2007-03-27 12:26 | ape | Note Added: 0014254 | |
| 2008-11-30 06:07 | grangeway | Status | feedback => assigned |
| 2008-11-30 06:07 | grangeway | Assigned To | => grangeway |
| 2009-08-26 21:26 | vboctor | Tag Attached: patch | |
| 2009-08-26 21:32 | vboctor | Relationship added | has duplicate 0010874 |
| 2012-03-23 04:19 | atrol | Relationship added | has duplicate 0014069 |
| 2012-03-23 10:41 | dregad | File Added: 0001-Fix-4465-Add-config-to-disable-save-login-feature.patch | |
| 2012-03-23 10:42 | dregad | Note Added: 0031515 | |
| 2012-03-23 11:55 | atrol | Note Added: 0031516 | |
| 2012-03-27 08:54 | dregad | Note Added: 0031545 | |
| 2012-03-27 08:55 | dregad | Category | feature => security |
| 2012-03-27 08:55 | dregad | Target Version | => 1.2.10 |
| 2012-03-27 10:53 | atrol | Note Added: 0031548 | |
| 2012-03-27 11:28 | dregad | Note Added: 0031550 | |
| 2012-03-28 05:13 | atrol | Note Added: 0031554 | |
| 2012-03-29 07:37 | dregad | Note Added: 0031558 | |
| 2012-03-30 17:19 | dregad | Note Added: 0031577 | |
| 2012-03-30 19:36 | dregad | Assigned To | grangeway => dregad |
| 2012-03-30 20:47 | dregad | Note Added: 0031582 | |
| 2012-03-30 20:47 | dregad | Status | assigned => resolved |
| 2012-03-30 20:47 | dregad | Fixed in Version | => 1.2.10 |
| 2012-03-30 20:47 | dregad | Resolution | open => fixed |
| 2012-03-30 21:00 | dregad | Changeset attached | => MantisBT master 766a7d38 |
| 2012-03-30 21:00 | dregad | Changeset attached | => MantisBT master-1.2.x 568ee143 |
| 2012-03-30 21:00 | dregad | Changeset attached | => MantisBT master-1.2.x 6a9f3a81 |
| 2012-03-30 21:00 | dregad | Changeset attached | => MantisBT master-1.2.x 56986173 |
| 2012-04-01 20:11 | vboctor | Status | resolved => closed |
| 2013-04-05 17:57 | grangeway | Status | closed => acknowledged |
| 2013-04-05 17:57 | grangeway | Note Added: 0036295 | |
| 2013-04-05 18:27 | grangeway | Relationship added | related to 0015721 |
| 2013-04-06 03:41 | dregad | Status | acknowledged => closed |
| 2013-04-06 07:23 | grangeway | Status | closed => acknowledged |
| 2013-04-06 09:22 | dregad | Tag Attached: 2.0.x check | |
| 2013-04-06 09:23 | dregad | Status | acknowledged => closed |
| MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.1845 seconds. memory usage: 2,950 KB |