View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004229 | mantisbt | sql | public | 2004-07-31 14:42 | 2004-11-06 06:29 |
Reporter | rwmj | Assigned To | grangeway | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 0.19.0a2 | ||||
Fixed in Version | 0.19.1 | ||||
Summary | 0004229: Missing parameter "port" in the ADOConnection implementation | ||||
Description | Somehow you forgot the port parameter in the ADOConnection class in core\adodb\drivers\adodb-ado.inc.php | ||||
Additional Information | If you run mysql server on a non standard port you cannot use it for mantisbt. | ||||
Tags | No tags attached. | ||||
I can work around this issue with the following fix: I call this a work around because I don't know if all current and future database apis will work with this syntax. It does, however, work with mysql. It seems to me that port should be passed to the ADOConnection class so each implementation of the ADOConnection class can handle the port number appropriately for the underlying API. |
|
gah, /me forgot about the previous existing of $g_port.. Right, victor, question time: We need to deprecate $p_port or use $p_port only for mysql. For example if your using mantis with say the odbc_mssql driver, you could specify more a 'connection_string' for $g_hostname of: See core/adodb/docs/docs-adodb.htm#adonewconnection Or for pgsql: Personally, i'd be inclined to update config_defaults/documentation to reflect that $p_hostname should be a host:port or host combination and deprecate g_port as this gives us (albeit with a badly named variable), flexibility later on. ADODB also call the first parmeter host, even though it may be a connection string. my suggestion would be: |
|
I agree that we should drop $g_port given that we do the following:
|
|
Sounds good. Paul, are you going to do this? |
|
Manual, changelog, source now reflect this. |
|