View Issue Details

IDProjectCategoryView StatusLast Update
0023693mantisbtbugtrackerpublic2017-12-17 05:13
ReporterZipher Assigned Toatrol  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version2.5.1 
Summary0023693: User with reopen privilege cannot reopen read only issues
Description

As mentioned in the forum: https://www.mantisbt.org/forums/viewtopic.php?f=3&t=24875

This happen to user with privilege to reopen issues but not permitted to modify read only issues.
I thought they will be able to reopen issues then modify the issues.
But indeed, they will not able to reopen the issues nor to modify them.

Steps To Reproduce

The user can click the reopen button and add the message before click reopen again.
But after click the reopen again, error #1103 will show. Saying that the issue is ready only.

I reproduced the error in v2.5.1 and v2.8.0

Additional Information

APPLICATION ERROR #1103
The action cannot be performed because issue "82" is read-only.
Please use the "Back" button in your web browser to return to the previous page. There you can correct whatever problems were identified in this error or select another action. You can also click an option from the menu bar to go directly to a new section.

TagsNo tags attached.

Activities

atrol

atrol

2017-12-04 07:46

developer   ~0058310

Read-only means "not allowed to write / change anything".
I think the behavior is right the way it is, as reopening is a change.

Do you agree?
If so, there would remain just a minor UI issue: The button to reopen should not be displayed if you are not allowed to reopen.

Zipher

Zipher

2017-12-05 05:08

reporter   ~0058315

Hello @atrol,

In my cause, I will like to let reporters reopen issue that happens again. In order to achieve that, I will also need to give them the capability to modify read-only issues for now. But some of the reporters will forget to reopen the issue after adding note on the issue that occurs again. This will keep the issue in closed status and be hidden by default.

I think a solution for that is requiring the reporter to reopen a read-only issue before they can add notes on it. By setting the reporter cannot modified read-only issues but is able to reopen it.

smeynieux

smeynieux

2017-12-06 11:09

reporter   ~0058324

In Mantis administrator guide, it is said that "The bug becomes read/write again if re-opened".
If a user as the right to reopen a bug (reopen_bug_threshold), this one should become read/write again. And this is not the case any more with version 2.5.1 as described previously.

atrol

atrol

2017-12-06 12:44

developer   ~0058325

In Mantis administrator guide, it is said that "The bug becomes read/write again if re-opened".

Please don't quote parts of sentences as this changes the meaning.
The manual tells "The bug becomes read/write again if re-opened and its status becomes less than this threshold."

The whole paragraph is

$g_bug_readonly_status_threshold $g_update_readonly_bug_threshold

Bug becomes readonly if its status is >= $g_bug_readonly_status_threshold. The bug becomes read/write again if re-opened and its status becomes less than this threshold. The default is RESOLVED. Once the bug becomes readonly, a user with an access level greater than or equal to $g_update_readonly_bug_threshold can still edit the bug. 

Once the bug becomes readonly, a user with an access level greater than or equal to $g_update_readonly_bug_threshold can still edit the bug.

Could be rephrased to

Once the bug becomes readonly, a user with an access level less than $g_update_readonly_bug_threshold can not edit the bug.

Reopening is an edit operation, so the behavior is right in my opinion.
Not sure other devs agree, @cproensa @dregad @vboctor thoughts?

dregad

dregad

2017-12-07 00:35

developer   ~0058326

Reopening is an edit operation, so the behavior is right in my opinion.

Correct

smeynieux

smeynieux

2017-12-07 03:24

reporter   ~0058331

So if I understand well, to reopen a bug a user should have an access level greater than or eqaul to reopen_bug_threshold AND update_readonly_bug_threshold. reopen_beg_thresheold alone is not enough. Is that right ?

atrol

atrol

2017-12-07 03:30

developer   ~0058332

Is that right ?

Right

Another approach that might work for you could be to change
$g_bug_readonly_status_threshold = RESOLVED; to $g_bug_readonly_status_threshold = CLOSED;

atrol

atrol

2017-12-07 03:31

developer   ~0058333

@Zipher changing $g_bug_readonly_status_threshold might also be an option for you,