View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0023331 | mantisbt | code cleanup | public | 2017-09-08 10:09 | 2017-10-08 23:53 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Target Version | 2.7.0 | Fixed in Version | 2.7.0 | ||
Summary | 0023331: New user_get_username() API function | ||||
Description | There are many occurrences of Since this is a common usage scenario, it makes sense to have a dedicated API function for this, similar to user_get_realname(); it would also avoid confusion with user_get_name(), which serves a different purpose (display). | ||||
Additional Information | This is a follow-up on @johgoe's suggestion in 0023225:
and the subsequent approval by @vboctor in PR https://github.com/mantisbt/mantisbt/pull/1177 | ||||
Tags | No tags attached. | ||||
MantisBT: master b6d5eb51 2017-09-08 02:44 Details Diff |
New API function user_get_username() Replaces multiple calls to `user_get_field(<id>, 'username')` and avoids confusion with user_get_name(). As discussed in issue 0023225 and PR https://github.com/mantisbt/mantisbt/pull/1177 Fixes 0023331 |
Affected Issues 0023225, 0023331 |
|
mod - account_update.php | Diff File | ||
mod - api/rest/restcore/AuthMiddleware.php | Diff File | ||
mod - api/soap/mc_account_api.php | Diff File | ||
mod - bug_reminder_page.php | Diff File | ||
mod - core/authentication_api.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
mod - core/filter_form_api.php | Diff File | ||
mod - core/ldap_api.php | Diff File | ||
mod - core/rss_api.php | Diff File | ||
mod - core/user_api.php | Diff File | ||
mod - verify.php | Diff File | ||
MantisBT: master 69f166a9 2017-09-08 02:47 Details Diff |
Improve PHPDoc for user_get_name() Better description of the function, and clearly state that it should not be used to retrieve the user's username. Issue 0023331 |
Affected Issues 0023331 |
|
mod - core/user_api.php | Diff File |