View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0021136 | mantisbt | administration | public | 2016-06-17 11:55 | 2016-07-09 19:28 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.13 | ||||
Target Version | 1.3.0 | Fixed in Version | 1.3.0 | ||
Summary | 0021136: Editing config option containing newline corrupts them by inserting tags | ||||
Description | If an existing config option containing newline characters (e.g. 'ABC\nDEF') is edited, it is displayed in the textarea as
And when saved, the br tags are stored as-is in the config table. | ||||
Tags | No tags attached. | ||||
MantisBT: master-1.3.x 7bbf2ea4 2016-06-16 16:11 Details Diff |
Avoid config values corruption when editing them Prior to this, an nl2br() conversion was systematically performed when displaying the config option. This caused insertion of '<br />' tags when editing configs containing newlines, which would then be saved. We now only perform the nl2br conversion when the config is printed for display. Fixes 0021136 |
Affected Issues 0021136 |
|
mod - adm_config_report.php | Diff File | ||
MantisBT: master-1.3.x 9ed0b9f5 2016-07-03 01:50 Details Diff |
Fix config parsing issues and improve unit tests PR https://github.com/mantisbt/mantisbt/pull/796 Fixes 0021124, 0021136 |
Affected Issues 0021124, 0021136 |
|
mod - adm_config_report.php | Diff File | ||
mod - adm_config_set.php | Diff File | ||
mod - core/classes/ConfigParser.class.php | Diff File | ||
mod - core/classes/Tokenizer.class.php | Diff File | ||
mod - tests/Mantis/ConfigParserTest.php | Diff File |