View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020501 | mantisbt | code cleanup | public | 2016-01-11 02:43 | 2016-08-15 09:02 |
Reporter | atrol | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.19 | ||||
Target Version | 1.2.20 | Fixed in Version | 1.2.20 | ||
Summary | 0020501: Installer throws warning in PHP 7 environment | ||||
Description | Environment: Windows 10, XAMPP, PHP 7.0.1, FF 43 Running admin/install.php throws warning: Deprecated: Methods with the same name as their class will not be constructors See http://php.net/manual/en/migration70.deprecated.php#migration70.deprecated.php4-constructors | ||||
Tags | PHP 7 | ||||
I replaced PHP4-style constructors by __construct() in
Also, backported to 1.2.x since we require PHP5 it doesn't hurt. |
|
Not sure if it makes sense to touch 1.2.x in terms of PHP7. Maybe time to activate travis PHP7 in master? |
|
Maybe not, but as I said, it's a simple and straightforward change so it doesn't hurt.
Will do. |
|
MantisBT: master baae433f 2016-01-11 01:49 Details Diff |
PHP7: Remove old-style constructors PHP4-style constructors are deprecated in PHP7. Fixes 0020501 |
Affected Issues 0020501 |
|
mod - core/graphviz_api.php | Diff File | ||
mod - core/user_pref_api.php | Diff File | ||
mod - plugins/MantisGraph/core/Period.php | Diff File | ||
MantisBT: master-1.2.x a9731e94 2016-01-11 01:49 Details Diff |
PHP7: Remove old-style constructors PHP4-style constructors are deprecated in PHP7. Fixes 0020501 |
Affected Issues 0020501 |
|
mod - core/graphviz_api.php | Diff File | ||
mod - core/user_pref_api.php | Diff File | ||
mod - plugins/MantisGraph/core/Period.php | Diff File | ||
MantisBT: master db98d830 2016-05-01 00:59 Details Diff |
PHP7: Remove old-style constructors One function was omitted from baae433f220fe8b0bed41e0ffb4c46942729a142. Fixes 0020501 |
Affected Issues 0020501 |
|
mod - core/graphviz_api.php | Diff File | ||
MantisBT: master-1.2.x 6b9bf08b 2016-05-01 00:59 Details Diff |
PHP7: Remove old-style constructors One function was omitted from a9731e9468f3112bde652326310bd3fcf5086a29. Fixes 0020501 |
Affected Issues 0020501 |
|
mod - core/graphviz_api.php | Diff File |