View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0020443||mantisbt||installation||public||2015-12-29 06:04||2016-06-12 00:43|
|Priority||normal||Severity||major||Reproducibility||have not tried|
|Target Version||1.3.0-rc.2||Fixed in Version||1.3.0-rc.2|
|Summary||0020443: New 'api_token' table does not have standard options|
The schema change to implement 0017766 did not assign the standard table options to the CreateTableSQL statement
array( 'mysql' => 'ENGINE=MyISAM DEFAULT CHARSET=utf8', 'pgsql' => 'WITHOUT OIDS' ) )
This will most likely not be a problem for MySQL since the plan is to move away from the MyISAM engine, and the charset will be inherited from global database settings.
We need to fix this for PostgreSQL however.
Unfortunately, AFAIK the ADOdb data dictionary does not let us alter table options, so it's not possible to do this cleanly without dropping the table and recreating it. That implies
Alternatively, as the presence of an OID field is unlikely to cause any significant issues in Mantis, we could go with a more simple approach of updating upgrade step 200 as appropriate.
Considering the market share of postgresql, I would be tempted to go with the 2nd approach.
Severity set to major because we should not release 1.3.0 with an inconsistent schema.
|Tags||No tags attached.|
Reminder sent to: vboctor
Your feedback on this would be appreciated.
Let's update the existing step since Mantis won't care either way whether OIDS exist or not.
Do we have a wiki page for what we want schema changes to look like and why? If not, it would be useful to add it. We should also use it as a checklist for pull requests related to the db schema.
Pull request https://github.com/mantisbt/mantisbt/pull/699
In the end I merged this fix independently from PR 699, as its primary purpose is to support utf8mb4, which is not blocking for 1.3.0 release.
|2015-12-29 06:04||dregad||New Issue|
|2015-12-29 06:04||dregad||Relationship added||related to 0017766|
|2015-12-29 06:05||dregad||Note Added: 0052203|
|2015-12-29 10:52||vboctor||Note Added: 0052205|
|2016-01-01 19:24||dregad||Assigned To||=> dregad|
|2016-01-01 19:24||dregad||Status||new => assigned|
|2016-01-01 19:25||dregad||Note Added: 0052228|
|2016-01-02 12:36||atrol||Product Version||=> 1.3.0-rc.1|
|2016-01-02 18:12||dregad||Issue cloned: 0020472|
|2016-01-02 18:12||dregad||Relationship added||related to 0020472|
|2016-01-16 17:40||dregad||Changeset attached||=> MantisBT master a21eb8c2|
|2016-01-16 17:40||dregad||Status||assigned => resolved|
|2016-01-16 17:40||dregad||Resolution||open => fixed|
|2016-01-16 17:40||dregad||Fixed in Version||=> 1.3.0-rc.2|
|2016-01-16 18:01||dregad||Note Added: 0052323|
|2016-06-12 00:43||vboctor||Status||resolved => closed|