View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020217 | mantisbt | plug-ins | public | 2015-10-23 07:57 | 2019-01-11 06:39 |
Reporter | cproensa | Assigned To | cproensa | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-beta.3 | ||||
Target Version | 1.3.0-rc.1 | Fixed in Version | 1.3.0-rc.1 | ||
Summary | 0020217: MantisGraph: dont show links for users without access level | ||||
Description | The link for the plugin MantisGraph is showed to all users, even those who dont have access to the page, which results in an "access denied" error | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
trivial fix, PR: https://github.com/mantisbt/mantisbt/pull/663 |
|
Thanks for your contribution ! |
|
This introduces a regression. No time to have a deeper look at the moment, but access_has_project_level is causing issues if you are not logged in (there is no current user and no current project at this moment) |
|
Atrol, i think that happens with 1.2? Plugin init sequence is different in 1.3. At the time the hooks() are called, the core functions are ready |
|
This piece of code is called now when visiting the login page (login_page.php)
Is this what you expect? |
|
you are right, the problem is when aonyomous login is disabled |
|
MantisBT: master 738272f2 2015-10-23 03:59 Committer: dregad Details Diff |
Don't show MantisGraph link for users without access fixes 0020217 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0020217 |
|
mod - plugins/MantisGraph/MantisGraph.php | Diff File | ||
MantisBT: master 2c0b2a59 2015-10-29 03:32 Committer: dregad Details Diff |
Revert 738272f and reimplement hide graph link commit 738272f23900243de35b5f0ce29564274bad3090 to hide Mantisgraph link introduced a regression: failing at login when anonymous login is disabled. Here that change is reverted and the access level check is now placed in the callback function, instead of the hook initialization Fixes 0020217 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0020217 |
|
mod - plugins/MantisGraph/MantisGraph.php | Diff File |