View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0019984 | mantisbt | localization | public | 2015-07-29 08:39 | 2015-09-06 17:37 |
Reporter | badfiles | Assigned To | vboctor | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-beta.2 | ||||
Target Version | 1.3.0-beta.3 | Fixed in Version | 1.3.0-beta.3 | ||
Summary | 0019984: Hardcoded strings in bug_update.php and bug_api.php | ||||
Description | bug_update.php contains core/bug_api.php contains It breaks localization. | ||||
Tags | No tags attached. | ||||
Regression introduced by commit 03c5a5d |
|
This is not really a regression IMO - the hardcoded values where there before the mentioned commit (but encapsulated within email api). It's worth mentioning that these values are not actual issue status codes, just arbitrary strings used to determine the behavior of the email notification process. That being said, it would indeed be cleaner to replace these by constants. |
|
It is a regression as the existing hard coded strings have been replaced by new hardcoded strings that can't be localized There is a string $s_email_notification_title_for_status_bug_resolved |
|
Ah sorry I was not paying close enough attention and misunderstood the issue... I thought you were referring to the 'resolved' and 'closed' constants. |
|
Another proposed PR https://github.com/mantisbt/mantisbt/pull/626 |
|
MantisBT: master 03c5a5d1 2014-01-13 07:30 Paul Richards Details Diff |
Replace email_* calls with raw email_generic calls. This is to try and make a shorter patchset in a bit ;) |
Affected Issues 0019984 |
|
mod - api/soap/mc_issue_api.php | Diff File | ||
mod - bug_report.php | Diff File | ||
mod - bug_update.php | Diff File | ||
mod - core/bug_api.php | Diff File | ||
mod - core/bugnote_api.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
mod - core/sponsorship_api.php | Diff File | ||
MantisBT: master 8193ac33 2015-08-04 19:57 Details Diff |
Revert email_* calls to not use generic API It is undesirable to use this approach for the following: - Having each caller having to know the right language string + call type. - Having a properly named APIs provides better intelli-sense experience. - It is easier to add event spent logic or extra parameters compared to switch statements in generic API. - More inline with the approach of having different email formats based on the change event, rather than a single format which dumps the whole issue, rather than focus on the actual change. Fixes 0019984 This reverts commit 03c5a5d18cfef07dec45a1025072981f24a5f07c. Conflicts: - bug_update.php - core/bugnote_api.php - library/disposable - library/ezc/Base - library/ezc/Graph - library/securimage |
Affected Issues 0019984 |
|
mod - api/soap/mc_issue_api.php | Diff File | ||
mod - bug_report.php | Diff File | ||
mod - bug_update.php | Diff File | ||
mod - core/bug_api.php | Diff File | ||
mod - core/bugnote_api.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
mod - core/sponsorship_api.php | Diff File |