View Issue Details

IDProjectCategoryView StatusLast Update
0019695mantisbtadministrationpublic2016-01-30 09:59
Reportercdijoux Assigned Tocproensa  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionduplicate 
Product Version1.2.17 
Fixed in Version1.3.0-rc.1 
Summary0019695: Error in page "manage_config_workflow_set.php"
Description

Hello,

I have to let Manager of a project do some modification on there workflow.
So i put "Manager" for choice "Who can change workflow" and send link to manager.
But when i tried to save his modification, he has an error "200", because there are an error in code, you check the access to config "status_enum_workflow" instead of check the access to config "set_status_threshold".
This is the diff :

--- a/manage_config_workflow_set.php
+++ b/manage_config_workflow_set.php
@@ -141,10 +141,10 @@
}

# process the access level changes
  • if( config_get_access( 'status_enum_workflow' ) <= $t_access ) {
  • if( config_get_access( 'set_status_threshold' ) <= $t_access ) {

    get changes to access level to change these values

    $f_access = gpc_get( 'status_access' );
  • $t_access_current = config_get_access( 'status_enum_workflow' );
  • $t_access_current = config_get_access( 'set_status_threshold' );

I also see something strange : at the top of this page, in the code, you check if the current user can change the config "notify_flags", but this page doesn't treat this configuration (it's in the "manage_config_email_set.php" page). I didn't see the reason, is it an error ? If not, why did you do this check ?

Line 34 :
$t_can_change_level = min( config_get_access( 'notify_flags' ), config_get_access( 'default_notify_flags' ) );
access_ensure_project_level( $t_can_change_level );

TagsNo tags attached.

Relationships

duplicate of 0016771 closeddregad workflow configuration 

Activities

cproensa

cproensa

2016-01-22 13:59

developer   ~0052359

This issue is resolved in 1.3.0rc1