View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|Target Version||1.3.0-rc.1||Fixed in Version||1.3.0-rc.1|
|Tags||No tags attached.|
Collapse.png (50,100 bytes)
Collapse.png (50,100 bytes)
This is due to the fact that the collapse/expand is handled through jQuery (common.js).
the collapse_api seems to be a not so good implementation
Another side effect, which affects the normal js-enabled case:
please try this css fix:
nice catch... probably deserves its own separate issue, as it would not be so trivial to fix (and is definitely not addressed by your CSS tweak)
Not sure I'm following you here, can you please clarify ?
More to this, i think this is a regression of the CSS changes, 1.2 has the same messed collapse_api but somehow the visibility is set right on page load.
inner.hide() / inner.show()
While having a single inner div with contents as you suggest would probably be fine in most cases, it would only work for "basic" collapsed sections, i.e. those which only contain the "-" button and the section's title.
How would you suggest we handle special cases, e.g. the sponsorship section (the title changes when it's collapsed to show the total amount) or the filters div ?
As mentioned in the PR https://github.com/mantisbt/mantisbt/pull/664, the proposed fix basically disables access to the expanded filter box when js is disabled, so it is not a good solution to the problem.
While I don't disagree with this, I don't recall a formal decision.
cproensa, I opened 0020224 to track the collapse API issues, let's continue this discussion there, and keep this issue focused on fixing the duplicated sections (even if it's just a temporary workaround)
With regards to the JS detection, we have to think of a proper way to do this from PHP.
this is a neat trick:
hiding stuff with jquery startup may cause some flickerig. Remember the attempt to move scripts to footer made it even worse.
However, JS detection should not be needed from server. If it is needed, maybe the design is wrong?
MantisBT: master 9674df6c
Committer: dregad Details Diff
|CSS: Hide collapsed sections when JS is disabled
What is wrong with the collapse_api semantics:
JS writes the collapse state in a cookie; the server retrieves it to
display each section in the proper state. The classes 'collapse_closed'
and 'collapse_open' may be reversed, causing a collapsed section to have
class 'collapse_open'... wtf?
This commit fixes the problem by creating a new class to identify which
section is the collapsed one. This new class is not affected by
Signed-off-by: Damien Regad <firstname.lastname@example.org>
Changes from cproensa's original commits:
- commit message reworded
- CSS rule on a single line
|mod - core/collapse_api.php||Diff File|
|mod - css/default.css||Diff File|
|2015-03-16 15:23||atrol||New Issue|
|2015-03-16 15:23||atrol||File Added: Collapse.png|
|2015-03-16 16:07||atrol||Relationship added||related to 0019501|
|2015-03-16 18:47||dregad||Note Added: 0049245|
|2015-09-01 15:33||atrol||Severity||minor => major|
|2015-09-06 17:46||vboctoradmin||Target Version||1.3.0-beta.3 => 1.3.0-rc.1|
|2015-10-23 11:52||cproensa||Note Added: 0051686|
|2015-10-23 11:57||cproensa||Note Added: 0051687|
|2015-10-23 12:50||cproensa||Note Added: 0051688|
|2015-10-23 19:57||dregad||Note Added: 0051697|
|2015-10-23 21:15||vboctor||Note Added: 0051698|
|2015-10-24 04:06||cproensa||Note Added: 0051699|
|2015-10-24 17:37||dregad||Note Added: 0051700|
|2015-10-24 17:50||vboctor||Note Added: 0051701|
|2015-10-24 17:51||vboctor||Note Edited: 0051701||View Revisions|
|2015-10-24 18:21||dregad||Note Added: 0051702|
|2015-10-24 20:10||cproensa||Note Added: 0051704|
|2015-10-25 06:10||dregad||Relationship added||has duplicate 0019309|
|2015-10-25 06:25||dregad||Note Added: 0051713|
|2015-10-25 06:46||cproensa||Note Added: 0051716|
|2015-10-25 14:50||dregad||Relationship added||related to 0020224|
|2015-10-27 04:13||dregad||Status||new => confirmed|
|2015-10-27 11:50||dregad||Changeset attached||=> MantisBT master 9674df6c|
|2015-10-27 11:50||dregad||Assigned To||=> dregad|
|2015-10-27 11:50||dregad||Status||confirmed => resolved|
|2015-10-27 11:50||dregad||Resolution||open => fixed|
|2015-10-27 11:50||dregad||Fixed in Version||=> 1.3.0-rc.1|
|2015-11-04 15:32||foXen||Note Added: 0051817|
|2015-12-06 02:45||vboctor||Status||resolved => closed|