View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0018034 | mantisbt | timeline | public | 2015-01-19 17:27 | 2015-03-15 19:58 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-beta.1 | ||||
Target Version | 1.3.0-beta.2 | Fixed in Version | 1.3.0-beta.2 | ||
Summary | 0018034: Number of events in timeline is sometimes less than 50 | ||||
Description | Even when there are more than 50 events to display, the timeline sometimes display less entries than that. | ||||
Tags | No tags attached. | ||||
MantisBT: master 523bf91d 2015-01-19 08:37 Details Diff |
Fix number of displayed events lower than 50 Depending on the types of events displayed, in some cases the timeline displayed fewer than 50 entries even though more are available. This is because the 'Status Change' timeline events are only printed for some status types (RESOLVED, CLOSED, REOPENED); prior to this, other types were printed as an empty string. This adds a new private method in IssueStatusChangeTimelineEvent class to determine the type of status change in the constructor and store it as a property, which is then used to reimplement the skip() method as well as to drive html generation. This allows the timeline_events() function to exclude unwanted entries with skip(). In addition, the logic for limiting the number of items to display is now implemented in timeline_print_events() instead of timeline_inc.php. Fixes 0018034 |
Affected Issues 0018034 |
|
mod - core/classes/IssueStatusChangeTimelineEvent.class.php | Diff File | ||
mod - core/classes/TimelineEvent.class.php | Diff File | ||
mod - core/timeline_api.php | Diff File | ||
mod - core/timeline_inc.php | Diff File |