View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017917 | mantisbt | code cleanup | public | 2014-11-24 11:54 | 2016-10-20 11:07 |
Reporter | dregad | Assigned To | |||
Priority | low | Severity | tweak | Reproducibility | N/A |
Status | new | Resolution | open | ||
Product Version | 1.2.18 | ||||
Summary | 0017917: Remove magic constants in filter_api.php / view_all_set.php | ||||
Description | As part of reviewing PR https://github.com/mantisbt/mantisbt/pull/549 I noted we're using magic constant '6'. We should define it, as well as other values for type (and possibly 'simple' and 'advanced' also) in constants_inc.php. | ||||
Tags | No tags attached. | ||||
atrol, I fail to see a relationship with 0020102, can you clarify ? |
|
|
|
i doubt if include this in PR 862 what do you think? fix it at a later step, or go once for all? |
|
This is a low priority, code cleanup task so I'm fine with postponing this. The refactoring PR is big and complex enough as it is ;-) |
|