0017827: Disposable library triggers PHP STRICT warnings - MantisBT - Signup temporarily disabled due to spam

ID	Project	Category	View Status	Date Submitted	Last Update

0017827	mantisbt	email	public	2014-11-01 20:09	2014-12-05 18:33

Reporter	dregad	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.17
Target Version	1.2.18	Fixed in Version	1.2.18

Summary	0017827: Disposable library triggers PHP STRICT warnings
Description	With display_errors set to E_ALL = inline or halt, the disposable library triggers PHP STRICT warnings: "Non-static method should not be called statically"
Steps To Reproduce	Navigate to Manage User page Update a user's e-mail address and submit : Non-static method DisposableEmailChecker::is_disposable_email() should not be called statically : Non-static method DisposableEmailChecker::is_forwarding_email() should not be called statically : Non-static method DisposableEmailChecker::_get_domain_from_address() should not be called statically : Non-static method DisposableEmailChecker::is_trash_email() should not be called statically : Non-static method DisposableEmailChecker::_get_domain_from_address() should not be called statically : Non-static method DisposableEmailChecker::is_time_bound_email() should not be called statically : Non-static method DisposableEmailChecker::_get_domain_from_address() should not be called statically : Non-static method DisposableEmailChecker::is_shredder_email() should not be called statically : Non-static method DisposableEmailChecker::_get_domain_from_address() should not be called statically
Additional Information	This issue does not exist in Master branch, as it has been resolved by https://github.com/mantisbt/disposable_email_checker/commit/1418b9945e234c4cba3f1a0491826b0e7ded9f59
Tags	No tags attached.

dregad 2014-11-01 20:11 developer ~0041740	Reminder sent to: vboctor Do you think it's worth updating the disposable library in 1.2.x ? Either set submodule like in master manually patch to fix issue (i.e. add 'static' keyword to methods where needed) Or considering that it's a minor issue only encountered with "non-prod" error settings, ignore this and close as won't fix ? Let me know your thoughts.

vboctor 2014-11-01 20:43 manager ~0041741	I would do the minimal touch to 1.2.x to get it clean. This could be a localized fix (static), or normal update, but I wouldn't change to submodule. Since that complicates switching branches etc. We will get the submodule via master.