View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0017712mantisbtbugtrackerpublic2014-09-30 06:232014-11-13 01:58
Reporterdregad Assigned Todregad  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionno change required 
Product Version1.3.0dev 
Summary0017712: Regression in menu display
Description

Following implementation of 0017711 I noticed several regressions in the display of submenus, as per attached screenshots

TagsNo tags attached.
Attached Files
submenu1.png (17,024 bytes)   
submenu1.png (17,024 bytes)   
submenu2.png (18,597 bytes)   
submenu2.png (18,597 bytes)   
submenu3.png (4,554 bytes)   
submenu3.png (4,554 bytes)   
submenu4.png (3,020 bytes)   
submenu4.png (3,020 bytes)   
menu_2lines.png (4,893 bytes)   
menu_2lines.png (4,893 bytes)   

Relationships

has duplicate 0017748 closedatrol Formatting error on 'My Account' page 
child of 0017711 closed Move menu generation functionality into Menu Class and update CSS 

Activities

dregad

dregad

2014-09-30 06:25

developer   ~0041321

Also, I personally dislike the ALL CAPS for menus.
dregad

dregad

2014-09-30 06:36

developer   ~0041323

Note for screenshot "submenu1.png" - there should actually be no submenu when reauthenticating.
dregad

dregad

2014-09-30 09:27

developer   ~0041324

On a narrow window, the menu is split on 2 lines and it does not look good (see menu_2lines.png) - I think adding a border between top and bottom rows would be better.
atrol

atrol

2014-10-05 06:35

developer   ~0041374

The second menu when setting $g_show_footer_menu = ON; has white background instead of grey.
atrol

atrol

2014-10-06 03:25

developer   ~0041421

The "Workflow Transitions" link is no longer available on page "Manage" > "Manage Configuration"
atrol

atrol

2014-10-06 04:05

developer   ~0041423

Also, I personally dislike the ALL CAPS for menus.

Me too,
remove: text-transform: uppercase;

I also don't like the transitions
remove: transition: color 450ms ease-in-out 0s, background-color 450ms ease-in-out 0s;
dregad

dregad

2014-10-06 08:07

developer   ~0041426

I also don't like the transitions

That does not bother me, I think the transitions look nice actually, but I don't care so much if they are removed.
vboctor

vboctor

2014-10-25 02:44

manager   ~0041658

The change causing the bug was reverted. So removing the targeting to 1.3.x.
dregad

dregad

2014-10-28 09:00

developer   ~0041693

Since changes introduced by 0017711 have been reverted, this is no longer applicable.

Related Changesets

MantisBT: master 0b13955c

2014-10-18 13:22

dregad


Details Diff		 Revert "Move menu generation functionality into Menu Class and update CSS"

This commit was merged without approval or review from the team, and
introduced several regressions and issues, documented in

- Issue 0017712: errors in menu and submenu display
- Issue 0017779: New Menu Class is breaking plugins

See also issue 0017711 and comments in pull request #316.

This reverts commit 29c2f8211de8869b3b1b072467b54252d0db5024.		 Affected Issues
0017711, 0017712, 0017779
mod - account_page.php Diff File
mod - account_prefs_inc.php Diff File
mod - account_prof_edit_page.php Diff File
mod - account_prof_menu_page.php Diff File
mod - account_sponsor_page.php Diff File
mod - adm_config_report.php Diff File
mod - adm_permissions_report.php Diff File
rm - config_menu_defaults_inc.php Diff
mod - core.php Diff File
rm - core/classes/MantisMenu.class.php Diff
mod - core/html_api.php Diff File
mod - css/default.css Diff File
mod - manage_columns_inc.php Diff File
mod - manage_config_columns_page.php Diff File
mod - manage_config_email_page.php Diff File
mod - manage_config_work_threshold_page.php Diff File
mod - manage_config_workflow_graph_page.php Diff File
mod - manage_config_workflow_page.php Diff File
mod - manage_custom_field_edit_page.php Diff File
mod - manage_custom_field_page.php Diff File
mod - manage_overview_page.php Diff File
mod - manage_plugin_page.php Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File
mod - manage_proj_ver_edit_page.php Diff File
mod - manage_tags_page.php Diff File
mod - manage_user_create_page.php Diff File
mod - manage_user_edit_page.php Diff File
mod - manage_user_page.php Diff File
mod - plugins/MantisCoreFormatting/pages/config.php Diff File
mod - plugins/MantisGraph/pages/config.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php Diff File
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php Diff File
mod - plugins/MantisGraph/pages/summary_jpgraph_page.php Diff File
mod - plugins/XmlImportExport/pages/import.php Diff File
mod - plugins/XmlImportExport/pages/import_action.php Diff File
mod - proj_doc_add_page.php Diff File
mod - proj_doc_edit_page.php Diff File
mod - proj_doc_page.php Diff File
mod - summary_page.php Diff File