View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017711 | mantisbt | ui | public | 2014-09-30 06:11 | 2016-07-19 11:45 |
Reporter | dregad | Assigned To | |||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | won't fix | ||
Summary | 0017711: Move menu generation functionality into Menu Class and update CSS | ||||
Description | This is created for tracking purposes following unsanctioned merge of pull request https://github.com/mantisbt/mantisbt/pull/316 | ||||
Tags | No tags attached. | ||||
I reverted this change on the basis of the discussion in https://github.com/mantisbt/mantisbt/pull/316 and the fact that it introduced several regressions (see related 0017712 and 0017779), not to mention that it is likely to cause a non-trivial effort to resolve merge conflicts for the new UI (https://github.com/mantisbt/mantisbt/pull/272) |
|
As discussed with vboctor, please work out the issues outlined in the related issues, and submit another PR for this change. |
|
The menu css feature was reverted. We will re-evaluate its usefulness once modern ui ( 0017919 ) is integrated. Also marking issue as unassigned. |
|
MantisBT: master 29c2f821 2014-09-28 10:29 Paul Richards Details Diff |
Move menu generation functionality into Menu Class and update CSS This builds and completes work originally by daryn Functionality has been tested with plugins implementing the following hooks: EVENT_MENU_MAIN_FRONT EVENT_MENU_MAIN EVENT_MENU_MANAGE EVENT_MENU_MANAGE_CONFIG EVENT_MENU_ACCOUNT EVENT_MENU_SUMMARY EVENT_SUBMENU_SUMMARY CSS changes have been tested on: IE8 IE9 IE10 IE11 Firefox 31.0 Firefox 32.0 Chrome 37.0 Safari 7.0.6 |
Affected Issues 0017711 |
|
mod - account_page.php | Diff File | ||
mod - account_prefs_inc.php | Diff File | ||
mod - account_prof_edit_page.php | Diff File | ||
mod - account_prof_menu_page.php | Diff File | ||
mod - account_sponsor_page.php | Diff File | ||
mod - adm_config_report.php | Diff File | ||
mod - adm_permissions_report.php | Diff File | ||
add - config_menu_defaults_inc.php | Diff File | ||
mod - core.php | Diff File | ||
add - core/classes/MantisMenu.class.php | Diff File | ||
mod - core/html_api.php | Diff File | ||
mod - css/default.css | Diff File | ||
mod - manage_columns_inc.php | Diff File | ||
mod - manage_config_columns_page.php | Diff File | ||
mod - manage_config_email_page.php | Diff File | ||
mod - manage_config_work_threshold_page.php | Diff File | ||
mod - manage_config_workflow_graph_page.php | Diff File | ||
mod - manage_config_workflow_page.php | Diff File | ||
mod - manage_custom_field_edit_page.php | Diff File | ||
mod - manage_custom_field_page.php | Diff File | ||
mod - manage_overview_page.php | Diff File | ||
mod - manage_plugin_page.php | Diff File | ||
mod - manage_proj_cat_edit_page.php | Diff File | ||
mod - manage_proj_create_page.php | Diff File | ||
mod - manage_proj_edit_page.php | Diff File | ||
mod - manage_proj_page.php | Diff File | ||
mod - manage_proj_ver_edit_page.php | Diff File | ||
mod - manage_tags_page.php | Diff File | ||
mod - manage_user_create_page.php | Diff File | ||
mod - manage_user_edit_page.php | Diff File | ||
mod - manage_user_page.php | Diff File | ||
mod - plugins/MantisCoreFormatting/pages/config.php | Diff File | ||
mod - plugins/MantisGraph/pages/config.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_jpgraph_page.php | Diff File | ||
mod - plugins/XmlImportExport/pages/import.php | Diff File | ||
mod - plugins/XmlImportExport/pages/import_action.php | Diff File | ||
mod - proj_doc_add_page.php | Diff File | ||
mod - proj_doc_edit_page.php | Diff File | ||
mod - proj_doc_page.php | Diff File | ||
mod - summary_page.php | Diff File | ||
MantisBT: master 0b13955c 2014-10-18 13:22 Details Diff |
Revert "Move menu generation functionality into Menu Class and update CSS" This commit was merged without approval or review from the team, and introduced several regressions and issues, documented in - Issue 0017712: errors in menu and submenu display - Issue 0017779: New Menu Class is breaking plugins See also issue 0017711 and comments in pull request #316. This reverts commit 29c2f8211de8869b3b1b072467b54252d0db5024. |
Affected Issues 0017711, 0017712, 0017779 |
|
mod - account_page.php | Diff File | ||
mod - account_prefs_inc.php | Diff File | ||
mod - account_prof_edit_page.php | Diff File | ||
mod - account_prof_menu_page.php | Diff File | ||
mod - account_sponsor_page.php | Diff File | ||
mod - adm_config_report.php | Diff File | ||
mod - adm_permissions_report.php | Diff File | ||
rm - config_menu_defaults_inc.php | Diff | ||
mod - core.php | Diff File | ||
rm - core/classes/MantisMenu.class.php | Diff | ||
mod - core/html_api.php | Diff File | ||
mod - css/default.css | Diff File | ||
mod - manage_columns_inc.php | Diff File | ||
mod - manage_config_columns_page.php | Diff File | ||
mod - manage_config_email_page.php | Diff File | ||
mod - manage_config_work_threshold_page.php | Diff File | ||
mod - manage_config_workflow_graph_page.php | Diff File | ||
mod - manage_config_workflow_page.php | Diff File | ||
mod - manage_custom_field_edit_page.php | Diff File | ||
mod - manage_custom_field_page.php | Diff File | ||
mod - manage_overview_page.php | Diff File | ||
mod - manage_plugin_page.php | Diff File | ||
mod - manage_proj_cat_edit_page.php | Diff File | ||
mod - manage_proj_create_page.php | Diff File | ||
mod - manage_proj_edit_page.php | Diff File | ||
mod - manage_proj_page.php | Diff File | ||
mod - manage_proj_ver_edit_page.php | Diff File | ||
mod - manage_tags_page.php | Diff File | ||
mod - manage_user_create_page.php | Diff File | ||
mod - manage_user_edit_page.php | Diff File | ||
mod - manage_user_page.php | Diff File | ||
mod - plugins/MantisCoreFormatting/pages/config.php | Diff File | ||
mod - plugins/MantisGraph/pages/config.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_category.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_priority.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_resolution.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_severity.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_graph_imp_status.php | Diff File | ||
mod - plugins/MantisGraph/pages/summary_jpgraph_page.php | Diff File | ||
mod - plugins/XmlImportExport/pages/import.php | Diff File | ||
mod - plugins/XmlImportExport/pages/import_action.php | Diff File | ||
mod - proj_doc_add_page.php | Diff File | ||
mod - proj_doc_edit_page.php | Diff File | ||
mod - proj_doc_page.php | Diff File | ||
mod - summary_page.php | Diff File |