0017405: proj_doc_update.php on document update crashes if new file is not uploaded - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0017405	mantisbt	bugtracker	public	2014-06-03 04:17	2014-12-05 18:33

Reporter	karlito	Assigned To	dregad
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.17
Target Version	1.2.18	Fixed in Version	1.2.18

Summary	0017405: proj_doc_update.php on document update crashes if new file is not uploaded
Description	proj_doc_update.php on document update crashes if file is not uploaded (after post from proj_doc_edit_page.php). Cause of the problem is line 56 "file_ensure_uploaded( $f_file );", which crashes if only document information is upadated and no file is reuploaded. Should check whether this is initial save or update and request mandatory file only for initial save.
Steps To Reproduce	Open existing project document (proj_doc_edit_page.php), change only title and/or description and save without attaching new file.
Tags	No tags attached.

MantisBT: master-1.2.x 7ffceea8 2014-06-03 03:59 dregad Details Diff	Allow update of existing project document Prior to this, it was impossible to update a document's title or description without uploading a new file, as MantisBT would trigger an error. Fixes 0017405	Affected Issues 0017405
	mod - proj_doc_update.php	Diff File
MantisBT: master 319d45b5 2014-06-03 03:59 dregad Details Diff	Allow update of existing project document Prior to this, it was impossible to update a document's title or description without uploading a new file, as MantisBT would trigger an error. Fixes 0017405 Porting a0539b7e32c7dc8301518d857efb887aa43072bc to master	Affected Issues 0017405
	mod - proj_doc_update.php	Diff File

dregad 2014-06-03 08:11 developer ~0040733	Pull request for review https://github.com/mantisbt/mantisbt/pull/204