View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016975 | mantisbt | localization | public | 2014-02-15 12:39 | 2014-12-08 00:34 |
Reporter | badfiles | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.17 | ||||
Target Version | 1.3.0-beta.1 | Fixed in Version | 1.3.0-beta.1 | ||
Summary | 0016975: Invalid enumeration string value displayed if localized value does not exist | ||||
Description | There is an unnamed custom field type @10@. | ||||
Tags | No tags attached. | ||||
badfiles, I was not able to reproduce your problem. Please provide detailed, step-by-step instructions to reproduce the issue. |
|
this is a translation issue, my language file lacks in custom_field_type_enum_string '10:textarea'. |
|
looks like fallback to English does not work for enums |
|
Will be fixed after we switch translatewiki to master and translators updated translation. |
|
|
|
Atrol, I've generated PR with a fix for this: https://github.com/mantisbt/mantisbt/pull/198 |
|
Reminder sent to: rombert Added test case for rombert to review |
|
Reminder sent to: vboctor Victor: Where do you stand on fixing this issue? From a code point of view, you didn't follow the fix, so i'm just making sure you've also read this bug report. In addition, if we aren't happy with the implementation approach i've taken so far, we need to decide on an alternative approach to implementing the code change for this bug. |
|
Reminder sent to: atrol Atrol, do you have any thoughts on this PR atm? |
|
|
|
For some of our lesser used languages (And especially if users add their own custom statuses) the fallback could be useful. For the core project and popular languages, it's likely to get translated, but if a user customises one of the enumerations for their own internal needs, they might not be able to translate it into all languages, hence we do need to fix this. |
|
@grangeway, your PR is probably an enhancement and looks good at first sight. (didn't test anything) |
|
MantisBT: master 4fbd340f 2014-05-31 05:57 Paul Richards Committer: dregad Details Diff |
Fix invalid enumeration string value display Prior to this, an invalid enumeration string value (e.g. @32@) was displayed if the corresponding localized value did not exist. This allows fallback to English language for individual enum elements. Fixes 0016975, https://github.com/mantisbt/mantisbt/pull/198 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0016975 |
|
mod - core/classes/MantisEnum.class.php | Diff File | ||
mod - tests/Mantis/EnumTest.php | Diff File |