View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016931 | mantisbt | code cleanup | public | 2014-02-07 03:55 | 2016-06-12 00:42 |
Reporter | dregad | Assigned To | dregad | ||
Priority | low | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
Summary | 0016931: PHPUnit tests for admin config functions | ||||
Description | As suggested by rombert [1], these functions ought to be moved to a core API file. This will enable implementation of PHPUnit tests for them. [1] https://github.com/mantisbt/mantisbt/pull/131#issuecomment-34314841 | ||||
Additional Information | From rombert's comment on the pull request: Some basic tests are quite easy to add, e.g.
Of course, there's much more to test | ||||
Tags | No tags attached. | ||||
MantisBT: master 3ed60df1 2016-04-30 03:53 Details Diff |
Parse complex configs using PHP tokenizer Implements 2 classes to parse 'complex' config options in admin Configuration Report page using PHP tokenizer instead of relying on regular expressions. - Tokenizer calls token_get_all() to build a list of tokens from the given code - Parser uses a Tokenizer object to convert the code (string) to an actual PHP array variable Includes PHPUnit test cases for the new parser code. Fixes 0020787, 0020812, 0020813, 0020850, 0020851, 0016931, 0016932 PR https://github.com/mantisbt/mantisbt/pull/761 |
Affected Issues 0016931, 0016932, 0020787, 0020812, 0020813, 0020850, 0020851 |
|
mod - adm_config_set.php | Diff File | ||
add - core/classes/ConfigParser.class.php | Diff File | ||
add - core/classes/Tokenizer.class.php | Diff File | ||
mod - core/constant_inc.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
mod - tests/Mantis/AllTests.php | Diff File | ||
add - tests/Mantis/ConfigParserTest.php | Diff File |