View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016507 | mantisbt | bugtracker | public | 2013-10-17 17:47 | 2014-12-08 02:07 |
Reporter | rombert | Assigned To | dregad | ||
Priority | high | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0dev | ||||
Target Version | 1.3.0-beta.1 | ||||
Summary | 0016507: Adding a bugnote causes a script timeout | ||||
Description | Adding a bugnote causes the script to timeout after 30 seconds: [Fri Oct 18 00:37:24 2013] [error] [client 127.0.0.1] PHP Fatal error: Maximum execution time of 30 seconds exceeded in /mnt/md/robert/git/mantisbt/library/adodb/adodb.inc.php on line 3565, referer: http://localhost/~robert/mantisbt/view.php?id=2615 Tested at revision 0deb3b6119403279cc22960d375b340450c9e9df. | ||||
Tags | No tags attached. | ||||
Also causes failures in the Travis CI build, see https://travis-ci.org/mantisbt/mantisbt/jobs/12691317 |
|
I am not able to reproduce this on my dev box unfortunately. Furthermore, I don't understand how the erroring statement which, based on the error log you posted, is just returning a class property [1] could possibly cause a PHP timeout. Maybe the root cause is in the email_api ? [1] https://github.com/mantisbt/ADOdb/blob/mantis-1.3/adodb.inc.php#L3565 |
|
Looking at the Travis CI build history, the first occurence of the timeout error out is with build 155 - commit fbd6540 It turns out that this commit modified email_api.php so maybe there's something wrong with that change. I'll have a look. |
|
I got the same problem. |
|
I think the current default is fine, the problem is with whatever broke notifications. |
|
The current default would be fine if we had implemented part b) of 0016423 You are right that it should work also with setting ON as it works also in master-1.2.x with this setting. |
|
Thanks Roland for pointing that one out, I've got a "standard" custom config_inc.php which I used for my local tests where this is set to OFF, that explains it probably. Now that I know the root cause I think I know where to look. |
|
Infinite loop @ https://github.com/mantisbt/mantisbt/blob/master/core/email_api.php#L287 |
|
I found 2 occurences of a while loop using db_result to retrieve data instead of db_fetch_array. |
|
sdfgdf |
|
xdfjghjgh |
|
MantisBT: master dc3266a4 2013-10-18 02:04 Details Diff |
Fix infinite loop when adding email recipients Commit fbd654083f061fcfcc8dc7229953cc44737889fa introduced a regression preventing the addition of bugnotes as a PHP Fatal error: Maximum execution time of 30 seconds exceeded was triggered. Fixes 0016507 |
Affected Issues 0016507 |
|
mod - core/email_api.php | Diff File |