View Issue Details

IDProjectCategoryView StatusLast Update
0014766mantisbtcode cleanuppublic2014-09-23 18:05
Reporterdregad Assigned Todregad  
PrioritylowSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.2.12Fixed in Version1.2.12 
Summary0014766: Optimize custom_field_update() function
Description

Current implementation has lots of nearly identical code block (one for each custom field property) - this would be better handled using a loop on the cf's definition array.

TagsNo tags attached.

Relationships

related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 

Activities

grangeway

grangeway

2013-04-05 17:56

reporter   ~0036202

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets

MantisBT: master-1.2.x 6e53cd26

2012-10-02 04:28

dregad


Details Diff
Custom fields api - optimize and use db_query_bound

Replaces all uses of db_query() by db_query_bound() in the API.

Some SQL queries were rewritten in a cleaner and more efficient way.

custom_field_update() was greatly simplified by use of a foreach loop
instead of nearly identical code blocks for processing of each field to
update.

Fixes 0014765, 0014766
Affected Issues
0014765, 0014766
mod - core/custom_field_api.php Diff File

MantisBT: master da782868

2012-10-02 04:28

dregad


Details Diff
Custom fields api - optimize and use db_query_bound

Replaces all uses of db_query() by db_query_bound() in the API.

Some SQL queries were rewritten in a cleaner and more efficient way.

custom_field_update() was greatly simplified by use of a foreach loop
instead of nearly identical code blocks for processing of each field to
update.

Fixes 0014765, 0014766
Affected Issues
0014765, 0014766
mod - core/custom_field_api.php Diff File