View Issue Details

IDProjectCategoryView StatusLast Update
0014700mantisbtadministrationpublic2014-09-23 18:05
ReporterLapinkiller Assigned Todregad  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product Version1.2.11 
Target Version1.2.12Fixed in Version1.2.12 
Summary0014700: Admin > Edit Project Page : Upload Path when stored in DB
Description

If DB storage is used for attachments, we don't need config option : "upload_file_path" on edit project page. having it is confusing whereas we don't need it.

(I'll submit git pull request)

TagsNo tags attached.

Relationships

related to 0014701 closeddregad Missing project override in project edit page 
related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 
related to 0014724 closeddregad $g_project_override = ALL_PROJECTS does not work 

Activities

Lapinkiller

Lapinkiller

2012-09-10 04:29

reporter   ~0032816

Pull request : https://github.com/mantisbt/mantisbt/pull/59

dregad

dregad

2012-09-10 09:32

developer   ~0032817

I committed your patch with minor, cosmetic changes, thanks for your contribution !

Also note the commit in related 0014701, you may want to apply this fix as well if you are using project-specific config options (file_upload_method in this case)

dregad

dregad

2012-09-21 07:19

developer   ~0032899

Last edited: 2012-09-21 07:19

Added a few patches to

  • apply the same logic of hiding the path in project creation page
  • fix inconsistent behavior of field hiding due to config_get retrieving file upload method for the current project, instead of the one for the project being edited. (see related 0014701 and 0014724)
grangeway

grangeway

2013-04-05 17:56

reporter   ~0036192

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets

MantisBT: master-1.2.x 7aa07d86

2012-09-09 21:27

JGuilbaud

Committer: Damien Regad


Details Diff
Hide file upload path on project edit page if storage is DB

The upload_file_path config option is not needed when attachments are
stored in DB, and displaying it is confusing to user.

Fixes 0014700

Original patch updated to comply with coding guidelines

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Affected Issues
0014700
mod - manage_proj_edit_page.php Diff File

MantisBT: master b6e90223

2012-09-09 21:27

JGuilbaud

Committer: Damien Regad


Details Diff
Hide file upload path on project edit page if storage is DB

The upload_file_path config option is not needed when attachments are
stored in DB, and displaying it is confusing to user.

Fixes 0014700

Original patch updated to comply with coding guidelines

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
Affected Issues
0014700
mod - manage_proj_edit_page.php Diff File

MantisBT: master-1.2.x 45e7b999

2012-09-20 06:33

dregad


Details Diff
Hide file upload path on project create page if storage is DB

The logic implemented in 7aa07d86f2fa721e67ffd17839c373c4d81a3fea for
manage_proj_edit_page.php also applies to manage_proj_create_page.php.

Fixes 0014700
Affected Issues
0014700
mod - manage_proj_create_page.php Diff File

MantisBT: master 714c2a17

2012-09-20 06:33

dregad


Details Diff
Hide file upload path on project create page if storage is DB

The logic implemented in 7aa07d86f2fa721e67ffd17839c373c4d81a3fea for
manage_proj_edit_page.php also applies to manage_proj_create_page.php.

Fixes 0014700
Affected Issues
0014700
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File

MantisBT: master-1.2.x 8daa0868

2012-09-20 06:38

dregad


Details Diff
Fix inconsistent behavior of upload path field hiding

config_get() would return the file upload method for the current
project, instead of the one for the project being edited.

Use of $g_project_override for expected behavior.

Fixes 0014700
Affected Issues
0014700
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File

MantisBT: master 33dfba54

2012-09-20 06:38

dregad


Details Diff
Fix inconsistent behavior of upload path field hiding

config_get() would return the file upload method for the current
project, instead of the one for the project being edited.

Use of $g_project_override for expected behavior.

Fixes 0014700
Affected Issues
0014700
mod - manage_proj_create_page.php Diff File
mod - manage_proj_edit_page.php Diff File