MantisBT
Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories
  

View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014631mantisbtemailpublic2012-08-17 05:402013-04-06 09:23
Reporterdregad 
Assigned Todregad 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2.12 
Target Version1.2.12Fixed in Version1.2.12 
Summary0014631: Email validation needs to be consistent
DescriptionPHPMailer uses filter_var() to check for an e-mail validity; this function treats single-domain e-mail addresses (e.g. user@localhost) as invalid.

However, Mantis API function email_is_valid() relies on a custom regex to validate e-mails, which does accept such addresses.

As a consequence, we accept addresses to which we are unable to send messages (see 0014543), and moreover due to poor error handling (see 0014630), such failures are not reported to the user or logged by the system.

To avoid this problem, we should use a consistent way of validating e-mails; the best would be to call PHPMailer::ValidateAddress() method, which would ensure that any email we store can be sent PHPMailer.

Note that we may still experience similar issues when using LDAP emails.
Tags2.0.x check
Attached Files

- Relationships
related to 0014543resolveddregad Emails are not sent to addresses with single subdomain 
related to 0014630closeddregad Improve email logging 
related to 0015721new Functionality to consider porting to master-2.0.x 
related to 0014632closeddregad Email validation always successful when $g_use_ldap_email = ON 

-  Notes
User avatar (0036166)
grangeway (developer)
2013-04-05 17:56

 Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master-1.2.x 6987b4ad
Timestamp: 2012-08-17 02:41:16
Author: dregad
[ Details ] [ Diff ] 		Fix 0014631: Consistent email validation

PHPMailer uses filter_var() to check for an e-mail validity; this
function treats single-domain e-mail addresses (e.g. user@localhost) as
invalid. However, Mantis API function email_is_valid() relies on a
custom regex to validate e-mails, which does accept such addresses. As a
consequence, we accept addresses to which we are unable to send
messages.

To avoid this problem, we now rely on PHPMailer::ValidateAddress()
method to ensure that any email we store can be sent PHPMailer.
mod - core/email_api.php [ Diff ] [ File ]
MantisBT: master a38858a3
Timestamp: 2012-08-17 02:41:16
Author: dregad
[ Details ] [ Diff ] 		Fix 0014631: Consistent email validation

PHPMailer uses filter_var() to check for an e-mail validity; this
function treats single-domain e-mail addresses (e.g. user@localhost) as
invalid. However, Mantis API function email_is_valid() relies on a
custom regex to validate e-mails, which does accept such addresses. As a
consequence, we accept addresses to which we are unable to send
messages.

To avoid this problem, we now rely on PHPMailer::ValidateAddress()
method to ensure that any email we store can be sent PHPMailer.
mod - core/email_api.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2012-08-17 05:40 dregad New Issue
2012-08-17 05:40 dregad Issue generated from: 0014543
2012-08-17 05:40 dregad Relationship added related to 0014543
2012-08-17 05:40 dregad Assigned To => dregad
2012-08-17 05:40 dregad Status new => assigned
2012-08-17 05:40 dregad Target Version => 1.2.12
2012-08-17 05:41 dregad Relationship added related to 0014630
2012-08-17 05:49 dregad Relationship added related to 0014632
2012-08-17 06:27 dregad Changeset attached => MantisBT master-1.2.x 6987b4ad
2012-08-17 06:27 dregad Status assigned => resolved
2012-08-17 06:27 dregad Resolution open => fixed
2012-08-17 06:27 dregad Fixed in Version => 1.2.12
2012-08-17 06:27 dregad Changeset attached => MantisBT master a38858a3
2012-11-10 18:54 dregad Status resolved => closed
2013-04-05 17:56 grangeway Status closed => acknowledged
2013-04-05 17:56 grangeway Note Added: 0036166
2013-04-05 19:22 grangeway Relationship added related to 0015721
2013-04-06 03:40 dregad Status acknowledged => closed
2013-04-06 07:23 grangeway Status closed => acknowledged
2013-04-06 09:22 dregad Tag Attached: 2.0.x check
2013-04-06 09:23 dregad Status acknowledged => closed

MantisBT 1.2.16dev master-1.2.x-05091f5 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.0847 seconds.
memory usage: 2,841 KB
Powered by Mantis Bugtracker