| Anonymous | Login | Signup for a new account | 2013-05-25 20:56 EDT | ![]() |
| Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories |
| View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0014559 | mantisbt | administration | public | 2012-08-07 04:44 | 2013-04-06 09:23 | ||||
| Reporter | Lapinkiller | ||||||||
| Assigned To | dregad | ||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | 1.2.8 | ||||||||
| Target Version | 1.2.13 | Fixed in Version | 1.2.13 | ||||||
| Summary | 0014559: Adding filter for "Configuration report" | ||||||||
| Description | With lot of users and projects, the adminpage "Configuration report" is very very very long. So i have just added filters on "user" and/or "project" and/or "config id" | ||||||||
| Additional Information | new lang var : //en $s_none_filter = 'No filter'; //fr $s_none_filter = 'Aucun filtre'; | ||||||||
| Tags | 2.0.x check | ||||||||
| Attached Files | |||||||||
Relationships |
|||||||||||||||||||||
|
|||||||||||||||||||||
Notes |
|
|
Lapinkiller (reporter) 2012-08-07 05:06 |
please delete adm_config_report.php-adding_filters.diff |
|
dregad (developer) 2012-08-07 05:21 |
Many thanks for this patch !I have been meaning to implement something similar for quite some time myself. I will review your code as time allows. |
|
dregad (developer) 2012-08-15 06:21 |
Pull request https://github.com/mantisbt/mantisbt/pull/58 [^] |
|
Lapinkiller (reporter) 2012-11-12 02:40 |
what about this pull request ? |
|
dregad (developer) 2012-12-28 19:04 |
I have reworked your patch and improved it somewhat. Please seee https://github.com/dregad/mantisbt/tree/manage-config [^] - feedback would be appreciated. |
|
atrol (developer) 2012-12-30 10:25 |
I had a short look at it. Nice work. 1. Editing or deleting an option should not reset the filter 2. Usernames should not be displayed in round brackets 3. Heading "filters" should be "Filters" |
|
dregad (developer) 2012-12-31 19:21 |
Hi atrol, Many thanks for your comments. I have pushed some changes to the branch, to cover for the 3 issues you raised: 1. Filter persistency is now managed via a cookie instead of POST variables (similar to how it's done in other parts of MantisBT) - in fact a much more elegant solution not to mention better from an end-user perspective as it avoids that the browser requests for re-sending form data. 2. The filter now respects the $g_show_realname setting, similar to the rest of the page (i.e. display either Realname or Username but not both) 3. Fixed the corresponding language string |
|
atrol (developer) 2013-01-01 06:53 edited on: 2013-01-01 06:53 |
Missing list of options after deleting an option 1. Set filter to Username: [any], Project Name: [any], Configuration Option: one where only one entry exists 2. Click "Apply filter" 3. Delete the one entry 4. Filter displayed: Username: [any], Project Name: [any], Configuration Option: [any] 5. Confusing: No configuration entries are listed 6. Click "Apply Filter" 7. All entries are listed |
|
dregad (developer) 2013-01-02 09:19 |
Thanks atrol. Latest commits to the branch [1] include - fix for the issue you reported in 0014559:0034648 - new buttons to clear filter (i.e. view all configs) and reset it to default - preset the edit form fields to the current filter criteria [1] https://github.com/dregad/mantisbt/tree/manage-config [^] |
|
atrol (developer) 2013-01-02 12:46 |
Editing of complex values (for example view_issues_page_columns) is not longer possible. All values are lost, you get only array () |
|
dregad (developer) 2013-01-02 17:46 |
The changes in adm_config_set.php are still a work in progress and require additional testing; I only performed basic tests, and there are a lot of corner cases related to parsing the user's input especially with associative and multi-dimentional arrays. I intentionally included these commits in the branch linked here, to benefit from additional testing - thanks for being a guinea pig ;) If you find additional issues related to adm_config_set.php (i.e. what happens after you click the "Set Configuration Option" button, it would be best to report them in 0013298 If you want to restrict your testing to current 1.2.x behavior for adm_config_set, you can use the following branch [1] instead. [1] https://github.com/dregad/mantisbt/tree/fix-14559 [^] |
|
grangeway (developer) 2013-04-05 17:56 |
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
Related Changesets |
|||
|
MantisBT: master-1.2.x f8a81a33
Timestamp: 2012-08-13 15:16:48 Author: Lapinkiller Committer: Damien Regad [ Details ] [ Diff ] |
fix 0014559 - Filter for adm_report_config.php Signed-off-by: Damien Regad <damien.regad@merckgroup.com> |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
| mod - lang/strings_english.txt | [ Diff ] [ File ] | ||
| mod - lang/strings_french.txt | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 259f95cd
Timestamp: 2012-12-14 15:10:52 Author: dregad [ Details ] [ Diff ] |
Issue 0014559: improve adm_report_config.php filter The following changes were made - revised UI to make it more similar to the issues filter - make use of existing constants and language strings - filter defaults to All Users / All Projects / All options which avoids performance issues in installations having a large number of entries in the config table (workaround for issue 0013680) - filter form uses post instead of get method - comply to coding guidelines |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
| mod - lang/strings_english.txt | [ Diff ] [ File ] | ||
| mod - lang/strings_french.txt | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 9f724904
Timestamp: 2012-12-30 21:41:13 Author: dregad [ Details ] [ Diff ] |
Fix 1st uppercase letter for 'Filters' language string Affects issue 0014559 |
||
| mod - lang/strings_english.txt | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x efdd6a75
Timestamp: 2012-12-30 22:26:55 Author: dregad [ Details ] [ Diff ] |
Respect $g_show_realname setting in config report's filter userlist The filter's original implementation displayed "Realname (username)" in the user selection list. We now only retrieve the user id from the db, and call user_get_name() to get either the realname or the username as appropriate instead. Issue 0014559 |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 9dbfcd7d
Timestamp: 2012-12-30 23:01:34 Author: dregad [ Details ] [ Diff ] |
Manage persistency of config report filter using a cookie A new cookie 'manage_config_cookie' was added to store the user's filter criteria. Includes documentation update to admin guide. Issue 0014559 |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
| mod - config_defaults_inc.php | [ Diff ] [ File ] | ||
| mod - core/helper_api.php | [ Diff ] [ File ] | ||
| mod - docbook/administration_guide/en/configuration.sgml | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x b6f03b73
Timestamp: 2013-01-01 23:22:17 Author: dregad [ Details ] [ Diff ] |
Config report filter: added handling for invalid values in cookie In some cases, the cookie could contain values which are no longer applicable as filter criteria, e.g. - a project id which has been deleted - a user id for whom there are no config options - a config id for which there are no config options The code now correctly handles these, by making sure that either the filter criteria is dynamically updated to a valid value (ALL_PROJECTS for projects), or the filter's selection list effectively includes the invalid value (user id, config id), so that the displayed filter reflects the actual data listed in the Database Configuration table. Fixes the bug reported by atrol in issue 0014559's bugnote 34648 |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x d76a2106
Timestamp: 2013-01-02 11:46:11 Author: dregad [ Details ] [ Diff ] |
Config report filter: added buttons to clear and reset default filter This provides the user with a single-click way to - reset the filter to default settings (i.e. ALL_USERS, ALL_PROJECTS, [any] config). - clear the filter to display all configs (i.e. [any] user, [any] project, [any] config) Issue 0014559 |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
| mod - lang/strings_english.txt | [ Diff ] [ File ] | ||
|
MantisBT: master 0c81929d
Timestamp: 2013-01-18 15:53:13 Author: dregad [ Details ] [ Diff ] |
Manage config page: added filtering Porting the following 1.2.x commits - f8a81a33880752364ea47bdd9a987bff986c81de - 259f95cdb5a1561f9401b8c05f1aeddf8f016c81 - 3f75f68b08b0c52d5b3b488034f99214977a5dab - 9f724904ec087cc1d07704cc387455f4c3c45068 - efdd6a7538ae2366b1dadb52e85fc5d95ae80c1c - 9dbfcd7dd612137c8f75ba644d921c43f1d0a9f9 - beea901ca69692b989ec19461c6609571b5da5a2 - 65696fbffa0c1a197ce7441483abe78bd0b813e1 - b6f03b73e9134d1001e77445e109de733562cb8a - 8b426cfc6c6ea7149beeafb352fa390dbf8c4624 - d76a21067e56aba847b650d17ad4e679392c7475 - c61dc631b4c37547a25e1306ed90aa09e9e1b837 Issue 0014559, 0015415 |
||
| mod - adm_config_report.php | [ Diff ] [ File ] | ||
| mod - config_defaults_inc.php | [ Diff ] [ File ] | ||
| mod - core/helper_api.php | [ Diff ] [ File ] | ||
| mod - core/obsolete.php | [ Diff ] [ File ] | ||
| mod - css/default.css | [ Diff ] [ File ] | ||
| mod - docbook/Admin_Guide/en-US/Configuration.xml | [ Diff ] [ File ] | ||
| mod - lang/strings_english.txt | [ Diff ] [ File ] | ||
| mod - manage_user_page.php | [ Diff ] [ File ] | ||
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-08-07 04:44 | Lapinkiller | New Issue | |
| 2012-08-07 04:44 | Lapinkiller | File Added: adm_config_report.php-adding_filters.png | |
| 2012-08-07 04:44 | Lapinkiller | File Added: adm_config_report.php-adding_filters.diff | |
| 2012-08-07 05:06 | Lapinkiller | Note Added: 0032483 | |
| 2012-08-07 05:08 | Lapinkiller | File Added: adm_config_report.php-adding_filters-patch.diff | |
| 2012-08-07 05:20 | dregad | File Deleted: adm_config_report.php-adding_filters.diff | |
| 2012-08-07 05:21 | dregad | Note Added: 0032486 | |
| 2012-08-07 05:21 | dregad | Status | new => acknowledged |
| 2012-08-08 15:10 | atrol | Relationship added | related to 0013680 |
| 2012-08-15 06:21 | dregad | Note Added: 0032568 | |
| 2012-11-12 02:40 | Lapinkiller | Note Added: 0034294 | |
| 2012-12-26 08:47 | dregad | Assigned To | => dregad |
| 2012-12-26 08:47 | dregad | Status | acknowledged => assigned |
| 2012-12-28 19:04 | dregad | Note Added: 0034637 | |
| 2012-12-28 19:04 | dregad | Status | assigned => feedback |
| 2012-12-30 10:25 | atrol | Note Added: 0034645 | |
| 2012-12-31 19:21 | dregad | Note Added: 0034647 | |
| 2013-01-01 06:53 | atrol | Note Added: 0034648 | |
| 2013-01-01 06:53 | atrol | Note Edited: 0034648 | View Revisions |
| 2013-01-02 09:19 | dregad | Note Added: 0034662 | |
| 2013-01-02 12:46 | atrol | Note Added: 0034671 | |
| 2013-01-02 17:46 | dregad | Note Added: 0034680 | |
| 2013-01-02 17:46 | dregad | Relationship added | related to 0013298 |
| 2013-01-06 19:55 | dregad | Relationship added | related to 0015347 |
| 2013-01-22 08:55 | Lapinkiller | Changeset attached | => MantisBT master-1.2.x f8a81a33 |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x 259f95cd |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x 9f724904 |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x efdd6a75 |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x 9dbfcd7d |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x b6f03b73 |
| 2013-01-22 08:55 | dregad | Changeset attached | => MantisBT master-1.2.x d76a2106 |
| 2013-01-22 08:55 | Lapinkiller | Assigned To | dregad => Lapinkiller |
| 2013-01-22 08:55 | Lapinkiller | Status | feedback => resolved |
| 2013-01-22 08:55 | Lapinkiller | Resolution | open => fixed |
| 2013-01-22 08:55 | Lapinkiller | Fixed in Version | => 1.2.13 |
| 2013-01-22 09:47 | dregad | Target Version | => 1.2.13 |
| 2013-01-22 09:47 | dregad | Status | resolved => closed |
| 2013-01-22 21:01 | dregad | Assigned To | Lapinkiller => dregad |
| 2013-03-08 11:05 | dregad | Changeset attached | => MantisBT master 0c81929d |
| 2013-03-13 06:17 | jayavel | Issue cloned: 0015624 | |
| 2013-04-05 17:56 | grangeway | Status | closed => acknowledged |
| 2013-04-05 17:56 | grangeway | Note Added: 0036074 | |
| 2013-04-05 19:43 | grangeway | Relationship added | related to 0015721 |
| 2013-04-06 03:39 | dregad | Status | acknowledged => resolved |
| 2013-04-06 07:21 | grangeway | Status | resolved => acknowledged |
| 2013-04-06 09:22 | dregad | Tag Attached: 2.0.x check | |
| 2013-04-06 09:23 | dregad | Status | acknowledged => closed |
| MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.1352 seconds. memory usage: 3,009 KB |