MantisBT
Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories
  

View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014086mantisbtinstallationpublic2012-03-26 01:102013-04-06 09:26
Reportervboctor 
Assigned Todregad 
PriorityhighSeverityblockReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.3.x 
Target Version1.3.xFixed in Version1.3.x 
Summary0014086: Default administrator timezone to server timezone
DescriptionThe master branch now gives a system notice on logic because the administrator timezone is set to an empty string. The fix should include the following:

1. If timezone is blank, don't set it.
2. Introduce the concept of default timezone, ideally part of the installation.
3. Default administrator's to default/server timezone.
4. When user edits their preference, should have a proper default and not select the first entry.
5. As new users are created, they should use the default time zone.
Tags2.0.x check
Attached Files

- Relationships
related to 0015721new Functionality to consider porting to master-2.0.x 
related to 0015205acknowledged Installer should ask admin for the default timezone to use 
child of 0014088confirmed Mantis 1.3.0 blocking issues 

-  Notes
User avatar (0031527)
vboctor (administrator)
2012-03-26 01:41

 A partial fix was checked in that doesn't set the timezone in case it is empty. This removes the system notice.
User avatar (0034312)
dregad (developer)
2012-11-14 10:05

 Setting default_timezone to date_default_timezone_get() will block Mantis with PHP 5.4 if date.timezone is not properly defined in php.ini, due to the system warning triggered by PHP in this case (as the function no longer falls back to querying the OS for the default tz):

Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected the timezone 'UTC' for now, but please set date.timezone to select your timezone. in /path/to/mantisbt/config_defaults_inc.php on line 1141

I think commit 15c23b1a should be reverted, as well as the changes to core.php made by dhx in ba97560b. IMO, the default timezone should be set in core.php as it was in 1.2.x.
User avatar (0034315)
dregad (developer)
2012-11-14 11:00

 Victor,

I have applied what I believe is a better fix for this issue; as I'm not sure exactly what test case you ran initially, I would appreciate your letting me know if the original issue you reported still exists.

I also opened 0015205 to track your suggestion to improve the installer.
User avatar (0036140)
grangeway (developer)
2013-04-05 17:56

 Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master d4508697
Timestamp: 2012-03-25 22:31:01
Author: vboctor
[ Details ] [ Diff ] 		Issue 0014086: Default administrator timezone to server timezone. (partial fix).
mod - core.php [ Diff ] [ File ]
MantisBT: master 15c23b1a
Timestamp: 2012-05-06 12:15:47
Author: vboctor
[ Details ] [ Diff ] 		Fixes 0014086: Default administrator timezone to server timezone.

The timezone is now defaulted to date_default_timezone_get() rather than empty string which defaults to date_default_timezone_get() in some code paths. This fixes the issue where user preferences picked up the first in the list rather than the default timezone.
mod - config_defaults_inc.php [ Diff ] [ File ]
MantisBT: master fc67be88
Timestamp: 2012-11-14 15:14:33
Author: dregad
[ Details ] [ Diff ] 		Revert "Fixes 0014086: Default administrator timezone to server timezone."

This reverts commit 15c23b1a71fe92839c3f0f2c75c882cec16d051d.
mod - config_defaults_inc.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2012-03-26 01:10 vboctor New Issue
2012-03-26 01:15 vboctor Assigned To => vboctor
2012-03-26 01:15 vboctor Status new => confirmed
2012-03-26 01:15 vboctor Assigned To vboctor =>
2012-03-26 01:26 vboctor Relationship added child of 0014088
2012-03-26 01:41 vboctor Note Added: 0031527
2012-03-26 01:43 vboctor Note View State: 0031527: private
2012-03-26 01:43 vboctor Note View State: 0031527: public
2012-03-26 02:00 vboctor Changeset attached => MantisBT master d4508697
2012-05-06 15:31 vboctor Changeset attached => MantisBT master 15c23b1a
2012-05-06 15:31 vboctor Assigned To => vboctor
2012-05-06 15:31 vboctor Status confirmed => resolved
2012-05-06 15:31 vboctor Resolution open => fixed
2012-05-06 15:31 vboctor Fixed in Version => 1.3.x
2012-11-14 10:05 dregad Note Added: 0034312
2012-11-14 10:05 dregad Status resolved => feedback
2012-11-14 10:05 dregad Resolution fixed => reopened
2012-11-14 10:12 dregad Issue cloned: 0015205
2012-11-14 10:12 dregad Relationship added related to 0015205
2012-11-14 10:53 dregad Changeset attached => MantisBT master fc67be88
2012-11-14 10:53 dregad Assigned To vboctor => dregad
2012-11-14 10:53 dregad Status feedback => resolved
2012-11-14 11:00 dregad Note Added: 0034315
2012-11-14 11:00 dregad Resolution reopened => fixed
2012-11-14 11:00 dregad Product Version git trunk => 1.3.x
2013-04-05 17:56 grangeway Status resolved => acknowledged
2013-04-05 17:56 grangeway Note Added: 0036140
2013-04-05 19:31 grangeway Relationship added related to 0015721
2013-04-06 03:44 dregad Status acknowledged => resolved
2013-04-06 07:20 grangeway Status resolved => acknowledged
2013-04-06 09:26 dregad Tag Attached: 2.0.x check
2013-04-06 09:26 dregad Status acknowledged => resolved

MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.1011 seconds.
memory usage: 2,859 KB
Powered by Mantis Bugtracker