| Description | On PHP 5.1.x, which is still the supported series of PHP on Red Hat Enterprise Linux 5 and derived distributions, the admin/check.php script crashes with:
PHP Fatal error: Call to undefined function timezone_identifiers_list() in /path/to/admin/check.php on line 364
According to http://se2.php.net/timezone_identifiers_list , this function was added only in PHP 5.2.x. Therefore, it should be conditionally called according to the PHP version, since it would be better to skip the timezone check and let the rest of the checks run.
Simple patch attached. |
|---|
| Attached Files |
mantis-bug-14009.patch (1,627 bytes)
--- check.php.old 2012-03-04 02:32:43.000000000 +0000
+++ check.php 2012-03-06 20:10:52.000000000 +0000
@@ -357,11 +357,19 @@
if ( !is_blank ( config_get_global( 'default_timezone' ) ) ) {
if ( print_test_row( 'Checking if a timezone is set in config.inc.php....', !is_blank ( config_get_global( 'default_timezone' ) ), config_get_global( 'default_timezone' ) ) ) {
- print_test_row( 'Checking if timezone is valid from config.inc.php....', in_array( config_get_global( 'default_timezone' ), timezone_identifiers_list() ), config_get_global( 'default_timezone' ) );
+ if ( version_compare ( phpversion(), '5.2.0') >= 0 ) {
+ print_test_row( 'Checking if timezone is valid from config.inc.php....', in_array( config_get_global( 'default_timezone' ), timezone_identifiers_list() ), config_get_global( 'default_timezone' ) );
+ } else {
+ print_test_row( 'Checking if timezone is valid in config.inc.php....', false, 'Cannot check validity on PHP < 5.2.0');
+ }
}
} else {
if( print_test_row( 'Checking if timezone is set in php.ini....', ini_get( 'date.timezone' ) !== '' ) ) {
- print_test_row( 'Checking if timezone is valid in php.ini....', in_array( ini_get( 'date.timezone' ), timezone_identifiers_list() ), ini_get( 'date.timezone' ) );
+ if ( version_compare ( phpversion(), '5.2.0') >= 0 ) {
+ print_test_row( 'Checking if timezone is valid in php.ini....', in_array( ini_get( 'date.timezone' ), timezone_identifiers_list() ), ini_get( 'date.timezone' ) );
+ } else {
+ print_test_row( 'Checking if timezone is valid in php.ini....', false, 'Cannot check validity on PHP < 5.2.0');
+ }
}
}
mantis-bug-14009a.patch (1,637 bytes)
--- check.php.old 2012-03-04 02:32:43.000000000 +0000
+++ check.php 2012-03-06 21:33:10.000000000 +0000
@@ -357,11 +357,19 @@
if ( !is_blank ( config_get_global( 'default_timezone' ) ) ) {
if ( print_test_row( 'Checking if a timezone is set in config.inc.php....', !is_blank ( config_get_global( 'default_timezone' ) ), config_get_global( 'default_timezone' ) ) ) {
- print_test_row( 'Checking if timezone is valid from config.inc.php....', in_array( config_get_global( 'default_timezone' ), timezone_identifiers_list() ), config_get_global( 'default_timezone' ) );
+ if ( version_compare ( phpversion(), '5.2.0') >= 0 ) {
+ print_test_row( 'Checking if timezone is valid from config.inc.php....', in_array( config_get_global( 'default_timezone' ), timezone_identifiers_list() ), config_get_global( 'default_timezone' ) );
+ } else {
+ print_test_warn_row( 'Checking if timezone is valid in config.inc.php....', false, 'Cannot check validity on PHP < 5.2.0');
+ }
}
} else {
if( print_test_row( 'Checking if timezone is set in php.ini....', ini_get( 'date.timezone' ) !== '' ) ) {
- print_test_row( 'Checking if timezone is valid in php.ini....', in_array( ini_get( 'date.timezone' ), timezone_identifiers_list() ), ini_get( 'date.timezone' ) );
+ if ( version_compare ( phpversion(), '5.2.0') >= 0 ) {
+ print_test_row( 'Checking if timezone is valid in php.ini....', in_array( ini_get( 'date.timezone' ), timezone_identifiers_list() ), ini_get( 'date.timezone' ) );
+ } else {
+ print_test_warn_row( 'Checking if timezone is valid in php.ini....', false, 'Cannot check validity on PHP < 5.2.0');
+ }
}
}
|
|---|
