View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0013691 | mantisbt | administration | public | 2011-12-20 16:56 | 2014-12-08 02:07 |
Reporter | amaringer | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | AMD64 | OS | Debian | OS Version | 6.0 |
Product Version | 1.3.0dev | ||||
Target Version | 1.3.0-beta.1 | ||||
Summary | 0013691: misspelled XHTML in admin/system_utils.php | ||||
Description | There is some misconfigured XHTML in admin/system_utils.php Patch to correct is attached. The "-*" between the filename and the ".patch" is the chosen option of the diff command. | ||||
Tags | patch | ||||
Attached Files | system_utils.php.-B.patch (530 bytes)
47c47 < <tr><td bgcolor=\"#e8e8e8\" colspan=\"2\"><span class=\"title\">Upgrade Utilities</span></td></tr> --- > <tr><td bgcolor="#e8e8e8" colspan="2"><span class="title">Upgrade Utilities</span></td></tr> 71c71 < printf( "<OPTION VALUE=\"%d\">%s", $t_id, custom_field_get_field( $t_id, 'name' ) ); --- > printf( "<OPTION VALUE=\"%d\">%s</OPTION>", $t_id, custom_field_get_field( $t_id, 'name' ) ); 83c83 < printf( "<OPTION VALUE=\"%s\">%s", $t_id, $t_id ); --- > printf( "<OPTION VALUE=\"%s\">%s</OPTION>", $t_id, $t_id ); system_utils.php.-Naur.patch (1,076 bytes)
--- admin/system_utils.php.old 2011-06-12 23:50:49.000000000 +0200 +++ admin/system_utils.php 2011-12-20 22:45:06.000000000 +0100 @@ -44,7 +44,7 @@ <br /><br /> <table width="80%" bgcolor="#222222" cellpadding="10" cellspacing="1"> - <tr><td bgcolor=\"#e8e8e8\" colspan=\"2\"><span class=\"title\">Upgrade Utilities</span></td></tr> + <tr><td bgcolor="#e8e8e8" colspan="2"><span class="title">Upgrade Utilities</span></td></tr> <!-- # Headings --> <tr bgcolor="#ffffff"><th width="70%">Description</th><th width="30%">Execute</th></tr> @@ -68,7 +68,7 @@ <?php $t_custom_ids = custom_field_get_ids(); foreach( $t_custom_ids as $t_id ) { - printf( "<OPTION VALUE=\"%d\">%s", $t_id, custom_field_get_field( $t_id, 'name' ) ); + printf( "<OPTION VALUE=\"%d\">%s</OPTION>", $t_id, custom_field_get_field( $t_id, 'name' ) ); } ?> </SELECT> to @@ -80,7 +80,7 @@ 'fixed_in_version', ); foreach( $t_dest_ids as $t_id ) { - printf( "<OPTION VALUE=\"%s\">%s", $t_id, $t_id ); + printf( "<OPTION VALUE=\"%s\">%s</OPTION>", $t_id, $t_id ); } ?> </SELECT> | ||||
already fixed in next branch |
|
Reminder sent to: grangeway Does "fixed in next" mean, that there will be no 1.3.x based on master? |
|
Reopened because target version is set to 1.3.x and there is no commit in master. |
|
see master-2.0.x branch |
|
There is no master-2.0.x branch at https://github.com/mantisbt/mantisbt |
|
Reopened, the issue is not fixed in any branch of the official repository. |
|
amaringer, thanks for the patch. |
|
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
|