MantisBT
Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories
  

View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013272mantisbtinstallationpublic2011-08-26 09:342013-04-06 09:23
ReporterCarstenGrohmann 
Assigned Todregad 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2.6 
Target Version1.2.8Fixed in Version1.2.8 
Summary0013272: Hardcoded table name mantis_config_table in install.php
DescriptionHi,

I installed the Oracle branch yesterday. This branch contains a minor bug.
An insert statement uses a hard coded config table name:

echo 'INSERT INTO mantis_config_table ( value, ...

it could be (like the main trunk):
echo 'INSERT INTO ' . db_get_table( 'config' ) . ' ( value, ...

Please change this single line...

Regards,
Carsten
Tags2.0.x check
Attached Files

- Relationships
related to 0015721new Functionality to consider porting to master-2.0.x 
related to 0013227assigneddregad Oracle DB support multiple issues 

-  Notes
User avatar (0029563)
CarstenGrohmann (reporter)
2011-08-26 09:45

 Probably "db_get_table( 'mantis_config_table' )" is the better statement.
User avatar (0029568)
rombert (developer)
2011-08-28 09:32

 Thank you for the report and suggested fix. Would you consider submitting pull requests for this functionality? This would greatly increase the speed of including these changes in MantisBT.

Ideally you would submit pull requests for both the master and master-1.2.x branches at https://github.com/mantisbt/mantisbt [^] .
User avatar (0029570)
grangeway (developer)
2011-08-28 09:58

 This issue has already been fixed in the latest trunk
User avatar (0029592)
dregad (developer)
2011-08-29 09:23

 It was fixed on master only, not in 1.2.x.
User avatar (0036406)
grangeway (developer)
2013-04-05 17:57

 Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master-1.2.x b4af2384
Timestamp: 2011-08-29 04:58:12
Author: dregad
[ Details ] [ Diff ] 		Fix 0013272: Hardcoded table name mantis_config_table in install.php

This issue applies only to 1.2.x, as it had already been fixed in master as
part of commit c8f355d04fb5120545d890ea2a7b2e2b6afc9b6c
mod - admin/install.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2011-08-26 09:34 CarstenGrohmann New Issue
2011-08-26 09:45 CarstenGrohmann Note Added: 0029563
2011-08-28 09:32 rombert Note Added: 0029568
2011-08-28 09:58 grangeway Note Added: 0029570
2011-08-28 09:58 grangeway Status new => resolved
2011-08-28 09:58 grangeway Resolution open => no change required
2011-08-28 09:58 grangeway Assigned To => grangeway
2011-08-28 19:09 dregad Relationship added related to 0013227
2011-08-29 09:23 dregad Note Added: 0029592
2011-08-29 09:23 dregad Assigned To grangeway => dregad
2011-08-29 09:23 dregad Resolution no change required => fixed
2011-08-29 09:23 dregad Fixed in Version => 1.2.8
2011-08-29 09:23 dregad Target Version => 1.2.8
2011-08-29 09:23 dregad Changeset attached => MantisBT master-1.2.x b4af2384
2011-09-06 10:34 jreese Status resolved => closed
2013-04-05 17:57 grangeway Status closed => acknowledged
2013-04-05 17:57 grangeway Note Added: 0036406
2013-04-05 18:12 grangeway Relationship added related to 0015721
2013-04-06 03:43 dregad Status acknowledged => closed
2013-04-06 07:23 grangeway Status closed => acknowledged
2013-04-06 09:22 dregad Tag Attached: 2.0.x check
2013-04-06 09:23 dregad Status acknowledged => closed

MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.1057 seconds.
memory usage: 2,827 KB
Powered by Mantis Bugtracker