View Issue Details

IDProjectCategoryView StatusLast Update
0012622mantisbtotherpublic2011-04-05 14:23
Reporterjurgenhaas Assigned Todhx  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.2.4 
Target Version1.2.5Fixed in Version1.2.5 
Summary0012622: Changing reporter doesn't work in version 1.2.4 anymore
Description

When editing a ticket it was possible in versin 1.2.3 to click on [Edit] right next to the linked name of the reporter to actually change the reporter of the ticket. This is not working anymore. Any ideas why?

TagsNo tags attached.

Relationships

related to 0012354 closeddhx HTML validation error 
has duplicate 0012663 closedatrol 'loading_lang' is undefined 
has duplicate 0012836 closedatrol When updating issue information the reporter can't be edited 
has duplicate 0012888 closedatrol Cannot edit the "Reporter" field when editing issue 

Activities

jurgenhaas

jurgenhaas

2010-12-21 05:03

reporter   ~0027649

This is a Ajax function calling AjaxLoad() which can't be called because obviously the bug_update_page.php is throwing a JavaScript error when clicking that link. The error is "Uncaught ReferenceError: loading_lang is not defined" in javascript/min/ajax.js

jurgenhaas

jurgenhaas

2010-12-21 05:17

reporter   ~0027650

The reason for this error is /core/html_api.php line 400:

<code>
echo '<script language="text/javascript">var loading_lang = "' . lang_get( 'loading' ) . '";</script>';
</code>

is wrong as the correct attribute should be language="javascript" and not text/javascript.

atrol

atrol

2010-12-21 06:09

developer   ~0027651

Thanks for reporting
This was introduced by 0012354

jurgenhaas

jurgenhaas

2010-12-21 06:14

reporter   ~0027652

Well, the committed change in 0012354 changed it to language="text/javascript" which is definetely wrong.

There is
language="javascript"
or
type="text/javascript"

but I haven't tried yet if the latter works.

atrol

atrol

2010-12-21 06:23

developer   ~0027653

Last edited: 2010-12-21 06:28

Reminder sent to: dhx

David, I think this should be
<script language="JavaScript" type="text/javascript">

dhx

dhx

2010-12-21 06:32

reporter   ~0027654

Agreed, good catch.

Thanks for reporting/triaging.

I'll commit this for the next release.

cas

cas

2010-12-22 06:18

reporter   ~0027660

Can confirm the fix works as expected.

dhx

dhx

2010-12-24 20:49

reporter   ~0027689

Thanks Jürgen and Roland. I have committed a fix to the problem.

Related Changesets

MantisBT: master-1.2.x 427b65b9

2010-12-24 20:19

dhx


Details Diff
Fix 0012622: Changing reporter on the bug update page doesn't work

There was a typo introduced by the patch for 0012354 that meant some
JavaScript code was not being included correctly. This code was
responsible for allowing the textual [edit] button to work with the
reporter field on bug_update_page.
Affected Issues
0012622
mod - core/html_api.php Diff File