0012363: billing report seems not to include enddate - MantisBT - Signup temporarily disabled due to spam

ID	Project	Category	View Status	Date Submitted	Last Update

0012363	mantisbt	time tracking	public	2010-09-16 11:04	2010-12-17 04:40

Reporter	fabian_eschrich	Assigned To	dhx
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.3
Target Version	1.2.4	Fixed in Version	1.2.4

Summary	0012363: billing report seems not to include enddate
Description	When I click on billing to see how much my coders worked. I choose timespan 2010-08-01 to 2010-08-31, 2010-08-31 is not included. Only when I choose 2010-09-01 as enddate, the 31th is included. Maybe query uses < instead of <=
Tags	No tags attached.

dhx 2010-09-17 22:57 reporter ~0026758	Thanks for the bug report. I think I have now fixed it. I haven't tested this patch because the built in billing system is likely going to be deprecated in a future version of MantisBT (in favour of a plugin such as TimeCard, see git.mantisforge.org). I would really appreciate if you could test the patch and confirm whether it fixes the problem for you. If it doesn't, please feel free to reopen this bug report.

fabian_eschrich 2010-09-18 05:11 reporter ~0026771	thanks for this fix, but it does not solve the problem. I still do not see the hours of 31th august on billing page billing_page.php when I choose 1st to 31st of august in timespan

vr5 2010-09-18 15:40 reporter ~0026773 Last edited: 2010-09-18 15:44	@dhx similar fix needs to be applied to bugnote_stats_get_events_array function (just like to bugnote_stats_get_project_array), see patch calls-to-strtotime-fixed.patch in issue 0012154

dhx 2010-10-22 10:16 reporter ~0027135	Thanks Fabian and vr5. I'll have this fixed shortly. In the mean time see 0012154 for vr5's patch.

dhx 2010-11-19 08:57 reporter ~0027419	Sorry for the delay, I've finally pushed the patch to solve this issue. Thanks vr5 for your patch (it is what I've used in this latest commit).

MantisBT: master db2b0070 2010-09-17 22:43 dhx Details Diff	Fix 0012363: Billing report end date not included in range The end date of a billing report page is not included in the range of issues parsed by the report. This is due to a bug inside bugnote_stats_get_project_array(..) of bugnote_api.php that misinterprets the PHP documentation of how the strtotime() function operates.		Affected Issues 0012363
	mod - core/bugnote_api.php		Diff File
MantisBT: master-1.2.x aa9540d2 2010-09-17 22:43 dhx Details Diff	Fix 0012363: Billing report end date not included in range The end date of a billing report page is not included in the range of issues parsed by the report. This is due to a bug inside bugnote_stats_get_project_array(..) of bugnote_api.php that misinterprets the PHP documentation of how the strtotime() function operates.		Affected Issues 0012363
	mod - core/bugnote_api.php		Diff File
MantisBT: master a14b882d 2010-11-19 08:53 dhx Details Diff	Fix 0012363: Billing report end date is inaccurate The strototime() function was being called incorrectly, leading to the last day of a billing report range not being included in the results. There was also an off-by-one-second mistake with calculating the timestamp denoting the end of any given day in the billing report range. Thanks to vr5 for the initial patch.		Affected Issues 0012363
	mod - core/bugnote_api.php		Diff File
MantisBT: master-1.2.x 0bf8b4f6 2010-11-19 08:53 dhx Details Diff	Fix 0012363: Billing report end date is inaccurate The strototime() function was being called incorrectly, leading to the last day of a billing report range not being included in the results. There was also an off-by-one-second mistake with calculating the timestamp denoting the end of any given day in the billing report range. Thanks to vr5 for the initial patch.		Affected Issues 0012363
	mod - core/bugnote_api.php		Diff File