View Issue Details

IDProjectCategoryView StatusLast Update
0012344mantisbtadministrationpublic2010-12-17 04:40
Reporterdregad Assigned Toatrol  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.1 
Target Version1.2.4Fixed in Version1.2.4 
Summary0012344: In manage_user_page.php changing page resets sort criteria
Description

This is probably related to 0004654.

The sort criteria is correctly kept when using the prefix filter (All A B C ...), but still lost when the users' list spans multiple pages, and you navigate between them using the links at the bottom right.

Best regards

Steps To Reproduce

In manage_user_page.php, making sure that you have >50 users in the system (so that the "All" list spans more than one page):

  • Click on "Real Name" column header
  • List is now sorted by real name ascending
  • Go to another page, e.g. click Next at bottom of screen
  • List is again sorted by username ascending
Tagspatch
Attached Files
issue12344.patch (925 bytes)   
From b5e43ef1df33d5ac996e0f75620232e173154c9e Mon Sep 17 00:00:00 2001
From: Roland Becker <roland@atrol.de>
Date: Fri, 17 Sep 2010 22:48:07 +0200
Subject: [PATCH] Fix #12077 #12344: In manage_user_page.php changing page resets sort criteria

---
 manage_user_page.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/manage_user_page.php b/manage_user_page.php
index afd3c79..0e81cfa 100644
--- a/manage_user_page.php
+++ b/manage_user_page.php
@@ -336,7 +336,7 @@
 			<span class="small">
 				<?php
 					/* @todo hack - pass in the hide inactive filter via cheating the actual filter value */
-					print_page_links( 'manage_user_page.php', 1, $t_page_count, (int)$f_page_number, $c_filter . $t_hide_filter);
+					print_page_links( 'manage_user_page.php', 1, $t_page_count, (int)$f_page_number, $c_filter . $t_hide_filter . "&sort=$c_sort&dir=$c_dir");
 				?>
 			</span>
 		</td>
-- 
1.7.2.3

issue12344.patch (925 bytes)   

Relationships

has duplicate 0012077 closedatrol Manage User page links do not preserve sort order 

Activities

atrol

atrol

2010-09-17 16:56

developer   ~0026746

Reminder sent to: dhx

Please have a look at the patch and let it become part of 1.2.x

dhx

dhx

2010-09-17 21:04

reporter   ~0026750

Thanks Roland, I've committed your patch.

dregad

dregad

2010-09-20 07:28

developer   ~0026802

Dear atrol,

Many thanks for looking into the issue I submitted. I have applied your patch on my system, and confirm that it resolves the problem for me.

Have a nice day

Related Changesets

MantisBT: master efb50eb7

2010-09-17 16:48

atrol

Committer: dhx


Details Diff
Fix 0012344: manage_user_page.php: changing page resets sort criteria

When a user navigates to a different page of the search results the
current sort criteria are forgotten.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0012344
mod - manage_user_page.php Diff File

MantisBT: master-1.2.x 5744213a

2010-09-17 16:48

atrol

Committer: dhx


Details Diff
Fix 0012344: manage_user_page.php: changing page resets sort criteria

When a user navigates to a different page of the search results the
current sort criteria are forgotten.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0012344
mod - manage_user_page.php Diff File