0012293: Not all the categories are displayed

(0026465)
istvanb (reporter)
2010-08-25 05:38
edited on: 2010-08-25 07:43

Ok, after a small research I have found this:

in the graph_api.php line 756 (under the create_category_summary() funtion) the query does not contain project ID 0 which is the ALL PROJECT. Because of this the global categories are not displayed since they belongs to the ALL PROJECT and just inherited by the rest of the project.

I have modified the the query:

    $query = "SELECT id, name
        FROM $t_cat_table
        WHERE $specific_where OR project_id=0
        ORDER BY name";
    $result = db_query_bound( $query );
    $category_count = db_num_rows( $result );

and the display part as well:
        if ( isset($t_metrics[$t_cat_name]) ) {
            $t_metrics[$t_cat_name] = $t_metrics[$t_cat_name] + db_result( $result2, 0, 0 );
        } else {
            if (db_result( $result2, 0, 0 ) > 0)
            $t_metrics[$t_cat_name] = db_result( $result2, 0, 0 );


I assume adding the "OR project_id = 0" is not a very elegant solution, however it works. Because this function is only called from the graph plugin it wont break anything else and now it displays the graph properly.

The display part modification will hide all the unused categories, but all the categories are visible which used by at least one issue.

Probably somebody with more experience should also take a look at the problem so create a more robust solution.

(0031731)
VeMag (reporter)
2012-04-30 06:14

I've made a pull request for this :
https://github.com/mantisbt/mantisbt/pull/47 [^]

(0036267)
grangeway (developer)
2013-04-05 17:57

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets
MantisBT: master 0ea8cc50 Timestamp: 2012-04-30 14:30:49 Author: VeMag [ Details ] [ Diff ]	Small changes to include global categories in graph and to hide empty values Fixes 0012293
	mod - plugins/MantisGraph/core/graph_api.php	[ Diff ] [ File ]

MantisBT: master-1.2.x c4ad6d83 Timestamp: 2012-04-30 14:30:49 Author: VeMag [ Details ] [ Diff ]	Small changes to include global categories in graph and to hide empty values Fixes 0012293
	mod - plugins/MantisGraph/core/graph_api.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-08-25 05:01	istvanb	New Issue
2010-08-25 05:38	istvanb	Note Added: 0026465
2010-08-25 07:43	istvanb	Note Edited: 0026465	View Revisions
2011-09-14 15:06	atrol	Relationship added	has duplicate 0011437
2012-04-30 06:14	VeMag	Note Added: 0031731
2012-04-30 17:27	rombert	Assigned To	=> rombert
2012-04-30 17:27	rombert	Status	new => assigned
2012-04-30 17:27	rombert	Target Version	=> 1.2.11
2012-04-30 17:27	rombert	Description Updated	View Revisions
2012-04-30 17:41	rombert	Status	assigned => resolved
2012-04-30 17:41	rombert	Resolution	open => fixed
2012-04-30 17:41	rombert	Fixed in Version	=> 1.2.11
2012-04-30 18:00	VeMag	Changeset attached	=> MantisBT master 0ea8cc50
2012-04-30 18:00	VeMag	Changeset attached	=> MantisBT master-1.2.x c4ad6d83
2012-06-06 23:53	jreese	Status	resolved => closed
2013-04-05 17:57	grangeway	Status	closed => acknowledged
2013-04-05 17:57	grangeway	Note Added: 0036267
2013-04-05 18:34	grangeway	Relationship added	related to 0015721
2013-04-06 03:40	dregad	Status	acknowledged => closed
2013-04-06 07:23	grangeway	Status	closed => acknowledged
2013-04-06 09:22	dregad	Tag Attached: 2.0.x check
2013-04-06 09:23	dregad	Status	acknowledged => closed

Notes
(0026465) istvanb (reporter) 2010-08-25 05:38 edited on: 2010-08-25 07:43	Ok, after a small research I have found this: in the graph_api.php line 756 (under the create_category_summary() funtion) the query does not contain project ID 0 which is the ALL PROJECT. Because of this the global categories are not displayed since they belongs to the ALL PROJECT and just inherited by the rest of the project. I have modified the the query: $query = "SELECT id, name FROM $t_cat_table WHERE $specific_where OR project_id=0 ORDER BY name"; $result = db_query_bound( $query ); $category_count = db_num_rows( $result ); and the display part as well: if ( isset($t_metrics[$t_cat_name]) ) { $t_metrics[$t_cat_name] = $t_metrics[$t_cat_name] + db_result( $result2, 0, 0 ); } else { if (db_result( $result2, 0, 0 ) > 0) $t_metrics[$t_cat_name] = db_result( $result2, 0, 0 ); I assume adding the "OR project_id = 0" is not a very elegant solution, however it works. Because this function is only called from the graph plugin it wont break anything else and now it displays the graph properly. The display part modification will hide all the unused categories, but all the categories are visible which used by at least one issue. Probably somebody with more experience should also take a look at the problem so create a more robust solution.

(0031731) VeMag (reporter) 2012-04-30 06:14	I've made a pull request for this : https://github.com/mantisbt/mantisbt/pull/47 [^]

(0036267) grangeway (developer) 2013-04-05 17:57	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch