View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0012205 | mantisbt | bugtracker | public | 2010-07-28 12:01 | 2014-12-08 00:34 |
Reporter | Sergiodf | Assigned To | dhx | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.1 | ||||
Target Version | 1.3.0-beta.1 | Fixed in Version | 1.3.0-beta.1 | ||
Summary | 0012205: Do not leave feedback status when the handler adds a note | ||||
Description | In Mantis default configuration, when an issue in feedback status gets a new note from the reporter, automatically change its status to new or assigned. I work with lazy people who never fill in an issue, so I have to report by myself. In this case, it is not good the issue leave feedback status when I add a note, so I make a little fix to prevent it to happen when the note is added by the handler of the issue. | ||||
Steps To Reproduce |
| ||||
Tags | patch | ||||
Attached Files | 12205.diff (915 bytes)
--- /mantis/mantisbt-1.2.1-official/core/bugnote_api.php Fri Apr 23 14:28:34 2010 +++ /mantis/mantisbt-1.2.1-patches/core/bugnote_api.php Wed Jul 28 12:44:29 2010 @@ -189,9 +189,11 @@ history_log_event_special( $p_bug_id, BUGNOTE_ADDED, bugnote_format_id( $t_bugnote_id ) ); # if it was FEEDBACK its NEW_ now - if ( config_get( 'reassign_on_feedback' ) && - bug_get_field( $p_bug_id, 'status' ) == config_get( 'bug_feedback_status' ) && - bug_get_field( $p_bug_id, 'reporter_id' ) == $c_user_id ) { + if ( config_get( 'reassign_on_feedback' ) + && bug_get_field( $p_bug_id, 'status' ) == config_get( 'bug_feedback_status' ) + && bug_get_field( $p_bug_id, 'reporter_id' ) == $c_user_id + && bug_get_field( $p_bug_id, 'handler_id') != $c_user_id + ) { if ( bug_get_field( $p_bug_id, 'handler_id') == 0 ) { bug_set_field( $p_bug_id, 'status', config_get( 'bug_submit_status' ) ); | ||||
Thanks for your patch Sergio. Unfortunately I think your patch may be incorrect. The reassign on feedback feature is meant to allow developers a chance to request feedback from the reporter of the issue. Once that reporter provides feedback in a note, the status is meant to change to either $g_bug_submit_status if no handler is defined for the bug or $g_bug_assigned_status if a handler is defined. Your patch essentially disables the feature entirely. I think you may be better to just set $g_reassign_on_feedback = OFF in your configuration to turn the feature off on your bug tracker. |
|
Sorry, I understand the problem now. This should be fixed now in the 1.3.x branch. If the handler of the issue is also the reporter of the issue and this person is replying when the status is "feedback", the reassign on feedback feature should not apply. Thanks Sergio! |
|
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
|
MantisBT: master 95ac1e0c 2010-08-14 01:12 Details Diff |
Fix 0012205: Disable reassign on feedback when the handler replies If the handler of an issue replies to a bug in the "feedback" status then the reassign on feedback feature should not apply. |
Affected Issues 0012205 |
|
mod - bugnote_add.php | Diff File | ||
mod - bug_update.php | Diff File |