| Anonymous | Login | Signup for a new account | 2013-06-19 18:04 EDT |  |
| Main | My View | View Issues | Change Log | Roadmap | Wiki | ManTweet | Repositories |
| View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0012129 | mantisbt | administration | public | 2010-07-01 12:58 | 2013-04-06 09:23 | ||||
| Reporter | KarlReichert | ||||||||
| Assigned To | dregad | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | 1.2.1 | ||||||||
| Target Version | 1.2.11 | Fixed in Version | 1.2.11 | ||||||
| Summary | 0012129: workflow transition to status reopened is always checked for some status on workflow transition page | ||||||||
| Description | I'm using custom status values. I configured status "solved" to be the status, where an issue is considered to be resolved. Following this status, the status "tested" is the next status in my workflow, and finally status "closed". I configured in the "workflow transitions" page, that a transition to status "reopened" is only possible from status "closed", not from any other status. When I check the Configuration Report, I can see, this configuration is stored correct in the database (please see the attachment "status_enum_workflow.png"; transition to 20, i.e. reopened, is only possible from 90, i.e. closed). However, if I now go to the "Workflow Transitions" page, the transition to "reopened" is checked from status "solved", "tested" and "closed" (please see the attachment "workflow_transitions.png"). If I do not save anything on this page and go back to the configuration report, I can see, that still everything is configured as before, i.e. the configuration is not changed. So the problem is, when opening the page "workflow transitions", MantisBT always sets transitions from the state configured to be considered as resolved to the status configured to be considered as reopened, no matter what is stored in the database. This does not break my configuration, as long as I don't save anything on page "Workflow transitions" or if I uncheck those transitions every time, before saving. But it's quite annoying and misleading. | ||||||||
| Tags | 2.0.x check | ||||||||
| Attached Files |  status_enum_workflow.png [^] (16,854 bytes) 2010-07-01 12:58
workflow_transitions.png [^] (45,563 bytes) 2010-07-01 12:59
workflow - 2012-06-05_113124.png [^] (24,190 bytes) 2012-06-05 10:31
| ||||||||
 Relationships |
|||||||||||
|
|||||||||||
 Relationships |
|
Notes |
|
 (0031597)dregad (developer) 2012-04-04 11:50 |
I can confirm this behavior and will commit a patch later on |
|
(0031599) dregad (developer) 2012-04-05 05:11 |
This should now be resolved. Please download a nightly build and test, and let me know if you discover any issues with the fix. Note: in master/1.3, manage_config_workflow_page.php failed to load due to an error caused by type mismatch while calling the check_checked() function. Commit [1] fixes this. [1] https://github.com/mantisbt/mantisbt/commit/052606d21aa302142288bf5eceeaa1377ef56dac [^] |
 (0031657)JanHegewald (reporter) 2012-04-15 12:31 |
Thanks for the patch . I took over the Mantis tasks from Karl in our company and so I'm going to check this at the end of cw 16 or in cw 17. But I can't check for 1.3, because I currently don't have an 1.3 installation. I'm going to let you know, if your patch is fixing the problem for me. |
|
(0031702) JanHegewald (reporter) 2012-04-23 03:09 |
Thanks again, works for me on 1.2.5 and 1.2.8. As I already said, not tested on 1.3. |
|
(0031703) dregad (developer) 2012-04-23 04:04 |
Thanks for your testing and confirmation. And don't worry about 1.3. Have a nice day ! |
 (0032021)marco.scariot@gmail.com (reporter) 2012-06-05 10:36 |
Hi Dregad. Maybe the same thing in 1.2.10? I still have the same problem above with other user. Sorry by comment, but I'm neewbe in report bugs here. I'm using 1.2.10. How i fix that? Thanks! Ps: Image in attatchment. |
 (0032022)atrol (developer) 2012-06-05 11:01 |
marco.scariot@gmail.com, the issue is marked as fixed in version 1.2.x. This means it will be fixed in next stable version 1.2.11 (expected to be released in a few days) If you can't wait, you can try a nightly build http://www.mantisbt.org/builds/ [^] |
|
(0032023) marco.scariot@gmail.com (reporter) 2012-06-05 12:25 |
Ok! Thankyou very much Atrol! |
 (0036280)grangeway (developer) 2013-04-05 17:57 |
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
|
Notes |
| Related Changesets |
|||
|
MantisBT: master 7e7ba3d9
Timestamp: 2012-04-04 08:44:41 Author: dregad [ Details ] [ Diff ] |
Fix workflow transition to status reopened always checked In manage_config_workflow_page.php, the code was always showing the 'reopened' states as checked regardless of the actual values stored in the database. This was due to storing the 'reopened' label within the array of values used to build the table to display, which consequently were always set. The code that initializes the labels has been removed from function parse_workflow(), and the logic is now handled directly in show_flag(), with globally initialized variables for better performance. Fixes 0012129 |
||
| mod - core/workflow_api.php | [ Diff ] [ File ] | ||
| mod - manage_config_workflow_page.php | [ Diff ] [ File ] | ||
|
MantisBT: master-1.2.x 08b00de0
Timestamp: 2012-04-04 08:44:41 Author: dregad [ Details ] [ Diff ] |
Fix workflow transition to status reopened always checked In manage_config_workflow_page.php, the code was always showing the 'reopened' states as checked regardless of the actual values stored in the database. This was due to storing the 'reopened' label within the array of values used to build the table to display, which consequently were always set. The code that initializes the labels has been removed from function parse_workflow(), and the logic is now handled directly in show_flag(), with globally initialized variables for better performance. Fixes 0012129 |
||
| mod - manage_config_workflow_page.php | [ Diff ] [ File ] | ||
|
MantisBT: master 052606d2
Timestamp: 2012-04-04 09:53:16 Author: dregad [ Details ] [ Diff ] |
Fix type check error in manage_config_workflow_page.php Strict type check in function check_selected() caused an error comparing false with the status level, so replaced with 0 |
||
| mod - manage_config_workflow_page.php | [ Diff ] [ File ] | ||
| Related Changesets |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-07-01 12:58 | KarlReichert | New Issue | |
| 2010-07-01 12:58 | KarlReichert | File Added: status_enum_workflow.png | |
| 2010-07-01 12:59 | KarlReichert | File Added: workflow_transitions.png | |
| 2012-04-04 11:17 | dregad | Relationship added | related to 0011661 |
| 2012-04-04 11:50 | dregad | Note Added: 0031597 | |
| 2012-04-04 11:50 | dregad | Assigned To | => dregad |
| 2012-04-04 11:50 | dregad | Status | new => assigned |
| 2012-04-04 11:50 | dregad | Target Version | => 1.2.11 |
| 2012-04-04 14:00 | dregad | Changeset attached | => MantisBT master 7e7ba3d9 |
| 2012-04-04 14:00 | dregad | Changeset attached | => MantisBT master-1.2.x 08b00de0 |
| 2012-04-04 14:00 | dregad | Status | assigned => resolved |
| 2012-04-04 14:00 | dregad | Resolution | open => fixed |
| 2012-04-04 14:00 | dregad | Fixed in Version | => 1.2.11 |
| 2012-04-05 05:06 | dregad | Changeset attached | => MantisBT master 052606d2 |
| 2012-04-05 05:11 | dregad | Note Added: 0031599 | |
| 2012-04-15 12:31 | JanHegewald | Note Added: 0031657 | |
| 2012-04-23 03:09 | JanHegewald | Note Added: 0031702 | |
| 2012-04-23 04:04 | dregad | Note Added: 0031703 | |
| 2012-06-05 10:31 | marco.scariot@gmail.com | File Added: workflow - 2012-06-05_113124.png | |
| 2012-06-05 10:36 | marco.scariot@gmail.com | Note Added: 0032021 | |
| 2012-06-05 11:01 | atrol | Note Added: 0032022 | |
| 2012-06-05 12:25 | marco.scariot@gmail.com | Note Added: 0032023 | |
| 2012-06-06 23:53 | jreese | Status | resolved => closed |
| 2013-04-05 17:57 | grangeway | Status | closed => acknowledged |
| 2013-04-05 17:57 | grangeway | Note Added: 0036280 | |
| 2013-04-05 18:33 | grangeway | Relationship added | related to 0015721 |
| 2013-04-06 03:40 | dregad | Status | acknowledged => closed |
| 2013-04-06 07:23 | grangeway | Status | closed => acknowledged |
| 2013-04-06 09:22 | dregad | Tag Attached: 2.0.x check | |
| 2013-04-06 09:23 | dregad | Status | acknowledged => closed |
|
Issue History |
| MantisBT 1.2.16dev master-1.2.x-05091f5 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.0925 seconds. memory usage: 2,891 KB |
|