MantisBT

View Issue Details Jump to Notes ] Wiki ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011726mantisbtadministrationpublic2010-03-29 16:052013-04-06 09:23
Reporterandy_mbt 
Assigned Todregad 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2.0 
Target Version1.2.11Fixed in Version1.2.11 
Summary0011726: Add a "Hide Disabled" filter option to the Manage Users page.
DescriptionPretty self-explanatory, add a filter (similar to the "Hide Inactive" filter) that would hide all Disabled user accounts from the user list in Manage Users.
Tags2.0.x check
Attached Filesdiff file icon show-disabled-checkbox.diff [^] (8,392 bytes) 2012-05-04 10:02 [Show Content]

- Relationships
duplicate of 0005498closedatrol Add a "Hide Disabled" Filter to the Admin Interface 
related to 0015721new Functionality to consider porting to master-2.0.x 

-  Notes
User avatar (0024929)
jreese (administrator)
2010-03-29 18:34

Targetting for next feature release
User avatar (0031760)
davidnewcomb (developer)
2012-05-04 09:11
edited on: 2012-05-04 09:19

How about flipping it around? I don't know about anyone else but I never need to see the Disabled users! How about it defaults to not showing disabled users and you have a checkbox to include them.

User avatar (0031761)
davidnewcomb (developer)
2012-05-04 10:06

The quickest way to get your features in is to do it yourself ;)
I've uploaded a patch that can be applied to 1.2.9 to add this feature.

I know this feature is targeted for 1.3 but please can you apply this patch to the 1.2 branch as 1.3 is nowhere near being released yet.
User avatar (0031762)
dregad (developer)
2012-05-04 12:26

David,

First of all, many thanks for your contribution.

I'll have a look in detail as time allows. I believe this kind of change should be no problem to include on 1.2.x, considering you gave us the code for it ;-)

Would you like to be listed as author on the commit in the repository (your e-mail address would appear there as well), or alternatively credited in the commit message ?

Note: in the future, if that is possible for you, please make our lives easier by providing your patches as Github pull requests.
User avatar (0036268)
grangeway (developer)
2013-04-05 17:57

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master 93eb5401
Timestamp: 2012-05-06 03:16:56
Author: dregad
Details ] Diff ]
Add filter in Manage Users page to show/hide disabled users

This is a port of the following 1.2.x commits:

   - a21374af650c06a27bf9a930edbcbef9b41989ac,

Original patch written by David Newcomb.

Fixed issue with new filter not specified on the multi-page navigation
links. Also made minor cosmetic changes: whitespace, coding guidelines.

   - 129a8e5e93fda7537884bea371b794bb44c13c0c

Simplify code by using a for loop to print the column headers instead of
manually building the table cells one by one. Note that this actually
changes the label of the 'Protected' column from the padlock icon to a
text description.

Rename 'hide' variable to 'hide_inactive'. With the addition of the new
filter option 'show_disabled', using just 'hide' was potentially
confusing.

   - e28fa43081f8365fafbc0c2331938032a3fe89a4

The filter in managed_user_page.php is not persistent

The filter values stored in the cookie whenever the criteria change,
were restored to the form variables instead of the sanitized ($c_)
variables, and were therefore not taken into account when building the
page.

Fixes 0011726, 0014216
mod - core/print_api.php Diff ] File ]
mod - lang/strings_english.txt Diff ] File ]
mod - manage_user_page.php Diff ] File ]
MantisBT: master-1.2.x a21374af
Timestamp: 2012-05-06 03:16:56
Author: dregad
Details ] Diff ]
Add filter in Manage Users page to show/hide disabled users

Original patch written by David Newcomb.

Fixed issue with new filter not specified on the multi-page navigation
links. Also made minor cosmetic changes: whitespace, coding guidelines.

Fixes 0011726
mod - core/print_api.php Diff ] File ]
mod - lang/strings_english.txt Diff ] File ]
mod - manage_user_page.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-03-29 16:05 andy_mbt New Issue
2010-03-29 18:34 jreese Note Added: 0024929
2010-03-29 18:34 jreese Assigned To => jreese
2010-03-29 18:34 jreese Severity minor => feature
2010-03-29 18:34 jreese Status new => assigned
2010-03-29 18:34 jreese Target Version => 1.3.x
2010-06-02 18:50 atrol Relationship added duplicate of 0005498
2012-05-04 09:11 davidnewcomb Note Added: 0031760
2012-05-04 09:19 davidnewcomb Note Edited: 0031760 View Revisions
2012-05-04 10:02 davidnewcomb File Added: 0011726-show-disabled-checkbox.diff
2012-05-04 10:06 davidnewcomb Note Added: 0031761
2012-05-04 12:21 dregad Assigned To jreese => dregad
2012-05-04 12:26 dregad Note Added: 0031762
2012-05-06 09:53 dregad Status assigned => resolved
2012-05-06 09:53 dregad Resolution open => fixed
2012-05-06 09:53 dregad Fixed in Version => 1.2.11
2012-05-06 09:53 dregad Target Version 1.3.x => 1.2.11
2012-05-06 10:00 dregad Changeset attached => MantisBT master 93eb5401
2012-05-06 10:00 dregad Changeset attached => MantisBT master-1.2.x a21374af
2012-06-06 23:53 jreese Status resolved => closed
2013-04-05 17:57 grangeway Status closed => acknowledged
2013-04-05 17:57 grangeway Note Added: 0036268
2013-04-05 18:34 grangeway Relationship added related to 0015721
2013-04-06 03:40 dregad Status acknowledged => closed
2013-04-06 07:23 grangeway Status closed => acknowledged
2013-04-06 09:22 dregad Tag Attached: 2.0.x check
2013-04-06 09:23 dregad Status acknowledged => closed


MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.0998 seconds.
memory usage: 2,906 KB
Powered by Mantis Bugtracker