0011571: Cannot edit some versions - MantisBT

Mantis Bug Tracker

View Issue Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ << ] [ >> ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0011571

mantisbt

administration

public

2010-02-28 09:24

2010-04-23 14:30

Reporter

simtel

Assigned To

dhx

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

1.2.0

Target Version

1.2.1

Fixed in Version

1.2.1

Summary

0011571: Cannot edit some versions

Description

After upgrading to 1.2.0 I've found that I cannot edit some versions.

I have a project with versions:

1.20
...
1.10
1.9
...
1.2
1.1

When I click on "Edit" next to 1.2, mantis shows me the 1.20 properties. When I click 1.1 it shows me 1.10!

Is there an hidden settings to turn this behaviour off or is it just a plain bug? :)

I'm using PostgreSQL, if it matters.

Tags

No tags attached.

Relationships

Notes
(0024568) atrol (developer) 2010-02-28 09:37	reproduced with mySQL, not related to database

(0024572) dhx (developer) 2010-02-28 20:28	Thanks for reporting this bug. I've fixed it ready for the next minor release 1.2.1 :)

Related Changesets
MantisBT: master-1.2.x 3cca9275 Timestamp: 2010-03-01 01:22:55 Author: dhx Committer: David Hicks [ Details ] [ Diff ]	Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead.
	mod - core/version_api.php		[ Diff ] [ File ]

MantisBT: master 0e5ad6ca Timestamp: 2010-03-01 01:22:55 Author: dhx Committer: David Hicks [ Details ] [ Diff ]	Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead.
	mod - core/version_api.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-02-28 09:24	simtel	New Issue
2010-02-28 09:37	atrol	Note Added: 0024568
2010-02-28 09:37	atrol	Status	new => confirmed
2010-02-28 09:45	simtel	Issue Monitored: simtel
2010-02-28 20:27	dhx	Status	confirmed => assigned
2010-02-28 20:27	dhx	Assigned To	=> dhx
2010-02-28 20:27	dhx	Target Version	=> 1.2.x
2010-02-28 20:28	dhx	Note Added: 0024572
2010-02-28 20:28	dhx	Status	assigned => resolved
2010-02-28 20:28	dhx	Fixed in Version	=> 1.2.x
2010-02-28 20:28	dhx	Resolution	open => fixed
2010-02-28 20:30	dhx	Changeset attached	master-1.2.x 3cca9275 =>
2010-02-28 20:30	dhx	Changeset attached	master 0e5ad6ca =>
2010-04-23 14:30	jreese	Status	resolved => closed

MantisBT 1.2.2 git master-1.2.x[^]

Copyright © 2000 - 2010 MantisBT Group

Time: 0.2160 seconds.
memory usage: 1,958 KB