View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011482 | mantisbt | html | public | 2010-02-09 09:06 | 2010-02-22 14:34 |
Reporter | davidinc | Assigned To | dhx | ||
Priority | normal | Severity | tweak | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0rc2 | ||||
Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
Summary | 0011482: [patch] print_page_links/print_page_number: allow ? in $p_page parameter | ||||
Description | We made this patch for using this functions print_page_links/print_page_number in combination with plugin_page plugin pages already contain a get parameter, so the addition page number must be added using the & (and not the ?) | ||||
Tags | No tags attached. | ||||
Use this link to find the patch http://git.mantisforge.org/w/mantisbt/gtz-et.git?a=shortlog;h=refs/heads/mantisbt-issue11482-fix |
|
Thanks for this patch, looks good! I've made some minor code style adjustments. If possible, can you please compare what I committed to what you originally created? It will help you learn some of the coding style requirements of MantisBT :) |
|
Yup you right I already compare it and it looks good. Nice change you make for load URLs speed{}. appreciate the contribution you make on the issue thx ciao |
|
MantisBT: master-1.2.x b551fbc0 2010-02-10 01:03 Dawit Ayalew Committer: dhx Details Diff |
Fix 0011482: Fix delimiter for links generated with print_page_link[s] The functions print_page_link/print_page_links take a URL and add extra parameters to the end of the URL for page navigation. The problem is that plugin pages already contain parameters. Thus we shouldn't assume that URLs passed to these functions don't already contain parameters. This patch checks for existing parameters and if any are found, page navigation parameters are appended to the end with an ampersand delimiter instead of question mark. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0011482 |
|
mod - core/print_api.php | Diff File | ||
MantisBT: master f838e89d 2010-02-10 01:03 Dawit Ayalew Committer: dhx Details Diff |
Fix 0011482: Fix delimiter for links generated with print_page_link[s] The functions print_page_link/print_page_links take a URL and add extra parameters to the end of the URL for page navigation. The problem is that plugin pages already contain parameters. Thus we shouldn't assume that URLs passed to these functions don't already contain parameters. This patch checks for existing parameters and if any are found, page navigation parameters are appended to the end with an ampersand delimiter instead of question mark. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0011482 |
|
mod - core/print_api.php | Diff File |