View Issue Details

IDProjectCategoryView StatusLast Update
0011482mantisbthtmlpublic2010-02-22 14:34
Reporterdavidinc Assigned Todhx  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product Version1.2.0rc2 
Target Version1.2.0Fixed in Version1.2.0 
Summary0011482: [patch] print_page_links/print_page_number: allow ? in $p_page parameter
Description

We made this patch for using this functions print_page_links/print_page_number in combination with plugin_page

plugin pages already contain a get parameter, so the addition page number must be added using the & (and not the ?)

TagsNo tags attached.

Relationships

related to 0011569 closeddhx Error when visiting the "manage users" page 

Activities

davidinc

davidinc

2010-02-10 04:30

reporter   ~0024360

Last edited: 2010-02-10 04:39

Use this link to find the patch

http://git.mantisforge.org/w/mantisbt/gtz-et.git?a=shortlog;h=refs/heads/mantisbt-issue11482-fix

dhx

dhx

2010-02-10 06:56

reporter   ~0024365

Thanks for this patch, looks good! I've made some minor code style adjustments. If possible, can you please compare what I committed to what you originally created? It will help you learn some of the coding style requirements of MantisBT :)

davidinc

davidinc

2010-02-10 11:02

reporter   ~0024367

Yup you right I already compare it and it looks good. Nice change you make for load URLs speed{}. appreciate the contribution you make on the issue thx ciao

Related Changesets

MantisBT: master-1.2.x b551fbc0

2010-02-10 01:03

Dawit Ayalew

Committer: dhx


Details Diff
Fix 0011482: Fix delimiter for links generated with print_page_link[s]

The functions print_page_link/print_page_links take a URL and add extra
parameters to the end of the URL for page navigation. The problem is
that plugin pages already contain parameters. Thus we shouldn't assume
that URLs passed to these functions don't already contain parameters.

This patch checks for existing parameters and if any are found, page
navigation parameters are appended to the end with an ampersand
delimiter instead of question mark.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0011482
mod - core/print_api.php Diff File

MantisBT: master f838e89d

2010-02-10 01:03

Dawit Ayalew

Committer: dhx


Details Diff
Fix 0011482: Fix delimiter for links generated with print_page_link[s]

The functions print_page_link/print_page_links take a URL and add extra
parameters to the end of the URL for page navigation. The problem is
that plugin pages already contain parameters. Thus we shouldn't assume
that URLs passed to these functions don't already contain parameters.

This patch checks for existing parameters and if any are found, page
navigation parameters are appended to the end with an ampersand
delimiter instead of question mark.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0011482
mod - core/print_api.php Diff File