View Issue Details

IDProjectCategoryView StatusLast Update
0011326mantisbtattachmentspublic2014-07-22 13:56
Reporterdhx Assigned Todhx  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0rc2 
Target Version1.2.0Fixed in Version1.2.0 
Summary0011326: Invalid form security token error displayed instead of file upload size too large error
Description

When a user attempts to upload a file that is too large (via bug_file_add.php) the form POST values are not available to PHP. Therefore the forum token security check will always fail first, resulting in the wrong error message being shown to the user. Instead, the check for blank POST form values should be performed first and a "maximum file size exceeded" message shown to the user. If the file size looks OK (from this initial check) then we can proceed to check the form security token, knowing that any error message generated now will be relevant.

TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

MantisBT: master-1.2.x 67762d7e

2010-01-05 03:13

dhx


Details Diff
Fix 0011326: Don't show form security token error for oversized uploads

When a user attempts to upload a file that is too large (via
bug_file_add.php) the form POST values are not available to PHP.
Therefore the forum token security check will always fail first,
resulting in the wrong error message being shown to the user. Instead,
the check for blank POST form values should be performed first and a
"maximum file size exceeded" message shown to the user. If the file size
looks OK (from this initial check) then we can proceed to check the form
security token, knowing that any error message generated now will be
relevant.
Affected Issues
0011326
mod - bug_file_add.php Diff File

MantisBT: master 45771c63

2010-01-05 03:13

dhx


Details Diff
Fix 0011326: Don't show form security token error for oversized uploads

When a user attempts to upload a file that is too large (via
bug_file_add.php) the form POST values are not available to PHP.
Therefore the forum token security check will always fail first,
resulting in the wrong error message being shown to the user. Instead,
the check for blank POST form values should be performed first and a
"maximum file size exceeded" message shown to the user. If the file size
looks OK (from this initial check) then we can proceed to check the form
security token, knowing that any error message generated now will be
relevant.
Affected Issues
0011326
mod - bug_file_add.php Diff File