View Issue Details

IDProjectCategoryView StatusLast Update
0011266mantisbtapi soappublic2010-02-22 14:35
ReporterMAGMA Assigned Torombert  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0rc2 
Fixed in Version1.2.0 
Summary0011266: mc_issue_update() does not transport all field date
Description

The issue fields 'platform', 'os', 'os_build' and 'build' are not handled. In fact they we be cleared.

Steps To Reproduce

issue = mc_issue_get(...);

mc_issue_update(..., issue);

Additional Information

Suggestion for bug fix:

--- a/api/soap/mc_issue_api.php Wed Nov 25 12:41:10 2009 +0100
+++ b/api/soap/mc_issue_api.php Mon Dec 07 09:11:02 2009 +0100
@@ -595,6 +595,10 @@
$t_description = $p_issue['description'];
$t_additional_information = $p_issue['additional_information'];
$t_steps_to_reproduce = $p_issue['steps_to_reproduce'];

  • $t_build = $p_issue['build'];
  • $t_platform = $p_issue['platform'];
  • $t_os = $p_issue['os'];
  • $t_os_build = $p_issue['os_build'];

    if( $t_reporter_id == 0 ) {
            $t_reporter_id = $t_user_id;

    @@ -675,12 +679,12 @@
    $t_bug_data->date_submitted = isset( $v_date_submitted ) ? $v_date_submitted : '';
    $t_bug_data->last_updated = isset( $v_last_updated ) ? $v_last_updated : '';
    $t_bug_data->eta = $t_eta_id;

  • $t_bug_data->os = isset( $v_os ) ? $v_os : '';
  • $t_bug_data->os_build = isset( $v_os_build ) ? $v_os_build : '';
  • $t_bug_data->platform = isset( $v_platform ) ? $v_platform : '';
  • $t_bug_data->os = isset( $t_os ) ? $t_os : '';
  • $t_bug_data->os_build = isset( $t_os_build ) ? $t_os_build : '';
  • $t_bug_data->platform = isset( $t_platform ) ? $t_platform : '';
    $t_bug_data->version = isset( $p_issue['version'] ) ? $p_issue['version'] : '';
    $t_bug_data->fixed_in_version = isset( $p_issue['fixed_in_version'] ) ? $p_issue['fixed_in_version'] : '';
  • $t_bug_data->build = isset( $v_build ) ? $v_build : '';
  • $t_bug_data->build = isset( $t_build ) ? $t_build : '';
    $t_bug_data->view_state = $t_view_state_id;
    $t_bug_data->summary = $t_summary;
    $t_bug_data->sponsorship_total = isset( $v_sponsorship_total ) ? $v_sponsorship_total : 0;
Tagspatch

Activities

rombert

rombert

2009-12-07 03:51

reporter   ~0023868

@MAGMA : Thanks for reporting this and providing a patch - I'm going to look into it soon.

Would you care to create a git patch, for proper attribution?

MAGMA

MAGMA

2009-12-07 04:10

reporter   ~0023869

@rombert: Here is the git patch:

--- a/api/soap/mc_issue_api.php
+++ b/api/soap/mc_issue_api.php
@@ -595,6 +595,10 @@
$t_description = $p_issue['description'];
$t_additional_information = $p_issue['additional_information'];
$t_steps_to_reproduce = $p_issue['steps_to_reproduce'];

  • $t_build = $p_issue['build'];
  • $t_platform = $p_issue['platform'];
  • $t_os = $p_issue['os'];
  • $t_os_build = $p_issue['os_build'];

    if( $t_reporter_id == 0 ) {
            $t_reporter_id = $t_user_id;

    @@ -675,12 +679,12 @@
    $t_bug_data->date_submitted = isset( $v_date_submitted ) ? $v_date_submitted : '';
    $t_bug_data->last_updated = isset( $v_last_updated ) ? $v_last_updated : '';
    $t_bug_data->eta = $t_eta_id;

  • $t_bug_data->os = isset( $v_os ) ? $v_os : '';
  • $t_bug_data->os_build = isset( $v_os_build ) ? $v_os_build : '';
  • $t_bug_data->platform = isset( $v_platform ) ? $v_platform : '';
  • $t_bug_data->os = isset( $t_os ) ? $t_os : '';
  • $t_bug_data->os_build = isset( $t_os_build ) ? $t_os_build : '';
  • $t_bug_data->platform = isset( $t_platform ) ? $t_platform : '';
    $t_bug_data->version = isset( $p_issue['version'] ) ? $p_issue['version'] : '';
    $t_bug_data->fixed_in_version = isset( $p_issue['fixed_in_version'] ) ? $p_issue['fixed_in_version'] : '';
  • $t_bug_data->build = isset( $v_build ) ? $v_build : '';
  • $t_bug_data->build = isset( $t_build ) ? $t_build : '';
    $t_bug_data->view_state = $t_view_state_id;
    $t_bug_data->summary = $t_summary;
    $t_bug_data->sponsorship_total = isset( $v_sponsorship_total ) ? $v_sponsorship_total : 0;
rombert

rombert

2009-12-07 04:22

reporter   ~0023870

@MAGMA: I meant one which contains author information, created with git format-patch.

MAGMA

MAGMA

2009-12-07 05:37

reporter   ~0023871

@rombert: Sorry, we do use git here.

Related Changesets

MantisBT: master-1.2.x c6300e13

2010-02-19 16:26

rombert


Details Diff
Fixes 0011266: mc_issue_update() does not transport all field date

Implemented setting of the missed fields and added regression test.
Affected Issues
0011266
mod - tests/soap/IssueUpdateTest.php Diff File
mod - api/soap/mc_issue_api.php Diff File

MantisBT: master 313ea5f9

2010-02-19 16:26

rombert


Details Diff
Fixes 0011266: mc_issue_update() does not transport all field date

Implemented setting of the missed fields and added regression test.
Affected Issues
0011266
mod - tests/soap/IssueUpdateTest.php Diff File
mod - api/soap/mc_issue_api.php Diff File