View Issue Details

IDProjectCategoryView StatusLast Update
0011263mantisbtfilterspublic2010-02-22 14:34
Reporterdhx Assigned Todhx  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0 
Target Version1.2.0Fixed in Version1.2.0 
Summary0011263: return_dynamic_filters.php produces non-standard error messages
Description

This file is quite ugly and needs some refactoring. The main problem is that it outputs its own inline error messages instead of calling trigger_error() like every other script does. It also doesn't use gpc_api (and instead directly uses $_GET).

TagsNo tags attached.

Activities

cmfitch1

cmfitch1

2010-02-18 09:52

reporter   ~0024418

This broke plugin filters. The $filter variable was removed, but is still referenced in the plugin section. It should be changed to $t_filter_target.

dhx

dhx

2010-02-18 10:13

reporter   ~0024419

Thanks Chris for picking up this mistake. I've fixed it up :)

Related Changesets

MantisBT: master-1.2.x ce2c3272

2009-12-06 09:53

dhx


Details Diff
Fix 0011263: Refactor and cleanup return_dynamic_filters.php

This file didn't use already-available API such as error_api and
gpc_api. Thus it had poor duplication of existing code, leading to a
number of bugs, mostly relating to the display of error messages. The
file should be a little bit cleaner and easier to read now.
Affected Issues
0011263
mod - lang/strings_english.txt Diff File
mod - return_dynamic_filters.php Diff File

MantisBT: master f92e62ec

2009-12-06 09:53

dhx


Details Diff
Fix 0011263: Refactor and cleanup return_dynamic_filters.php

This file didn't use already-available API such as error_api and
gpc_api. Thus it had poor duplication of existing code, leading to a
number of bugs, mostly relating to the display of error messages. The
file should be a little bit cleaner and easier to read now.
Affected Issues
0011263
mod - return_dynamic_filters.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master-1.2.x f812d51c

2010-02-18 10:01

dhx


Details Diff
Fix 0011263: Incorrect variable naming in return_dynamic_filters

Commit ce2c32727936bb65405878c4f0ae3967cd340500 refactored
return_dynamic_filters.php

There was an error in that refactoring where a variable name wasn't
properly renamed ($filter to $t_filter_target).

Additionally, this commit renames $t_filter_target to $f_filter_target
in accordance with the coding standards. $f_filter_target is form data
supplied by the user.
Affected Issues
0011263
mod - return_dynamic_filters.php Diff File

MantisBT: master cd4ef16c

2010-02-18 10:01

dhx


Details Diff
Fix 0011263: Incorrect variable naming in return_dynamic_filters

Commit f92e62ecfd9a6cb25a527eb1418fdf4c6553ae43 refactored
return_dynamic_filters.php

There was an error in that refactoring where a variable name wasn't
properly renamed ($filter to $t_filter_target).

Additionally, this commit renames $t_filter_target to $f_filter_target
in accordance with the coding standards. $f_filter_target is form data
supplied by the user.
Affected Issues
0011263
mod - return_dynamic_filters.php Diff File