View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011263 | mantisbt | filters | public | 2009-12-06 09:53 | 2010-02-22 14:34 |
Reporter | dhx | Assigned To | dhx | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0 | ||||
Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
Summary | 0011263: return_dynamic_filters.php produces non-standard error messages | ||||
Description | This file is quite ugly and needs some refactoring. The main problem is that it outputs its own inline error messages instead of calling trigger_error() like every other script does. It also doesn't use gpc_api (and instead directly uses $_GET). | ||||
Tags | No tags attached. | ||||
MantisBT: master-1.2.x ce2c3272 2009-12-06 09:53 Details Diff |
Fix 0011263: Refactor and cleanup return_dynamic_filters.php This file didn't use already-available API such as error_api and gpc_api. Thus it had poor duplication of existing code, leading to a number of bugs, mostly relating to the display of error messages. The file should be a little bit cleaner and easier to read now. |
Affected Issues 0011263 |
|
mod - lang/strings_english.txt | Diff File | ||
mod - return_dynamic_filters.php | Diff File | ||
MantisBT: master f92e62ec 2009-12-06 09:53 Details Diff |
Fix 0011263: Refactor and cleanup return_dynamic_filters.php This file didn't use already-available API such as error_api and gpc_api. Thus it had poor duplication of existing code, leading to a number of bugs, mostly relating to the display of error messages. The file should be a little bit cleaner and easier to read now. |
Affected Issues 0011263 |
|
mod - return_dynamic_filters.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
MantisBT: master-1.2.x f812d51c 2010-02-18 10:01 Details Diff |
Fix 0011263: Incorrect variable naming in return_dynamic_filters Commit ce2c32727936bb65405878c4f0ae3967cd340500 refactored return_dynamic_filters.php There was an error in that refactoring where a variable name wasn't properly renamed ($filter to $t_filter_target). Additionally, this commit renames $t_filter_target to $f_filter_target in accordance with the coding standards. $f_filter_target is form data supplied by the user. |
Affected Issues 0011263 |
|
mod - return_dynamic_filters.php | Diff File | ||
MantisBT: master cd4ef16c 2010-02-18 10:01 Details Diff |
Fix 0011263: Incorrect variable naming in return_dynamic_filters Commit f92e62ecfd9a6cb25a527eb1418fdf4c6553ae43 refactored return_dynamic_filters.php There was an error in that refactoring where a variable name wasn't properly renamed ($filter to $t_filter_target). Additionally, this commit renames $t_filter_target to $f_filter_target in accordance with the coding standards. $f_filter_target is form data supplied by the user. |
Affected Issues 0011263 |
|
mod - return_dynamic_filters.php | Diff File |