|
|
@brianstv, please verify the attached patch. |
|
|
|
Thanks brianstv and Victor! I've been experiencing this problem for quite some time and haven't had a chance to properly look at the cause (or work out how filters work in Mantis).
I can confirm that the patch works, so I committed it.
@brianstv, if you were expecting something else, please reopen this bug. Thanks again for your help in fixing this! |
|
|
|
Patch didn't fully work for me.
It keeps the i:1 from getting saved in the filter_table, but it never picks up the default setting from config( 'show_sticky_issues' )
Making the following changes fixed it for me.
In core/filter_api.php
@@ -459,7 +459,7 @@ function filter_ensure_valid_filter( $p_filter_arr ) {
$p_filter_arr[FILTER_PROPERTY_HIGHLIGHT_CHANGED] = config_get( 'default_show_changed' );
}
if( !isset( $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] ) ) {
- $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_string_to_bool( config_get( 'show_sticky_issues' ) );
- $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = (gpc_string_to_bool( config_get( 'show_sticky_issues' )) ? 'on' : 'off' );
}
if( !isset( $p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] ) ) {
$p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] = "last_updated";
In search.php
@@ -89,7 +89,7 @@
$my_filter[FILTER_PROPERTY_RELATIONSHIP_BUG] = gpc_get_int( FILTER_SEARCH_RELATIONSHIP_BUG, 0 );
$my_filter[FILTER_PROPERTY_HIDE_STATUS_ID] = gpc_get_int( FILTER_SEARCH_HIDE_STATUS_ID, config_get( 'hide_status_default' ) );
- $my_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_get_bool( FILTER_SEARCH_SHOW_STICKY_ISSUES, config_get( 'show_sticky_issues' ) );
-
$my_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_get_string( FILTER_SEARCH_SHOW_STICKY_ISSUES, (gpc_string_to_bool( config_get( 'show_sticky_issues' )) ? 'on' : 'off' ) );
$my_filter[FILTER_PROPERTY_SORT_FIELD_NAME] = gpc_get_string( FILTER_SEARCH_SORT_FIELD_NAME, '' );
$my_filter[FILTER_PROPERTY_SORT_DIRECTION] = gpc_get_string( FILTER_SEARCH_SORT_DIRECTION, '' );
In view_all_set.php
@@ -205,7 +205,7 @@
these are only single values, even when doing advanced filtering
$f_per_page = gpc_get_int( FILTER_PROPERTY_ISSUES_PER_PAGE, -1 );
$f_highlight_changed = gpc_get_int( FILTER_PROPERTY_HIGHLIGHT_CHANGED, config_get( 'default_show_changed' ) );
|
|
|
|
I still have something messed up, as now I can't set Show Sticky Issues to 'no' in the view_issues page. |
|
|
|
Found my problem: Disregard the change to view_all_set.php |
|
|
|
So what you're saying is that your diff above (disregarding the changes to view_all_set.php) is required to properly fix this issue? Or is everything OK as-is? |
|
|
|
The changes to core/filter_api.php and search.php are needed to pick up the default from the config_get when the user doesn't have a current filter in the mantis_filters_table.
Worked in my testing.
In core/filter_api.php
@@ -459,7 +459,7 @@ function filter_ensure_valid_filter( $p_filter_arr ) {
$p_filter_arr[FILTER_PROPERTY_HIGHLIGHT_CHANGED] = config_get( 'default_show_changed' );
}
if( !isset( $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] ) ) {
- $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_string_to_bool( config_get( 'show_sticky_issues' ) );
- $p_filter_arr[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = (gpc_string_to_bool( config_get( 'show_sticky_issues' )) ? 'on' : 'off' );
}
if( !isset( $p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] ) ) {
$p_filter_arr[FILTER_PROPERTY_SORT_FIELD_NAME] = "last_updated";
And in search.php
@@ -89,7 +89,7 @@
$my_filter[FILTER_PROPERTY_RELATIONSHIP_BUG] = gpc_get_int( FILTER_SEARCH_RELATIONSHIP_BUG, 0 );
$my_filter[FILTER_PROPERTY_HIDE_STATUS_ID] = gpc_get_int( FILTER_SEARCH_HIDE_STATUS_ID, config_get( 'hide_status_default' ) );
- $my_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_get_bool( FILTER_SEARCH_SHOW_STICKY_ISSUES, config_get( 'show_sticky_issues' ) );
-
$my_filter[FILTER_PROPERTY_SHOW_STICKY_ISSUES] = gpc_get_string( FILTER_SEARCH_SHOW_STICKY_ISSUES, (gpc_string_to_bool( config_get( 'show_sticky_issues' )) ? 'on' : 'off' ) );
$my_filter[FILTER_PROPERTY_SORT_FIELD_NAME] = gpc_get_string( FILTER_SEARCH_SORT_FIELD_NAME, '' );
$my_filter[FILTER_PROPERTY_SORT_DIRECTION] = gpc_get_string( FILTER_SEARCH_SORT_DIRECTION, '' );
|
|
|
|
gpc_string_to_bool( config_get( 'show_sticky_issues' )) is redundant because config_get will return a boolean (either ON = 1 or OFF = 0) that can be directly evaluated.
Also can someone (this is not directed to anyone in particular) explain why we're using strings 'on' and 'off' internally within Mantis? I can understand using them to make permalinks look pretty, but everywhere else it seems to just be unwanted extra complexity. |
|
|
|
Update meta data. Showstopper 1.2.0 |
|
|
|
We shouldn't be using 'on' and 'off' in the database. The patch I checked in removed these and replaced them with true / false.
I've targeted for 1.3.x, unless someone fixes it earlier. |
|
|
|
This should now be fixed (hopefully) as part of changes made in 0013937.
You'll need to reset the filter for your current user to see any effect.
'on' and 'off' have been completely replaced with true/false. Type checking has also been performed. |
|
|
|
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
|
