0011080: Add a feature to reflect that a user is absent

(0031624)
JeromyK (reporter)
2012-04-10 06:39

*kick*

This would be very helpful, because a the moment we just give the order to the users to manually "accept" the ticket, so the reporter has a feedback. Otherwise he don´t know, if the ticket was even read.

(0034667)
cas (reporter)
2013-01-02 11:01
edited on: 2013-01-02 17:34

as described in 0015339, this could be handled by the same plugin.
Currently there are not too many events available within user management but that is easy to address.

(0034679)
dregad (developer)
2013-01-02 17:35

cas, if you feel like writing a plugin and need new events, feel free to request them (preferably with pull request or unified diff)

(0034689)
cas (reporter)
2013-01-03 08:03

Since we can use this functionality too, i will create the plugin. For the additional events I will supply an unified diff.

Hope to realize this plugin somewhere this month.

(0034697)
cas (reporter)
2013-01-04 06:35

attached an initial version,please test

(0034702)
dregad (developer)
2013-01-04 18:29

That was a short month ;-)

Preliminary note: I have not actually tested the plugin itself, just took a quick look at with specific focus on the new events.

Some comments:
- for consistency with existing events, I think the new ones would be better called EVENT_ACCOUNT_UPDATE_FORM and EVENT_ACCOUNT_DELETED
- the formal definition for new events seems to be missing from your submission / documentation (-> changes to events_inc.php ?)
- again for consistency, I think the "admin" account pages should issue the event signals as well
- On the plugin's schema
  - I assume that user_id is a foreign key, and as such it seems strange that it should be autoincrement.
  - Similarly, user_backup is definitely a FK, so I suggest to name it backup_user_id instead.
  - If absent is just a yes/no flag, it should probably be defined as boolean (type 'L')

While we're at it, I think it may make sense to add a few additional events to MantisBT core to provide a more comprehensive set of hook points for future plugins revolving around user accounts management (e.g. creation, update, etc).

That's it for now.

(0034704)
cas (reporter)
2013-01-05 04:49

well it is not finished yet..........
For the events, I will rename them in order to follow convention.
As for the formal definition of new events, I decided to wait till i got all comments. For now, testers should just add the events manual and verify functionality. I will create the diff's with winmerge unless you suggest a better option (will also be testing UnxUtils).
Copying can be dangerous, user_id should not be auto_incrementing.
Will rename user_backup, that is an easy one.
Although for now absent is simply yes/no, i defined it as integer since it could be used for future additional functionality (like value 2 = absent regardless period).

(0034705)
cas (reporter)
2013-01-05 05:09

Added an updated version based upon initial comments.
Please remove old plugin in full including table from database and changes to mantis scripts.

(0034707)
ZoTyA1975 (reporter)
2013-01-05 07:55

Parse error: syntax error, unexpected T_STRING, expecting ']' in /var/www/clients/client0/web16/web/plugins/Holidays/Holidays.php on line 63

In line 54 change
$mail[1] = $row['backup_user];

to

$mail[1] = $row['backup_user'];

(0034708)
cas (reporter)
2013-01-05 10:13

Thanks for reporting, fixed in next version.

(0034712)
cas (reporter)
2013-01-06 08:10

Added version 0.92 including patches for mantis (excluded events_inc.php though). These can be found in the DOC directory.
Apart from reported typo, added additional option for absence (period independent), build in check on valid backup user and incorporated standard manage_user pages.
For me this is final unless issues are reported.

(0034713)
cas (reporter)
2013-01-06 08:35
edited on: 2013-01-06 08:51

Think I should use a different event in manage_user pages from account_page.
Handled in updated release 0.93.

(0034737)
cas (reporter)
2013-01-08 10:02
edited on: 2013-01-08 11:03

A slight change in lay-out of the form used to define once holiday.
Currently awaiting feedback in order to make a final release (1.00)

(0034739)
yany (reporter)
2013-01-08 10:16

Unfortunately I can't test patches on our instance of Mantis (it's under heavy use and could cause troubles if something goes wrong with a patch), but I'm eagerly awaiting this feature in a release. Is there a target version for this feature?

(0034740)
dregad (developer)
2013-01-08 10:16

I'll try to have a look later this week if I can manage

(0034742)
cas (reporter)
2013-01-08 11:04

@yany, implementing a new version seems to have more impact than applying intotal 4 patches.
As for a target version, we have to await feedback form Damien.

(0034744)
cas (reporter)
2013-01-09 06:42

Added a check @ system startup if user is authenticated

(0034745)
dregad (developer)
2013-01-09 10:35

@yany

> Unfortunately I can't test patches on our instance of Mantis

Considering that you are one of the requestors of this new feature, and it's due to your pressure that cas agreed to develop the plugin, I think it's the least you could do to actually perform some tests.

I fully understand you not wanting to do so on a Prod system, but it should not be too difficult to copy the DB and setup a test instance where you can play without disruption to normal activity, no ?

(0034747)
cas (reporter)
2013-01-09 11:04

I have moved this into our production environment.
Only comment sofar is that initial value of the dates is 1970.
This I have already addressed, it will be an empty field.

(0034789)
cas (reporter)
2013-01-14 09:10

Adjusted the update routine in case no dates are needed.

(0034792)
atrol (developer)
2013-01-14 17:08
edited on: 2013-01-14 17:09

@cas
Did you forget to upload your latest version?
I see no new attachment which is uploaded after after note 0011080:0034789 has been posted.

(0034793)
cas (reporter)
2013-01-15 07:29

Was hoping to have more feedback before releasing another version.
But it is attached now.
I do have a question here.
When selecting a backup user, i show a dropdownbox with developers only but the functionality is available to all. Should i show a dropdownlist with all users or what would be the best approach here? Making the functionality available to developers only, would mean to implement this functionality project dependent or to make it available to all that have a developer role somewhere in the system. Think the last option, would be the best.
Any comments?

(0035994)
cas (reporter)
2013-03-29 08:53

As far as I am concerned, this issue can be closed.

Issue History
Date Modified	Username	Field	Change
2009-10-26 09:44	atrol	New Issue
2012-04-10 06:39	JeromyK	Note Added: 0031624
2013-01-02 06:33	atrol	Relationship added	related to 0015339
2013-01-02 11:01	cas	Note Added: 0034667
2013-01-02 17:34	dregad	Note Edited: 0034667	View Revisions
2013-01-02 17:35	dregad	Note Added: 0034679
2013-01-02 17:36	dregad	Severity	minor => feature
2013-01-02 17:36	dregad	Status	new => acknowledged
2013-01-02 17:36	dregad	Category	feature => administration
2013-01-03 08:03	cas	Note Added: 0034689
2013-01-04 06:35	cas	File Added: Holidays090.zip
2013-01-04 06:35	cas	Note Added: 0034697
2013-01-04 18:29	dregad	Note Added: 0034702
2013-01-05 04:49	cas	Note Added: 0034704
2013-01-05 05:06	cas	File Added: Holidays091.zip
2013-01-05 05:09	cas	Note Added: 0034705
2013-01-05 07:55	ZoTyA1975	Note Added: 0034707
2013-01-05 10:13	cas	Note Added: 0034708
2013-01-06 06:03	dregad	Relationship replaced	has duplicate 0015339
2013-01-06 08:06	cas	File Added: Holidays092.zip
2013-01-06 08:10	cas	Note Added: 0034712
2013-01-06 08:35	cas	Note Added: 0034713
2013-01-06 08:50	cas	File Added: Holidays093.zip
2013-01-06 08:50	cas	Note Edited: 0034713	View Revisions
2013-01-06 08:51	cas	Note Edited: 0034713	View Revisions
2013-01-08 10:01	cas	File Added: Holidays094.zip
2013-01-08 10:02	cas	Note Added: 0034737
2013-01-08 10:16	yany	Note Added: 0034739
2013-01-08 10:16	dregad	Note Added: 0034740
2013-01-08 11:03	cas	Note Edited: 0034737	View Revisions
2013-01-08 11:04	cas	Note Added: 0034742
2013-01-09 06:42	cas	Note Added: 0034744
2013-01-09 06:42	cas	File Added: Holidays095.zip
2013-01-09 10:35	dregad	Note Added: 0034745
2013-01-09 11:04	cas	Note Added: 0034747
2013-01-14 09:10	cas	Note Added: 0034789
2013-01-14 17:08	atrol	Note Added: 0034792
2013-01-14 17:09	atrol	Note Edited: 0034792	View Revisions
2013-01-15 07:29	cas	Note Added: 0034793
2013-01-15 07:30	cas	File Added: Holidays096.zip
2013-03-19 04:43	dregad	Relationship added	related to 0011178
2013-03-19 12:24	atrol	File Added: Holidays097.zip
2013-03-29 08:53	cas	Note Added: 0035994

Notes
(0031624) JeromyK (reporter) 2012-04-10 06:39	kick This would be very helpful, because a the moment we just give the order to the users to manually "accept" the ticket, so the reporter has a feedback. Otherwise he don´t know, if the ticket was even read.

(0034667) cas (reporter) 2013-01-02 11:01 edited on: 2013-01-02 17:34	as described in 0015339, this could be handled by the same plugin. Currently there are not too many events available within user management but that is easy to address.

(0034679) dregad (developer) 2013-01-02 17:35	cas, if you feel like writing a plugin and need new events, feel free to request them (preferably with pull request or unified diff)

(0034689) cas (reporter) 2013-01-03 08:03	Since we can use this functionality too, i will create the plugin. For the additional events I will supply an unified diff. Hope to realize this plugin somewhere this month.

(0034697) cas (reporter) 2013-01-04 06:35	attached an initial version,please test

(0034702) dregad (developer) 2013-01-04 18:29	That was a short month ;-) Preliminary note: I have not actually tested the plugin itself, just took a quick look at with specific focus on the new events. Some comments: - for consistency with existing events, I think the new ones would be better called EVENT_ACCOUNT_UPDATE_FORM and EVENT_ACCOUNT_DELETED - the formal definition for new events seems to be missing from your submission / documentation (-> changes to events_inc.php ?) - again for consistency, I think the "admin" account pages should issue the event signals as well - On the plugin's schema - I assume that user_id is a foreign key, and as such it seems strange that it should be autoincrement. - Similarly, user_backup is definitely a FK, so I suggest to name it backup_user_id instead. - If absent is just a yes/no flag, it should probably be defined as boolean (type 'L') While we're at it, I think it may make sense to add a few additional events to MantisBT core to provide a more comprehensive set of hook points for future plugins revolving around user accounts management (e.g. creation, update, etc). That's it for now.

(0034704) cas (reporter) 2013-01-05 04:49	well it is not finished yet.......... For the events, I will rename them in order to follow convention. As for the formal definition of new events, I decided to wait till i got all comments. For now, testers should just add the events manual and verify functionality. I will create the diff's with winmerge unless you suggest a better option (will also be testing UnxUtils). Copying can be dangerous, user_id should not be auto_incrementing. Will rename user_backup, that is an easy one. Although for now absent is simply yes/no, i defined it as integer since it could be used for future additional functionality (like value 2 = absent regardless period).

(0034705) cas (reporter) 2013-01-05 05:09	Added an updated version based upon initial comments. Please remove old plugin in full including table from database and changes to mantis scripts.

(0034707) ZoTyA1975 (reporter) 2013-01-05 07:55	Parse error: syntax error, unexpected T_STRING, expecting ']' in /var/www/clients/client0/web16/web/plugins/Holidays/Holidays.php on line 63 In line 54 change $mail[1] = $row['backup_user]; to $mail[1] = $row['backup_user'];

(0034708) cas (reporter) 2013-01-05 10:13	Thanks for reporting, fixed in next version.

(0034712) cas (reporter) 2013-01-06 08:10	Added version 0.92 including patches for mantis (excluded events_inc.php though). These can be found in the DOC directory. Apart from reported typo, added additional option for absence (period independent), build in check on valid backup user and incorporated standard manage_user pages. For me this is final unless issues are reported.

(0034713) cas (reporter) 2013-01-06 08:35 edited on: 2013-01-06 08:51	Think I should use a different event in manage_user pages from account_page. Handled in updated release 0.93.

(0034737) cas (reporter) 2013-01-08 10:02 edited on: 2013-01-08 11:03	A slight change in lay-out of the form used to define once holiday. Currently awaiting feedback in order to make a final release (1.00)

(0034739) yany (reporter) 2013-01-08 10:16	Unfortunately I can't test patches on our instance of Mantis (it's under heavy use and could cause troubles if something goes wrong with a patch), but I'm eagerly awaiting this feature in a release. Is there a target version for this feature?

(0034740) dregad (developer) 2013-01-08 10:16	I'll try to have a look later this week if I can manage

(0034742) cas (reporter) 2013-01-08 11:04	@yany, implementing a new version seems to have more impact than applying intotal 4 patches. As for a target version, we have to await feedback form Damien.

(0034744) cas (reporter) 2013-01-09 06:42	Added a check @ system startup if user is authenticated

(0034745) dregad (developer) 2013-01-09 10:35	@yany > Unfortunately I can't test patches on our instance of Mantis Considering that you are one of the requestors of this new feature, and it's due to your pressure that cas agreed to develop the plugin, I think it's the least you could do to actually perform some tests. I fully understand you not wanting to do so on a Prod system, but it should not be too difficult to copy the DB and setup a test instance where you can play without disruption to normal activity, no ?

(0034747) cas (reporter) 2013-01-09 11:04	I have moved this into our production environment. Only comment sofar is that initial value of the dates is 1970. This I have already addressed, it will be an empty field.

(0034789) cas (reporter) 2013-01-14 09:10	Adjusted the update routine in case no dates are needed.

(0034792) atrol (developer) 2013-01-14 17:08 edited on: 2013-01-14 17:09	@cas Did you forget to upload your latest version? I see no new attachment which is uploaded after after note 0011080:0034789 has been posted.

(0034793) cas (reporter) 2013-01-15 07:29	Was hoping to have more feedback before releasing another version. But it is attached now. I do have a question here. When selecting a backup user, i show a dropdownbox with developers only but the functionality is available to all. Should i show a dropdownlist with all users or what would be the best approach here? Making the functionality available to developers only, would mean to implement this functionality project dependent or to make it available to all that have a developer role somewhere in the system. Think the last option, would be the best. Any comments?

(0035994) cas (reporter) 2013-03-29 08:53	As far as I am concerned, this issue can be closed.