View Issue Details

IDProjectCategoryView StatusLast Update
0011053mantisbtotherpublic2010-02-22 14:35
Reporterwatergad Assigned Tovboctor  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.2.0rc2 
Fixed in Version1.2.0 
Summary0011053: Using real names and monitoring
Description

When real names are used ($g_show_realname = ON) there are some kind of confusion:
You see real names everywhere but you must enter username to Monitor issue by defined user.

Of course you can click real name and see username, but its not obvious for users.

TagsNo tags attached.

Activities

watergad

watergad

2009-10-24 11:22

reporter   ~0023309

Last edited: 2009-10-24 11:25

I've tweaked bug_monitor_add.php this way:
// after line 43
$t_user_id = user_get_id_by_name( $f_username );
// added this:
if ( $t_user_id === false )
$t_user_id = user_get_id_by_realname( $f_username );

This way I can do what I've asked here.

and not so harmless tweak in addition -
user_api.php, user_get_id_by_realname() function:
// from line 686, modified query:
// instead of
// $query = "SELECT
// FROM $t_user_table
// WHERE realname=" . db_param();
// done this:
$query = "SELECT

FROM $t_user_table
WHERE realname like " . db_param() . " ORDER BY date_created ASC";
// and instead of
// $result = db_query_bound( $query, Array( $p_realname ) );
// tweak:
$result = db_query_bound( $query, Array( $p_realname.'%' ) );

This way I can add monitoring users by typing only the realname beginning such as surname. It's possible to make '%'.$p_realname.'%' for the 'like' but its not good for me.

vboctor

vboctor

2009-10-26 03:01

manager   ~0023322

I just noticed your note now. I have added support for realname, but not for partial match. I'm not comfortable taking the second part of your proposed change. In the future, this can be added as auto-complete feature to the UI. This will allow you to verify the match before attempt to do the add.

Related Changesets

MantisBT: master-1.2.x b4fe91cb

2009-10-26 02:35

vboctor


Details Diff
Fixes 0011053: Using real names and monitoring. Affected Issues
0011053
mod - bug_monitor_add.php Diff File

MantisBT: master d5c21376

2009-10-26 02:35

vboctor


Details Diff
Fixes 0011053: Using real names and monitoring. Affected Issues
0011053
mod - bug_monitor_add.php Diff File